From f3e4968626c37b5bd90ad29fc0d9b9bacd838466 Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Fri, 16 Dec 2016 10:44:04 +1300 Subject: [PATCH 1/2] Only enable getblocktemplate when wallet is enabled --- src/rpcmining.cpp | 2 ++ src/rpcserver.cpp | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/rpcmining.cpp b/src/rpcmining.cpp index d58e70adc..474541bd4 100644 --- a/src/rpcmining.cpp +++ b/src/rpcmining.cpp @@ -401,6 +401,7 @@ static Value BIP22ValidationResult(const CValidationState& state) return "valid?"; } +#ifdef ENABLE_WALLET Value getblocktemplate(const Array& params, bool fHelp) { if (fHelp || params.size() > 1) @@ -694,6 +695,7 @@ Value getblocktemplate(const Array& params, bool fHelp) return result; } +#endif class submitblock_StateCatcher : public CValidationInterface { diff --git a/src/rpcserver.cpp b/src/rpcserver.cpp index e354e91a4..00ea417c3 100644 --- a/src/rpcserver.cpp +++ b/src/rpcserver.cpp @@ -302,7 +302,9 @@ static const CRPCCommand vRPCCommands[] = { "blockchain", "verifychain", &verifychain, true }, /* Mining */ +#ifdef ENABLE_WALLET { "mining", "getblocktemplate", &getblocktemplate, true }, +#endif { "mining", "getmininginfo", &getmininginfo, true }, { "mining", "getlocalsolps", &getlocalsolps, true }, { "mining", "getnetworksolps", &getnetworksolps, true }, From 6daab5b4fcb409812275405006b38676a1439180 Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Fri, 16 Dec 2016 10:52:00 +1300 Subject: [PATCH 2/2] Only run wallet tests when wallet is enabled --- src/Makefile.gtest.include | 4 ++-- src/gtest/test_keystore.cpp | 4 ++++ src/{ => wallet}/gtest/test_wallet_zkeys.cpp | 0 3 files changed, 6 insertions(+), 2 deletions(-) rename src/{ => wallet}/gtest/test_wallet_zkeys.cpp (100%) diff --git a/src/Makefile.gtest.include b/src/Makefile.gtest.include index a7071f3b7..1c9203ffa 100644 --- a/src/Makefile.gtest.include +++ b/src/Makefile.gtest.include @@ -11,7 +11,6 @@ zcash_gtest_SOURCES = \ gtest/json_test_vectors.cpp \ gtest/json_test_vectors.h \ gtest/test_foundersreward.cpp \ - gtest/test_wallet_zkeys.cpp \ gtest/test_jsonspirit.cpp \ gtest/test_tautology.cpp \ gtest/test_equihash.cpp \ @@ -31,7 +30,8 @@ zcash_gtest_SOURCES = \ gtest/test_checkblock.cpp if ENABLE_WALLET zcash_gtest_SOURCES += \ - wallet/gtest/test_wallet.cpp + wallet/gtest/test_wallet.cpp \ + wallet/gtest/test_wallet_zkeys.cpp endif zcash_gtest_CPPFLAGS = -DMULTICORE -fopenmp -DBINARY_OUTPUT -DCURVE_ALT_BN128 -DSTATIC diff --git a/src/gtest/test_keystore.cpp b/src/gtest/test_keystore.cpp index 26fde42d9..e94aea53e 100644 --- a/src/gtest/test_keystore.cpp +++ b/src/gtest/test_keystore.cpp @@ -2,7 +2,9 @@ #include "keystore.h" #include "random.h" +#ifdef ENABLE_WALLET #include "wallet/crypter.h" +#endif #include "zcash/Address.hpp" TEST(keystore_tests, store_and_retrieve_spending_key) { @@ -44,6 +46,7 @@ TEST(keystore_tests, store_and_retrieve_note_decryptor) { EXPECT_EQ(ZCNoteDecryption(sk.viewing_key()), decOut); } +#ifdef ENABLE_WALLET class TestCCryptoKeyStore : public CCryptoKeyStore { public: @@ -125,3 +128,4 @@ TEST(keystore_tests, store_and_retrieve_spending_key_in_encrypted_store) { ASSERT_EQ(1, addrs.count(addr)); ASSERT_EQ(1, addrs.count(addr2)); } +#endif diff --git a/src/gtest/test_wallet_zkeys.cpp b/src/wallet/gtest/test_wallet_zkeys.cpp similarity index 100% rename from src/gtest/test_wallet_zkeys.cpp rename to src/wallet/gtest/test_wallet_zkeys.cpp