Clarify branching and force-building operations in hotfix process

This commit is contained in:
Jack Grigg 2017-09-15 10:51:21 +01:00
parent 24bfc7c6c6
commit de3e143461
No known key found for this signature in database
GPG Key ID: 665DBCD284F7DAFF
1 changed files with 15 additions and 4 deletions

View File

@ -18,13 +18,24 @@ repository:
$ git branch hotfix-<RELEASE> <RELEASE_PREV>
$ git push 'git@github.com:zcash/zcash' hotfix-<RELEASE>
## Implement hotfix changes
Hotfix changes are implemented the same way as regular changes (developers work
in separate branches per change, and push the branches to their own repositories),
except that the branches are based on the hotfix branch instead of master:
$ git checkout hotfix-<RELEASE>
$ git checkout -b <BRANCH_NAME>
## Merge hotfix PRs
Developer should create hotfix PRs based on the hotfix branch. Each PR should be
reviewed as normal, and then the following process should be used to merge:
Hotfix PRs are created like regular PRs, except using the hotfix branch as the
base instead of master. Each PR should be reviewed as normal, and then the
following process should be used to merge:
- A CI merge build is manually run, by force-triggering the pr-merge builder
with the following fields set:
- A CI merge build is manually run by logging into the CI server, going to the
pr-merge builder, clicking the "force" button, and entering the following
values:
- Repository: https://github.com/<DevUser>/zcash
- <DevUser> must be in the set of "safe" users as-specified in the CI