From 92b42d287e7101fe5c1fb5c8698edd9ec2314d39 Mon Sep 17 00:00:00 2001 From: "Jonathan \"Duke\" Leto" Date: Sun, 23 Sep 2018 06:18:22 -0700 Subject: [PATCH 1/2] Clarify in sendmany/z_sendmany rpc docs that amounts are not floating point --- src/wallet/rpcwallet.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp index 82b98304a..52caac6ac 100644 --- a/src/wallet/rpcwallet.cpp +++ b/src/wallet/rpcwallet.cpp @@ -960,7 +960,7 @@ UniValue sendmany(const UniValue& params, bool fHelp) if (fHelp || params.size() < 2 || params.size() > 5) throw runtime_error( "sendmany \"fromaccount\" {\"address\":amount,...} ( minconf \"comment\" [\"address\",...] )\n" - "\nSend multiple times. Amounts are double-precision floating point numbers." + "\nSend multiple times. Amounts are decimal numbers with at most 8 digits of precision." + HelpRequiringPassphrase() + "\n" "\nArguments:\n" "1. \"fromaccount\" (string, required) MUST be set to the empty string \"\" to represent the default account. Passing any other string will result in an error.\n" @@ -3583,7 +3583,7 @@ UniValue z_sendmany(const UniValue& params, bool fHelp) if (fHelp || params.size() < 2 || params.size() > 4) throw runtime_error( "z_sendmany \"fromaddress\" [{\"address\":... ,\"amount\":...},...] ( minconf ) ( fee )\n" - "\nSend multiple times. Amounts are double-precision floating point numbers." + "\nSend multiple times. Amounts are decimal numbers with at most 8 digits of precision." "\nChange generated from a taddr flows to a new taddr address, while change generated from a zaddr returns to itself." "\nWhen sending coinbase UTXOs to a zaddr, change is not allowed. The entire value of the UTXO(s) must be consumed." + strprintf("\nBefore Sapling activates, the maximum number of zaddr outputs is %d due to transaction size limits.\n", Z_SENDMANY_MAX_ZADDR_OUTPUTS_BEFORE_SAPLING) From 5707edd4b123d155dd890aea9166aac81a37883e Mon Sep 17 00:00:00 2001 From: "Jonathan \"Duke\" Leto" Date: Sun, 14 Oct 2018 06:37:25 -0700 Subject: [PATCH 2/2] Fix another instance of incorrectly saying amount is double precision, and s/ZC/ZEC/ --- doc/payment-api.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/payment-api.md b/doc/payment-api.md index 5d43ed4ac..9ae6c57c9 100644 --- a/doc/payment-api.md +++ b/doc/payment-api.md @@ -39,7 +39,7 @@ RPC parameter conventions: * taddr : Transparent address * zaddr : Private address * address : Accepts both private and transparent addresses. -* amount : JSON format double-precision number with 1 ZC expressed as 1.00000000. +* amount : JSON format decimal number with at most 8 digits of precision, with 1 ZEC expressed as 1.00000000. * memo : Metadata expressed in hexadecimal format. Limited to 512 bytes, the current size of the memo field of a private transaction. Zero padding is automatic. ### Accounting