Simon
d77a0ac4a0
Closes #2446 by adding generated field to listunspent.
...
If generated is true, the unspent transaction output is from a
coinbase transaction and can only be sent to a shielded address.
2017-07-11 10:44:36 -07:00
Jack Grigg
c66c731adf
Add a benchmark for calling ConnectBlock on a block with many inputs
...
Requires placing block-107134.tar.gz (containing the block, and a fake CoinsDB
containing its inputs) into the base directory of the repository. This can be
generated using qa/zcash/create_benchmark_archive.py (see the script for usage
details).
To facilitate generation of the fake CoinsDB, an additional field 'valueZat' has
been added to 'getrawtransaction' containing the integer number of zatoshis
instead of a decimal number of ZEC.
Closes #2355 .
2017-05-18 11:03:46 +12:00
Jay Graber
704547965a
Change help text examples to use Zcash addresses
2017-03-24 14:52:28 -07:00
Jack Grigg
3c014397a9
BTC -> ZEC in paytxfee RPC docs
...
Revert before merging bitcoin/bitcoin#6504 .
2017-03-02 13:26:34 -08:00
Matt Corallo
3d8013a01b
Add fundrawtransaction RPC method
2017-03-02 13:23:03 -08:00
Stephen
6699b42518
Add paytxfee to getwalletinfo, warnings to getnetworkinfo
2017-03-02 13:23:03 -08:00
Simon
2f21206cfc
Closes #2112 where z_getoperationresult could return stale status.
2017-02-22 16:14:56 -08:00
Jack Grigg
f54db399f2
Get rid of fPlus argument to FormatMoney in Zcash-specific code
2017-02-10 02:19:14 +00:00
Jack Grigg
c24109ecc3
UniValue::getValues const reference
2017-02-10 02:19:12 +00:00
Wladimir J. van der Laan
e76a3849c6
Changes necessary now that zero values accepted in AmountFromValue
...
- Add an accept test for zero amounts, and a reject test for negative
amounts
- Remove ugly hack in `settxfee` that is no longer necessary
- Do explicit zero checks in wallet RPC functions
- Don't add a check for zero amounts in `createrawtransaction` - this
could be seen as a feature
2017-02-10 02:18:57 +00:00
Jonas Schnelli
a10a6e2a0e
[Univalue] add univalue over subtree
...
similar to secp256k1 include and compile univalue over a subtree
2017-02-10 02:18:51 +00:00
Jack Grigg
cc71666a51
unsigned int -> size_t for comparing with UniValue.size()
2017-02-10 00:53:13 +00:00
Jack Grigg
0d37ae3a59
Migrate Zcash-specific code to UniValue
2017-02-10 00:52:57 +00:00
Jonas Schnelli
d014114d67
Remove JSON Spirit wrapper, remove JSON Spirit leftovers
...
- implement find_value() function for UniValue
- replace all Array/Value/Object types with UniValues, remove JSON Spirit to UniValue wrapper
- remove JSON Spirit sources
2017-02-10 00:35:24 +00:00
Jonas Schnelli
851f58f94e
remove JSON Spirit UniValue wrapper
2017-02-10 00:35:24 +00:00
Jonas Schnelli
38fc4b7090
expicit set UniValue type to avoid empty values
2017-02-10 00:35:24 +00:00
Jonas Schnelli
9756b7bd29
extend conversion to UniValue
2017-02-10 00:35:24 +00:00
Jeff Garzik
ed21d5bd4b
Convert tree to using univalue. Eliminate all json_spirit uses.
2017-02-10 00:35:24 +00:00
Jack Grigg
b8eb37757b
Require -experimentalmode for wallet encryption
2017-02-09 22:10:58 +00:00
zkbot
b2e2dccc64
Auto merge of #2068 - bitcartel:2045_sendmany_fee_zero, r=bitcartel
...
Closes #2045 by allowing z_sendmany with 0 fee
2017-02-09 18:56:44 +00:00
Simon
7eccce4e44
Closes #2045 by allowing z_sendmany with 0 fee
2017-02-06 14:14:28 -08:00
Jack Grigg
2cc0a252ad
Add compile flag to disable compilation of mining code
2017-01-30 21:14:46 +01:00
zkbot
4458f87138
Auto merge of #2028 - bitcartel:std_numeric_gcc_620_compile_issue, r=ebfull
...
Add missing header
Closes #2027 where gcc 6.2.0 identified that `rpcwallet.cpp` was missing a header file `<numeric>` which is required due to usage of `std::accumulate`.
2017-01-18 19:45:02 +00:00
Simon
bcbde86a87
Add missing header required by std::accumulate
2017-01-18 10:52:37 -08:00
zkbot
63e0e895a5
Auto merge of #2006 - bitcartel:1497_destination_path_validation_when_exporting, r=bitcartel
...
Fixes #1497 ZCA-009 by restricting export to a user defined folder and sanitizing filenames
2017-01-18 18:19:50 +00:00
zkbot
4d52160de3
Auto merge of #2001 - bitcartel:1957_add_size_to_listtransactions, r=ebfull
...
Closes #1957 by adding tx serialization size to listtransactions output.
2017-01-18 07:15:35 +00:00
zkbot
1e8778a274
Auto merge of #1976 - bitcartel:1964_z_sendmany_exception_handling, r=ebfull
...
Fixes #1964 to catch general exception in z_sendmany and catch exceptions as reference-to-const.
2017-01-18 03:48:12 +00:00
zkbot
ee2f1ebb9d
Auto merge of #1942 - str4d:1940-threaded-createjoinsplit, r=ebfull
...
Extend createjoinsplit to benchmark parallel JoinSplits
Closes #1940
2017-01-18 01:04:05 +00:00
zkbot
4169cddd64
Auto merge of #1991 - bitcartel:1960_z_getoperation_include_call_details, r=ebfull
...
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-17 19:24:07 +00:00
Simon
8aa7937d44
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-16 16:45:27 -08:00
Simon
f32cade8fd
Closes #1957 by adding tx serialization size to listtransactions output.
2017-01-16 11:07:16 -08:00
Simon
9064d73bf8
Fixes #1497 ZCA-009 by restricting data exporting to user defined folder.
...
Previously the RPC interface allowed z_exportwallet, backupwallet and
dumpwallet to write data to an arbitrary filename. ZCA-009 demonstrates
how this is vulnerable. The resolution is to only allow data to
written when the -exportdir has been configured. Also filenames are
restricted to alphanumeric characters.
2017-01-16 10:56:06 -08:00
Simon
2d2f3d1806
Closes #1780 . Result of z_getoperationstatus now sorted by creation time of operation
2017-01-11 11:49:10 -08:00
Simon
fce7260811
Fixes #1964 to catch general exception in z_sendmany and catch
...
exceptions as reference-to-const.
2017-01-03 12:50:19 -08:00
Jack Grigg
4082dcb10f
Extend createjoinsplit to benchmark parallel JoinSplits
...
Closes #1940
2016-12-14 15:28:00 +13:00
zkbot
8a6c070bfa
Auto merge of #1870 - str4d:1749-benchmark-rescanning, r=str4d
...
Add benchmarks for rescan components
Part of #1749 .
2016-12-09 07:12:22 +00:00
zkbot
a398121503
Auto merge of #1919 - ebfull:abstract-verification, r=str4d
...
Isolate verification to a ProofVerifier context object that allows verification behavior to be tuned by the caller.
This is an alternative foundation for #1892 , i.e., #1892 will have to be changed if this PR is accepted.
I think this is a safer approach because it allows us to isolate verification behavior to a single object. This will come in handy when @arielgabizon finishes the batching code.
2016-12-09 06:22:53 +00:00
Jack Grigg
88b7f3c28b
Generate JS for trydecryptnotes, make number of addresses a variable
2016-12-09 16:59:39 +13:00
Sean Bowe
bc59f53722
Isolate verification to a `ProofVerifier` context object that allows verification behavior to be tuned by the caller.
2016-12-05 12:40:06 -07:00
Simon
af53da0225
Closes #1903 . Add fee parameter to z_sendmany.
2016-11-30 14:23:35 -08:00
Jack Grigg
0bb3d40f90
Add benchmark for incrementing note witnesses
2016-11-17 22:26:46 +13:00
Jack Grigg
0fbab55b1b
Add benchmark for attempting decryption of notes
2016-11-17 19:09:45 +13:00
ayleph
48f9c65b55
Correct spelling error in z_sendmany error output
...
Change "alllowed" -> "allowed."
2016-11-08 13:13:48 -08:00
Simon
3920292b43
Add transaction size and zaddr output limit checks to z_sendmany.
2016-11-07 09:29:56 -08:00
Sean Bowe
58c4c0bba3
Change some Bitcoin strings to Zcash strings.
2016-10-26 13:29:05 -06:00
Simon
db026807b8
Add z_sendmany rule that when sending coinbase utxos to a zaddr
...
they must be consumed entirely, without any change, since there
is currently no way to specify a change address in z_sendmany.
2016-10-24 21:34:16 -07:00
zkbot
71043784dd
Auto merge of #1586 - bitcartel:z_sendmany_amount_too_strict, r=daira
...
Fix issue where z_sendmany amount parameter is too strict
Upstream treats an amount parameter of `1` the same as `1.0`. Third-party would like this fixed.
2016-10-21 22:10:41 -04:00
Simon
75407c6872
Fix issue where z_sendmany is too strict and does not allow integer based amount e.g. 1 which is the same as 1.0
2016-10-20 17:03:57 -07:00
Jack Grigg
1532cb75f3
Throw an error when encryptwallet is disabled
2016-10-20 12:58:20 -05:00
Jack Grigg
62c0aa9e58
Disable wallet encryption
...
Closes #1552
2016-10-18 17:47:17 -05:00