Daira Hopwood
80cbdbc749
Fix an error reporting bug due to BrokenPipeError and ConnectionResetError not existing in Python 2.
...
refs #2263
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-04-14 21:40:30 +01:00
Jack Grigg
338ff45787
Use a larger -rpcclienttimeout for slow performance measurements
...
Closes #2238 .
2017-04-07 15:03:25 +12:00
Simon
99eb947a98
Add AMQP 1.0 support via Apache Qpid Proton C++ API 0.17.0
2017-03-25 08:51:40 -07:00
Wladimir J. van der Laan
f3e1770cfb
tests: Disable Tor interaction
...
This is unnecessary during the current tests (any test for Tor
interaction can explicitly enable it) and interferes with the proxy
test.
2017-03-25 20:25:38 +13:00
zkbot
f9f48667be
Auto merge of #2176 - str4d:1593-libevent, r=bitcartel
...
libevent-based http server
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#5677
- bitcoin/bitcoin#6695
- bitcoin/bitcoin#6899
- bitcoin/bitcoin#7016
- bitcoin/bitcoin#7964
- bitcoin/bitcoin#8722
- bitcoin/bitcoin#8730
- bitcoin/bitcoin#9073
- bitcoin/bitcoin#9265
- bitcoin/bitcoin#9387
- bitcoin/bitcoin#9471
- bitcoin/bitcoin#9647
- bitcoin/bitcoin#9903
- bitcoin/bitcoin#6640
- bitcoin/bitcoin#8139
- bitcoin/bitcoin#8839
Closes #1593 and #1856 .
2017-03-25 04:52:16 +00:00
Jack Grigg
47855b599d
Revert "Revert "rpc-tests: re-enable rpc-tests for Windows""
...
This reverts commit 7fd5d4e30e
.
We need to un-revert this before pulling in
https://github.com/bitcoin/bitcoin/pull/6616
2017-03-25 17:37:18 +13:00
Wladimir J. van der Laan
e93a3e1945
test: Avoid ConnectionResetErrors during RPC tests
...
This is necessary on FreeBSD and MacOSX, at least.
See https://github.com/bitcoin/bitcoin/pull/8834#issuecomment-250450213
2017-03-24 18:43:40 +13:00
Pieter Wuille
2edad86b2d
Fix interrupted HTTP RPC connection workaround for Python 3.5+
2017-03-24 18:43:21 +13:00
zkbot
6344719817
Auto merge of #2052 - str4d:2032-z_importkey-partial-rescan, r=bitcartel
...
Usability improvements for z_importkey
- Add height parameter to z_importkey to reduce rescan range
- Change semantics of rescan parameter, so users can explicitly force a rescan
for existing keys.
Closes #2032
2017-03-24 03:47:11 +00:00
Jack Grigg
53c96bfa6c
Test boolean fallback in z_importkey
2017-03-24 09:23:11 +13:00
Wladimir J. van der Laan
7b41e725d0
Make RPC tests cope with server-side timeout between requests
...
Python's httplib does not graciously handle disconnections from the http server, resulting in BadStatusLine errors.
See https://bugs.python.org/issue3566 "httplib persistent connections violate MUST in RFC2616 sec 8.1.4."
This was fixed in Python 3.5.
Work around it for now.
2017-03-24 09:03:59 +13:00
Wladimir J. van der Laan
7fd5d4e30e
Revert "rpc-tests: re-enable rpc-tests for Windows"
...
This reverts commit bd30c3dced21fca869a14c75081f15195762afe1.
Disable windows RPC tests for now. These should be re-enabled once a
suitable Wine version is used on Travis.
2017-03-24 09:03:59 +13:00
Wladimir J. van der Laan
cc14ac45f4
tests: GET requests cannot have request body, use POST in rest.py
...
Sending a request body with GET request is not valid in HTTP spec, and
not compatible with evhttpd.
2017-03-24 09:03:59 +13:00
Wladimir J. van der Laan
14dcc6ab96
qa: Remove -rpckeepalive tests from httpbasics
...
This option was a temporary workaround, and is no longer necessary
with the new web server.
2017-03-24 09:03:59 +13:00
Jack Grigg
bec25c91cb
Revert "Closes #1680 , temporary fix for rpc deadlock inherited from upstream."
...
This reverts commit f4404d7b5b
.
2017-03-24 09:03:59 +13:00
Jack Grigg
dec148f498
Fix prioritisetransaction RPC test
...
Part of #1884 .
2017-03-23 18:57:46 +13:00
Jack Grigg
b7e5b7d5ee
Simplify z_importkey by making rescan a string
...
Transparently handles older boolean values as well.
2017-03-23 15:57:11 +13:00
Jack Grigg
a31ba7a0cb
Usability improvements for z_importkey
...
- Add height parameter to z_importkey to reduce rescan range
- Change semantics of rescan parameter, so users can explicitly force a rescan
for existing keys.
Closes #2032
2017-03-16 19:34:41 +13:00
Jack Grigg
542a7a40f1
Add tests for getmempoolinfo
2017-03-16 14:30:16 +13:00
Pavel Janík
30c163d99d
Implement REST mempool API, add test and documentation.
2017-03-14 13:52:06 +13:00
zkbot
a7cf698873
Auto merge of #2100 - str4d:2074-rpc, r=arcalinea
...
Bitcoin 0.12 RPC PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6266
- bitcoin/bitcoin#6257
- bitcoin/bitcoin#6271
- bitcoin/bitcoin#6158
- bitcoin/bitcoin#6307
- bitcoin/bitcoin#6290
- bitcoin/bitcoin#6262
- bitcoin/bitcoin#6088
- bitcoin/bitcoin#6339
- bitcoin/bitcoin#6299 (partial, remainder in #2099 )
- bitcoin/bitcoin#6350
- bitcoin/bitcoin#6247
- bitcoin/bitcoin#6362
- bitcoin/bitcoin#5486
- bitcoin/bitcoin#6417
- bitcoin/bitcoin#6398 (partial, remainder was included in #1950 )
- bitcoin/bitcoin#6444
- bitcoin/bitcoin#6456 (partial, remainder was included in #2082 )
- bitcoin/bitcoin#6380
- bitcoin/bitcoin#6970
Part of #2074 .
2017-03-04 02:57:46 +00:00
zkbot
dadb1ab74c
Auto merge of #2101 - str4d:2074-tests, r=arcalinea
...
Bitcoin 0.12 test PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6337
- bitcoin/bitcoin#6390
- bitcoin/bitcoin#5515
- bitcoin/bitcoin#6287 (partial, remainder included in bitcoin/bitcoin#6703)
- bitcoin/bitcoin#6465
Part of #2074 .
2017-03-03 21:25:03 +00:00
Casey Rodarmor
df8f8095b6
Don't share objects between TestInstances
2017-03-03 11:47:12 -08:00
Wladimir J. van der Laan
7cc6648341
tests: Extend RPC proxy tests
...
Also test -noonion
2017-03-03 10:57:13 -08:00
Jack Grigg
25b8f796ff
Re-encode t-addrs in disablewallet.py with Zcash prefixes
2017-03-02 13:26:34 -08:00
Jack Grigg
5329495fe4
Adjust fundrawtransaction RPC test for Zcash
...
- Enable wallet encryption
- Correct block reward
2017-03-02 13:26:34 -08:00
Wladimir J. van der Laan
56215c77d8
Fix crash in validateaddress with -disablewallet
...
Fix a null pointer dereference in validateaddress with -disablewallet. Also add a regression testcase.
2017-03-02 13:26:34 -08:00
Jonas Schnelli
c2616abb3c
[QA] add testcases for parsing strings as values
2017-03-02 13:26:34 -08:00
Wladimir J. van der Laan
d101d7b8e6
univalue: Avoid unnecessary roundtrip through double for numbers
...
JSON makes no distinction between numbers and reals, and our code
doesn't need to do so either.
This removes VREAL, as well as its specific post-processing in
`UniValue::write`. Non-monetary amounts do not need to be forcibly
formatted with 8 decimals, so the extra roundtrip was unnecessary
(and potentially loses precision).
Zcash: cherry-picked from commit 7650449a6777710cf818d41862626164da0cd412
Left over from 2aee461930
2017-03-02 13:26:34 -08:00
zathras-crypto
a11c4bbd26
Exempt unspendable transaction outputs from dust checks
...
Since unspendable outputs can't be spent, there is no threshold at which it would be uneconomic to spend them.
This primarily targets transaction outputs with `OP_RETURN`.
---
Initially based on:
commit 9cf0ae26350033d43d5dd3c95054c0d1b1641eda
Author: zathras-crypto <zathrasc@gmail.com>
Date: Wed Mar 25 02:04:02 2015 -0700
Changes:
- cherry-picked on top of bitcoin:master
- added RPC test for fundrawtransaction
2017-03-02 13:26:34 -08:00
Jonas Schnelli
5bfd954fc6
[QA] remove rawtransactions.py from the extended test list
...
rawtransactions.py is already in the standard test list
2017-03-02 13:23:03 -08:00
Jonas Schnelli
897a370c39
[QA] fix possible reorg issue in rawtransaction.py/fundrawtransaction.py RPC test
...
- added missing mempool sync between block generations
2017-03-02 13:23:03 -08:00
Jonas Schnelli
81eb80d841
[REST] add JSON support for /rest/headers/
2017-03-02 13:23:03 -08:00
mruddy
81ae51c883
add tests for the decodescript rpc. add mention of the rpc regression tests to the testing seciton of the main readme.
2017-03-02 13:23:03 -08:00
Wladimir J. van der Laan
bf890b6518
test: Move reindex test to standard tests
...
This test finishes very quickly, so it should be part of the default set
of tests in rpc-tests.
2017-03-02 13:23:03 -08:00
Jonas Schnelli
788d8e6a6f
fundrawtransaction tests
2017-03-02 13:23:03 -08:00
Jonas Schnelli
2ab237a088
add RPC tests for setban & disconnectnode
2017-03-02 13:23:03 -08:00
Jonas Schnelli
e521939942
[RPC] extend setban to allow subnets
2017-03-02 13:23:03 -08:00
Jonas Schnelli
962ec4b5e4
[QA] add setban/listbanned/clearbanned tests
2017-03-02 13:23:03 -08:00
Stephen
6699b42518
Add paytxfee to getwalletinfo, warnings to getnetworkinfo
2017-03-02 13:23:03 -08:00
zkbot
6ee75b3b7b
Auto merge of #2014 - arcalinea:test-prioritisetransaction, r=arcalinea
...
Test prioritisetransaction
After talking with @str4d about #1884 , I wrote a test for prioritisetransaction. It uses small blocks (11kb), and checks whether a transaction makes it into the next block after being prioritized by that node.
Should this be improved with a larger number of txs in the mempool, or by testing over multiple runs?
As for getblocktemplate(), it seems to return the prioritized transaction within the block size set by the node (about 50 txs fit in an 11kb block), but the block "sizelimit" it displays is set at 2 MB in `rpcmining.cpp` line 690:
```
result.push_back(Pair("sizelimit", (int64_t)MAX_BLOCK_SIZE));
```
This was quite confusing, I didn't think the `-blockmaxsize` parameter I was setting was working for awhile.
2017-03-02 06:47:04 +00:00
Simon
85c9ecb846
Part of #1969 . Update tests to avoid error 'absurdly high fee' from change in min fee calc.
2017-02-28 11:44:51 -08:00
Simon
ebe750a882
Part of #1969 . Changing min fee calculation also changes the dust threshold.
2017-02-28 11:44:07 -08:00
Jay Graber
8d2dac6e3f
Inc num of txs in test mempool
2017-02-27 14:11:09 -08:00
Jay Graber
cc64e2ccc8
Add rpc test for prioritisetransaction
2017-02-12 11:01:45 -08:00
Simon
238fec642d
Update test to check for updated error messages in AmountFromValue().
2017-02-09 23:32:15 -08:00
zkbot
7d4ced95ed
Auto merge of #2056 - str4d:2035-experimental-mode, r=bitcartel
...
Add a flag for enabling experimental features
Closes #2035 .
2017-02-09 23:39:02 +00:00
zkbot
d32511c72c
Auto merge of #2054 - str4d:2030-decoderawtransaction-joinsplit-fields, r=bitcartel
...
Show all JoinSplit components in getrawtransaction and decoderawtransaction
Closes #2030 .
2017-02-09 22:56:01 +00:00
Simon
91270dcfbc
Update test to check for more joinsplit related fields in getrawtransaction
2017-02-09 14:48:58 -08:00
Jack Grigg
b8eb37757b
Require -experimentalmode for wallet encryption
2017-02-09 22:10:58 +00:00
zkbot
253c610783
Auto merge of #2050 - str4d:2020-zmq, r=bitcartel
...
Add ZeroMQ notifications
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6103
- bitcoin/bitcoin#6684
- bitcoin/bitcoin#6686
- bitcoin/bitcoin#6736
- bitcoin/bitcoin#6739
- bitcoin/bitcoin#6743
- bitcoin/bitcoin#6768
- bitcoin/bitcoin#6779
- bitcoin/bitcoin#6810
- bitcoin/bitcoin#6927
- bitcoin/bitcoin#6980 (only upgrading zeromq)
- bitcoin/bitcoin#6680
- bitcoin/bitcoin#7058
- bitcoin/bitcoin#7621
- bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`)
- bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`)
- bitcoin/bitcoin#7762
- bitcoin/bitcoin#7993 (only upgrading zeromq)
- bitcoin/bitcoin#8238
- bitcoin/bitcoin#8701
- bitcoin/bitcoin#6685
Closes #2020 .
2017-02-09 20:08:15 +00:00
zkbot
b2e2dccc64
Auto merge of #2068 - bitcartel:2045_sendmany_fee_zero, r=bitcartel
...
Closes #2045 by allowing z_sendmany with 0 fee
2017-02-09 18:56:44 +00:00
Jack Grigg
8db0dd93e4
Add test to check for presence of vpub_old & vpub_new in getrawtransaction
2017-02-09 16:38:01 +00:00
Jonas Schnelli
9bbc220641
fix rpc-tests.sh
...
`${testScripts[@]}` now does split up `testscript --agument` in two elements pushed to the array (`testscript` and `--agument`).
2017-02-09 11:53:51 +00:00
Simon
75bb764bb8
Add test for z_sendmany with fee of 0
2017-02-08 15:26:33 -08:00
Jonas Schnelli
3ba2e19e2b
[ZMQ] append a message sequence number to every ZMQ notification
2017-02-08 22:11:53 +00:00
Jack Grigg
c7cb3c13ea
[qa] py2: Unfiddle strings into bytes explicitly in ZMQ RPC test
...
Extracted from bitcoin/bitcoin#7853
commit faa41ee204124da19dcf1e5b8a3aef1e216bf5e6
2017-02-08 22:11:53 +00:00
Jack Grigg
a9445db62f
Fix python syntax in ZMQ RPC test
...
Extracted from bitcoin/bitcoin#7335
commit 7777994846cdb9b9cf69e391a33eeed30393bbcf
2017-02-08 22:11:53 +00:00
Cory Fields
5088de4bb8
travis: install a recent libzmq and pyzmq for tests
2017-02-08 22:10:42 +00:00
Jonas Schnelli
5c7f84cf26
[travis] add zmq python module
2017-02-08 22:10:42 +00:00
Jonas Schnelli
da0e7aa1d7
QA: Add ZeroMQ RPC test
2017-02-08 22:10:42 +00:00
Cory Fields
cce7754eb8
Depends: Add ZeroMQ package
2017-02-08 22:10:42 +00:00
Simon
aa0ab69a15
Closes #2024 by documenting and testing method field in z_getoperationstatus
2017-02-06 14:53:56 -08:00
Simon
a45d2ec79c
Update test to verify order of zrpcunsafe log messages
2017-02-01 14:41:35 -08:00
Simon
a1477f6fac
Add test to verify z_sendmany logging
2017-02-01 11:02:03 -08:00
zkbot
0edb3c0f16
Auto merge of #1978 - str4d:1941-scan-whole-chain-on-zkey-import, r=ebfull
...
Scan the whole chain whenever a z-key is imported
Closes #1941 .
2017-01-20 00:02:12 +00:00
Sean Bowe
620c0e2845
Add test for z_importkey rescanning from beginning of chain.
2017-01-19 16:59:29 -07:00
zkbot
78674ca79e
Auto merge of #2007 - bitcartel:1097_copyright_notice_and_date, r=bitcartel
...
Closes #1097 so that zcash-cli displays license info like zcashd.
LicenseInfo is refactored from init.cpp to util.cpp so that the
bitcoin-cli makefile target does not need to be modified.
2017-01-19 00:56:47 +00:00
Simon
774489569a
Increase timeout for z_sendmany transaction in wallet.py qa test
2017-01-18 16:54:39 -08:00
zkbot
63e0e895a5
Auto merge of #2006 - bitcartel:1497_destination_path_validation_when_exporting, r=bitcartel
...
Fixes #1497 ZCA-009 by restricting export to a user defined folder and sanitizing filenames
2017-01-18 18:19:50 +00:00
Simon
bab89e35c7
Update walletbackup.py qa test to use -exportdir option
2017-01-18 10:05:49 -08:00
Jack Grigg
9847bc870d
Create empty zcash.conf during coverage checks
...
Fixes regression caused by #2013 .
2017-01-18 12:11:50 +01:00
zkbot
ee2f1ebb9d
Auto merge of #1942 - str4d:1940-threaded-createjoinsplit, r=ebfull
...
Extend createjoinsplit to benchmark parallel JoinSplits
Closes #1940
2017-01-18 01:04:05 +00:00
zkbot
4169cddd64
Auto merge of #1991 - bitcartel:1960_z_getoperation_include_call_details, r=ebfull
...
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-17 19:24:07 +00:00
Jack Grigg
336fa63020
Create empty zcash.conf during performance measurements
2017-01-17 13:19:49 +01:00
Simon
8aa7937d44
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-16 16:45:27 -08:00
Jack Grigg
4082dcb10f
Extend createjoinsplit to benchmark parallel JoinSplits
...
Closes #1940
2016-12-14 15:28:00 +13:00
zkbot
02bb4df58d
Auto merge of #1918 - bitcartel:timeout_cpu_throttling, r=str4d
...
Increase timeout as laptops on battery power have cpu throttling.
Merge this last as other PRs also update the test file `wallet_protectcoinbase.py`.
2016-12-09 09:03:37 +00:00
zkbot
0617e428e2
Auto merge of #1895 - bitcartel:1857_tx_priority, r=str4d
...
Closes #1857 . Fixes bug where a transaction sending from a zaddr would have a priority of zero.
Transactions sent from a zaddr should now be mined sooner as they no longer have a priority of zero
2016-12-09 08:10:21 +00:00
zkbot
8a6c070bfa
Auto merge of #1870 - str4d:1749-benchmark-rescanning, r=str4d
...
Add benchmarks for rescan components
Part of #1749 .
2016-12-09 07:12:22 +00:00
Jack Grigg
88b7f3c28b
Generate JS for trydecryptnotes, make number of addresses a variable
2016-12-09 16:59:39 +13:00
zkbot
e68e26c208
Auto merge of #1911 - bitcartel:1823_witness_does_not_have_same_anchor_as_change_input, r=str4d
...
With chained joinsplits, witness anchors for input notes no longer cross block boundaries
Closes #1823
2016-12-08 01:23:40 +00:00
Simon
f3c4919027
Increase timeout as laptops on battery power have cpu throttling.
2016-12-05 10:46:12 -08:00
Simon
2d931e905b
Fixes #1823 . Witness anchors for input notes no longer cross block boundaries.
2016-12-03 00:22:42 -08:00
Simon
af53da0225
Closes #1903 . Add fee parameter to z_sendmany.
2016-11-30 14:23:35 -08:00
Simon
520ced1405
Closes #1857 . Fixes bug where tx spending only notes had priority of 0.
2016-11-28 22:54:49 -08:00
Jack Grigg
0bb3d40f90
Add benchmark for incrementing note witnesses
2016-11-17 22:26:46 +13:00
Jack Grigg
0fbab55b1b
Add benchmark for attempting decryption of notes
2016-11-17 19:09:45 +13:00
Simon
0afd3687c8
Closes #1854 . z_sendmany selects more utxos to avoid dust change output.
2016-11-15 17:12:37 -08:00
Simon
9ddb6ad028
Mempool will accept tx with joinsplits and the default z_sendmany fee.
...
Issue #1851 shows that a zaddr->taddr can be rejected from mempools
due to not meeting fee requirements given the size of the transaction.
Fee calculation for joinsplit txs has not yet been agreed upon, so
during this interim period, this patch ensures joinsplit txs using
the default fee are not rejected due to an insufficient fee.
2016-11-15 11:32:59 -08:00
zkbot
4e72614fb0
Auto merge of #1847 - bitcartel:1680_rpckeepalive_deadlock, r=ebfull
...
Closes #1680 , temporary fix for rpc deadlock inherited from upstream.
2016-11-15 10:25:24 +00:00
Simon
f4404d7b5b
Closes #1680 , temporary fix for rpc deadlock inherited from upstream.
2016-11-15 00:31:24 -08:00
Simon
9384e74c50
Closes #1833 . Format currency amounts in z_sendmany error message.
...
Improve coverage of possible error states from z_sendmany.
Refactor qa test for z_sendmany operations.
2016-11-10 16:57:36 -08:00
Simon
3920292b43
Add transaction size and zaddr output limit checks to z_sendmany.
2016-11-07 09:29:56 -08:00
Simon
7c463780cf
Fixes #1779 so that sending to multiple zaddrs no longer fails.
...
Commit 2eeb6b randomized the order of input and output notes,
but this is now known to prevent the chaining of multiple joinsplits
in a single transaction. The root cause has yet to be determined.
This patch is a temporary fix and disables the shuffling of input
and output notes. It also adds a chained joinsplit test to the
python qa test suite.
2016-11-04 23:23:48 -07:00
Sean Bowe
52676958d1
Test that a pure joinsplit will mine if other transactions are in the mempool.
2016-11-02 14:25:07 -06:00
zkbot
489f1d38ee
Auto merge of #1629 - bitcartel:1616_wallet_disallow_coinbase_change, r=daira
...
Add z_sendmany rule that when coinbase utxos must be spent in their entirety, with no change
See #1616 - coinbase utxos must be consumed entirely, without any change, since there
is currently no way to specify a change address in z_sendmany.
2016-10-25 15:40:36 -04:00
Simon
db026807b8
Add z_sendmany rule that when sending coinbase utxos to a zaddr
...
they must be consumed entirely, without any change, since there
is currently no way to specify a change address in z_sendmany.
2016-10-24 21:34:16 -07:00
Jack Grigg
dfe29d5988
Disable metrics screen in performance-measurements.sh
2016-10-23 20:41:18 -05:00
zkbot
a294b26db7
Auto merge of #1375 - str4d:1331-node-metrics, r=daira
...
Add node metrics screen
Continuation of #1336
Closes #1331
2016-10-22 20:21:11 -04:00
Daira Hopwood
02a4ace02c
Disable metrics screen in RPC tests
...
Author: Jack Grigg <jack@z.cash>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-23 01:05:57 +01:00
zkbot
026c3f784f
Auto merge of #1602 - str4d:1424-minimal-getblocktemplate, r=daira
...
Minimal modifications to getblocktemplate
A simpler alternative to #1435 that ensures Zcash GBT will remain compatible with BIP 22.
Closes #1424
2016-10-22 16:40:59 -04:00
Jack Grigg
bc54cf06cc
Fix RPC test
2016-10-22 15:36:38 -05:00
Jack Grigg
07064ea2d1
GBT: Add RPC tests
2016-10-21 23:38:37 -05:00
Jack Grigg
1628efedaf
GBT: Correct block header in proposals RPC test
2016-10-21 23:36:35 -05:00
zkbot
48888b67c9
Auto merge of #1599 - daira:1597.fix-other-potential-race-conditions, r=daira
...
Fix other potential race conditions similar to ref #1597 in RPC tests.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 00:15:32 -04:00
zkbot
71043784dd
Auto merge of #1586 - bitcartel:z_sendmany_amount_too_strict, r=daira
...
Fix issue where z_sendmany amount parameter is too strict
Upstream treats an amount parameter of `1` the same as `1.0`. Third-party would like this fixed.
2016-10-21 22:10:41 -04:00
zkbot
10ad093bbb
Auto merge of #1567 - str4d:rename-binaries, r=daira
...
Rename binaries
This ensures that our installs don't clash with existing Bitcoin binaries and libraries.
Closes #1563 and #1565
2016-10-21 20:48:11 -04:00
Daira Hopwood
deba66ca55
Fix other potential race conditions similar to ref #1597 in RPC tests.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-22 00:37:14 +01:00
Daira Hopwood
f0f838f081
Fix race condition in rpc-tests/wallet_protectcoinbase.py. closes #1597
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-21 17:20:36 +01:00
Daira Hopwood
5d985da5c1
Repair check-security-hardening.sh.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-21 02:34:13 +01:00
Simon
5eed758493
Update test to use integer amount as well as decimal amount when calling z_sendmany
2016-10-20 17:10:25 -07:00
Jack Grigg
2b499f4386
Fix RPC tests that require wallet encryption
2016-10-20 14:35:41 -05:00
zkbot
ec8dc3a88a
Auto merge of #1431 - bitcartel:master_1373_taddr_coinbase_error, r=bitcartel
...
Return a more informative error message when trying to spend coinbase; select non-coinbase inputs when sending to a transparent output if needed
For #1373 and #1519
Code change:
- Extra parameter added to AvailableCoins to include or exclude Coinbase coins. Default value of parameter is 'true' as current behaviour is to include Coinbase coins.
- SelectCoins, used for sending taddr->taddr, will now exclude Coinbase coins.
Unit test:
Tried to write a test to focus on the extra parameter added to AvailableCoins but could not.
Empirical testing on Testnet:
Current behaviour is that upstream RPC commands sendfrom and sendtoaddress try to spend coinbase coins returned by AvailableCoins. So the user will see:
```
./zcash-cli sendtoaddress mrEGRmGJhmwAa4MQjzGd86ry63vrvovu9b 1000.0
error: {"code":-6,"message":"Insufficient funds"}
./zcash-cli sendtoaddress mrEGRmGJhmwAa4MQjzGd86ry63vrvovu9b 0.00003000
error: {"code":-4,"message":"Error: The transaction was rejected! This might happen if some of the coins in your wallet were already spent, such as if you used a copy of wallet.dat and coins were spent in the copy but not marked as spent here."}
./zcash-cli sendfrom "" mrEGRmGJhmwAa4MQjzGd86ry63vrvovu9b 0.00003000
error: {"code":-4,"message":"Error: The transaction was rejected! This might happen if some of the coins in your wallet were already spent, such as if you used a copy of wallet.dat and coins were spent in the copy but not marked as spent here."}
```
After fix is applied:
```
./zcash-cli sendtoaddress mrEGRmGJhmwAa4MQjzGd86ry63vrvovu9b 1000.0
error: {"code":-6,"message":"Insufficient funds"}
./zcash-cli sendtoaddress mrEGRmGJhmwAa4MQjzGd86ry63vrvovu9b 0.00003000
error: {"code":-4,"message":"Coinbase funds can only be sent to a zaddr"}
```
When non-coinbase UTXOs exist, they will now be selected and used:
```
./zcash-cli z_sendmany tnPJZHeVxegCg91utaquBRPEDBGjozfz9iLDHt7zvphFbZdspNgkTVLCGjDcadQBKNyUwKs8pNjDXuEZKrE1aNLpFwHgz4t '[{"address":"mx5fTRhLZwbYE7ZqhAPueZgQGSnwTbdvKU", "amount":0.01}]'
./zcash-cli sendtoaddress mrEGRmGJhmwAa4MQjzGd86ry63vrvovu9b 1000.0
error: {"code":-6,"message":"Insufficient funds"}
./zcash-cli sendtoaddress mrEGRmGJhmwAa4MQjzGd86ry63vrvovu9b 0.00003000
9818e543ac2f689d4ce8b52087607d73fecd771d45d316a1d9db092f0485aff2
./zcash-cli sendfrom "" mrEGRmGJhmwAa4MQjzGd86ry63vrvovu9b 0.00003000
899f2894823f51f15fc73b5e0871ac943edbe0ff88e1635f86906087b72caf30
```
2016-10-16 22:08:07 -04:00
Simon
2b1cda3b6a
Return improved error message when trying to spend Coinbase coins ( #1373 ).
...
Extra parameter added to AvailableCoins to include or exclude Coinbase coins.
SelectCoins, used for sending taddr->taddr, will exclude Coinbase coins.
Added qa rpc test and a runtime parameter -regtestprotectcoinbase to enforce
the coinbase->zaddr consensus rule in regtest mode.
2016-10-16 19:05:56 -07:00
Jack Grigg
ddea44a27e
Update comments
2016-10-14 17:16:09 -05:00
Jack Grigg
1a62587e9a
Delay caching of nullifiers when wallet is locked
...
Closes #1502
2016-10-14 17:16:09 -05:00
Jack Grigg
8f445ee774
Break the RPC test by encrypting the mirroring wallet
2016-10-14 17:14:13 -05:00
Jack Grigg
52fdce985f
Add RPC test showing correct handling of JS txns from blockchain
...
For unencrypted wallets, the wallet correctly tracks JoinSplits made for their
zkey in a different wallet.
2016-10-14 17:14:13 -05:00
zkbot
7dc49cbc6a
Auto merge of #1490 - str4d:1454-deprecate-accounts, r=bitcartel
...
Throw an RPC error for all accounts except the default
Closes #1454
2016-10-10 23:55:02 -04:00
Daira Hopwood
3040239e2a
Cosmetics in RPC tests.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-10 20:27:16 +01:00
Daira Hopwood
218ded68f3
Fix RPC tests to not rely on accounts.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-10 20:26:52 +01:00
Simon
f7cfb52d3c
Add vjoinsplit to JSON output of RPC call gettransaction
2016-10-06 19:53:46 -07:00
Daira Hopwood
db5dd18c16
Repair rpc-tests/signrawtransactions.py.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-04 23:04:19 +01:00
Jack Grigg
f92f004714
Fix zkey test
2016-10-04 11:05:57 -07:00
zkbot
4f49d32a28
Auto merge of #1427 - bitcartel:master_1345_getbalance, r=bitcartel
...
Fixes #1345 so that RPC getbalance star calculates balance of UTXOs correctly.
2016-10-04 01:20:12 -04:00
Simon
86cf60b5c8
Fixes #1345 so that UTXO debit and credits are computed correctly for a transaction.
2016-10-03 11:06:43 -07:00
Daira Hopwood
65b502aa98
Benchmark 50 iterations of solveequihash
...
Since the parameters changed in z8, the benchmark on speed.z.cash is showing misleading results due to variability. (The quartile and extrema bars will still show the variability with 50 runs, they just won't jump around as much between benchmark data points.)
2016-09-19 19:08:24 +01:00
Jack Grigg
5be6abbf84
Store the Equihash solution in minimal representation in the block header
...
The genesis blocks and miner tests have been regenerated, because changing the
block header serialisation format changes the block hash, and thus validity.
The Equihash solutions have been removed from the bloom test inputs for
simplicity (block validity is not checked there; only a valid serialisation is
necessary).
2016-08-16 16:02:39 +12:00
Jack Grigg
649be423f8
Fix previous commit
2016-08-06 02:03:08 +12:00
Jack Grigg
6609813753
Simplify optional parameters
2016-08-06 00:36:33 +12:00
Jack Grigg
f7478de67f
Add thread parameter to solveequihash benchmark
...
Closes #1147
2016-08-05 15:05:38 +12:00
zkbot
abd4c16ae9
Auto merge of #1064 - ThisIsNotOfficialCodeItsJustForks:t915-enable-security-hardening, r=bitcartel
...
Verify security hardening features are turned on
2016-08-03 23:57:05 +00:00
Taylor Hornby
88325d8abb
Add more commands to run unit tests under valgrind.
2016-07-28 14:43:36 -06:00
Taylor Hornby
56734f4b27
Pull in upstream's make check-security, based on upstream PR #6854 and #7424 .
2016-07-21 20:45:10 -06:00
Taylor Hornby
1327d1915a
Add tests for security hardening features
2016-07-21 20:45:07 -06:00
Taylor Hornby
effd7ca1d8
Add checksec.sh from http://www.trapkit.de/tools/checksec.html
2016-07-21 20:45:07 -06:00
Sean Bowe
1737627c4e
Introduce `zcsamplejoinsplit` for creating a raw joinsplit description, and use it to construct the joinsplit for the performance tests that verify joinsplits.
2016-07-19 15:49:11 -06:00
Sean Bowe
d36098f873
Rename `pour` in RPC tests.
2016-07-18 10:43:17 -06:00
Sean Bowe
22de160219
Fixes for indentation and local variable names.
2016-07-18 10:07:29 -06:00
Sean Bowe
fd933ed05e
Fix tests
2016-07-18 10:06:18 -06:00
Sean Bowe
6e33353ea2
Rename pour RPC tests
2016-07-18 10:06:18 -06:00
Sean Bowe
ffcfe76d4f
Change encryptedbucket1 to encryptednote1.
2016-07-18 10:06:18 -06:00
Sean Bowe
b7e4abd6f7
Rename some usage of 'pour'.
2016-07-18 10:06:18 -06:00
zkbot
04932a64e8
Auto merge of #1080 - ebfull:performance-check-valid-pour, r=ebfull
...
Always check valid joinsplits during performance tests
This will generate a valid joinsplit instead of using one from an environment variable.
2016-07-11 22:38:25 +00:00
zkbot
ecef582339
Auto merge of #1061 - ebfull:remove-libzerocash-completely, r=ebfull
...
Remove the rest of libzerocash.
Closes #510 .
2016-07-11 16:17:35 +00:00
Sean Bowe
92b73b0dbb
Remove zerocash tests from full-test-suite.
2016-07-11 10:05:55 -06:00
Sean Bowe
2fbbde597c
Always check valid joinsplits during performance tests, and avoid recomputing them every time we change the circuit.
2016-07-09 14:31:43 -06:00
Sean Bowe
9c45b501ad
Make `validatelargetx` test more accurate, reduce block size limit to 1MB for now.
2016-07-06 12:07:50 -06:00
Sean Bowe
2ba9641767
Fix performance test for block verification.
2016-07-05 07:55:35 -06:00
Jack Grigg
f5edc37f3f
Add performance tests for creating and validating a MAX_BLOCK_SIZE transaction
2016-06-21 13:48:04 +12:00
Jack Grigg
3985a40d1f
Change default ports
2016-06-17 00:21:58 +12:00
zkbot
fe97a405e3
Auto merge of #994 - ebfull:remove-redundant-constraints, r=ebfull
...
Final changes to the circuit
* Remove [redundant](https://github.com/scipr-lab/libsnark/issues/37 ) bitness constraints that I pointed out in #908 .
* The depth is increased from 20 to 29. I chose 29 because the QAP degree ends up being a power of two, which is probably going to be useful for the FFT in our MPC. (Closes #16 )
If we're happy with depth 29 (over 268 million possible joinsplits), this will probably be the final change to the constraint system before 1.0.
2016-06-15 21:39:32 +00:00
zkbot
47e6645005
Auto merge of #1009 - ThisIsNotOfficialCodeItsJustForks:t171-hard-fork-alerts-and-tests, r=ebfull
...
Enable -alertnotify for hard fork detection. Test it.
Closes #171 . Closes #131 .
2016-06-12 18:04:53 +00:00
Jack Grigg
3fe29eab90
Fix failing tests
2016-06-10 16:16:33 +12:00
Jack Grigg
196cf25d5b
Update RPC tests to account for decreased block interval
2016-06-10 12:02:49 +12:00
Taylor Hornby
57c074e1e4
Enable -alertnotify for hard fork detection. Test it.
2016-06-09 13:48:04 -06:00
Jack Grigg
9378a04f1b
Update RPC tests to account for reserved field
2016-06-07 22:45:41 +12:00
Sean Bowe
1744fec274
Update the zkSNARK parameters.
2016-06-03 21:04:07 -06:00
Sean Bowe
3960e14d91
Update performance measurement transaction.
2016-05-31 13:17:55 -06:00
Taylor Hornby
fc8c101acf
Enable -v for valgrind so we can see counts for each error.
2016-05-25 16:42:39 -06:00
Taylor Hornby
0af5e31282
Pass -DPURIFY to OpenSSL so it doesn't clutter valgrind output.
2016-05-25 16:42:39 -06:00
Taylor Hornby
d578de8e27
Add ability to run things under valgrind.
2016-05-25 16:42:36 -06:00
Sean Bowe
6b5d608899
Update proving key and tests that depend on transaction structure changes
2016-05-24 11:09:17 -06:00
Sean Bowe
3e0af61b86
Update zkSNARK proving/verifying keys.
2016-05-12 16:45:12 -06:00
Sean Bowe
0cdfab1d92
Remove the zerocash tests from the full test suite.
2016-05-12 16:44:49 -06:00
Sean Bowe
ddb03c3e8d
Fix performance measurements due to modified transaction structure.
2016-05-12 16:44:49 -06:00
zkbot
c9a2eea5e2
Auto merge of #905 - ebfull:test-suite-fixes, r=ebfull
...
Run `zcash-gtest` in `make check` and fix performance tests.
* gtest tests weren't being run by make check
* performance tests were broken
* We need to automatically upload graphs of performance, [see this PR](https://github.com/Electric-Coin-Company/bbotzc/pull/15 ).
* Moves zerocash tests into `zcash`'s full test suite, we're removing them anyway later and it'd be nice to remove them in the PR instead of from buildbot
2016-05-05 23:29:34 +00:00
zkbot
87485d5ff3
Auto merge of #907 - DoNotUseThisCodeJUSTFORKS:t844-rename-bitcoin-conf, r=defuse
...
Rename bitcoin.conf and bitcoind.pid
This leaves the mentions of those files in `doc/` and `contrib/` unchanged.
**FORCE PUSHED**
2016-05-04 00:55:10 +00:00
Taylor Hornby
aaf6495948
Rename bitcoin.conf and bitcoind.pid to zcash.conf and zcashd.pid in qa/ and src/
2016-05-03 14:01:01 -06:00
Sean Bowe
956dcdde80
Perform zerocash tests as part of full-test-suite, in preparation for removal of zerocash waterfall.
2016-05-03 06:49:15 -06:00
Sean Bowe
6bd8e46922
Run `zcash-gtest` in `make check` and fix performance tests.
2016-05-02 23:14:53 -06:00
Sean Bowe
1760b3cd88
Deprecate the old tree and remove old tree tests from the test suite.
2016-04-28 16:07:52 -06:00
Taylor Hornby
b2cf9ba300
Fix RPC tests
2016-04-28 13:35:47 -06:00
zkbot
f2e157ab25
Auto merge of #846 - DoNotUseThisCodeJUSTFORKS:automated-performance-measurement-zcash-cli-method, r=ebfull
...
Automated performance measurement
Supersedes #843 because that one would have merged into the wrong branch. (Oh yeah and I rebased).
**REBASED AND FORCE PUSHED**
2016-04-11 21:56:12 +00:00
Sean Bowe
6ca317e1cc
Fix remaining RPC tests.
2016-04-11 12:46:46 -06:00
Taylor Hornby
36b1269bc3
Make benchmark specified by command-line arguments
2016-04-11 10:54:55 -06:00
Taylor Hornby
51c8c56b4a
Use a separate datadir for the benchmarks
2016-04-11 10:20:42 -06:00
Taylor Hornby
a0be8e262a
Don't leave massif.out lying around after the benchmarks
2016-04-11 10:05:16 -06:00
Taylor Hornby
a1cd1a27ac
Add verify equihash benchmark
2016-04-11 10:03:31 -06:00
Taylor Hornby
d44feea44c
Add JoinSplit verification benchmarks
2016-04-11 10:03:17 -06:00
Taylor Hornby
bf8def9749
Add equihash solving benchmarks
2016-04-11 10:02:59 -06:00
Taylor Hornby
6962bb3df0
Add automated performance measurement system.
2016-04-11 08:15:25 -06:00
Nathan Wilcox
ad56edf7d4
Fix (most) rpc tests by updating balances. zcpour, zcpourdoublespend, and txn_doublespend currently fail.
2016-04-08 18:05:51 -07:00
Nathan Wilcox
349a7b3714
Apply a patch from Sean to update wallet to use our new founders-reward aware balances.
2016-04-08 16:27:27 -07:00
Nathan Wilcox
4259e1e3dd
Log all failing rpc tests concisely.
2016-04-08 14:50:52 -07:00
Sean Bowe
abc1c352c9
Add missing synchronization that causes race condition in test.
2016-04-08 13:54:44 -06:00
Jack Grigg
cf00c47d5b
Fix tests that depend on old block header format
...
Changes to bloom tests were done by running the following commands:
sed -i 's/\(CDataStream stream(ParseHex(".\{152\}\)\(.\{8\}\)/\100000000000000000000000000000000000000000000000000000000\200/' src/test/bloom_tests.cpp
sed -i 's/\(vector<unsigned char> vch = ParseHex(".\{152\}\)\(.\{8\}\)/\100000000000000000000000000000000000000000000000000000000\200/' src/test/bloom_tests.cpp
and then reverting the single change to the transaction line.
2016-04-08 14:50:56 +12:00
Nathan Wilcox
bb9f19b487
Run all RPC tests, even when they fail.
2016-04-07 17:13:29 -07:00
Taylor Hornby
3af297cc57
Remove unnecessary comment.
2016-03-03 16:02:35 -07:00
Sean Bowe
25f0e1072e
Fix test paths.
2016-02-17 14:54:48 -07:00
Sean Bowe
0b43e787e0
Add merkleTest and utilTest to test suite.
2016-02-17 13:35:40 -07:00
Taylor Hornby
dba05929e7
Fix broken build because of zerocash->zcash rename.
2016-02-03 13:57:34 -07:00
ebfull
0294f34d15
Merge pull request #698 from Electric-Coin-Company/fix-pour-rpc-tests
...
Fixed RPC tests for Pours.
2016-02-03 13:07:53 -07:00
Taylor Hornby
21328e97cd
Fix bad merge due to qa/zerocash->qa/zcash rename.
2016-02-03 13:04:23 -07:00
Taylor Hornby
1ffb5eb04f
Rename qa/zerocash to qa/zcash.
2016-02-03 12:55:02 -07:00
Taylor Hornby
eed49655f3
Add documentation to test-depends-sources-mirror.py
2016-02-03 12:53:20 -07:00
Sean Bowe
a5cbd56a3a
Fixed RPC tests for Pours.
2016-01-29 19:40:05 -07:00
Taylor Hornby
ba083f083c
Add a test for our depends-sources mirror.
2016-01-28 20:18:52 -07:00
Sean Bowe
d66877afb3
Added mapSerials consensus rules to prohibit double-spending.
2016-01-19 14:36:09 -07:00