From 40df80ef25dcd1012fd38ec1fa0faaff6b229145 Mon Sep 17 00:00:00 2001 From: Francisco Gindre Date: Mon, 15 Aug 2022 13:03:03 -0700 Subject: [PATCH] [#455] revert queue priority downgrade changes from [#435] (#456) Closes #455 this reverts queue priority changes from commit `a5d0e447748257d2af5c9101391dd05a5ce929a2` since we detected it might prevent downloads to be scheduled in a timely fashion Co-authored-by: pacu --- .../Block/DatabaseStorage/CompactBlockStorage.swift | 6 +++--- .../Block/Processor/CompactBlockProcessor.swift | 2 +- Sources/ZcashLightClientKit/DAO/PagedTransactionDao.swift | 2 +- .../Transaction/PersistentTransactionManager.swift | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Sources/ZcashLightClientKit/Block/DatabaseStorage/CompactBlockStorage.swift b/Sources/ZcashLightClientKit/Block/DatabaseStorage/CompactBlockStorage.swift index 5a9ccd9b..9a2166a9 100644 --- a/Sources/ZcashLightClientKit/Block/DatabaseStorage/CompactBlockStorage.swift +++ b/Sources/ZcashLightClientKit/Block/DatabaseStorage/CompactBlockStorage.swift @@ -86,7 +86,7 @@ extension CompactBlockStorage: CompactBlockRepository { } func latestHeight(result: @escaping (Swift.Result) -> Void) { - DispatchQueue.global(qos: .default).async { + DispatchQueue.global(qos: .userInitiated).async { do { result(.success(try self.latestBlockHeight())) } catch { @@ -100,7 +100,7 @@ extension CompactBlockStorage: CompactBlockRepository { } func write(blocks: [ZcashCompactBlock], completion: ((Error?) -> Void)?) { - DispatchQueue.global(qos: .default).async { + DispatchQueue.global(qos: .userInitiated).async { do { try self.insert(blocks) completion?(nil) @@ -111,7 +111,7 @@ extension CompactBlockStorage: CompactBlockRepository { } func rewind(to height: BlockHeight, completion: ((Error?) -> Void)?) { - DispatchQueue.global(qos: .default).async { + DispatchQueue.global(qos: .userInitiated).async { do { try self.rewind(to: height) completion?(nil) diff --git a/Sources/ZcashLightClientKit/Block/Processor/CompactBlockProcessor.swift b/Sources/ZcashLightClientKit/Block/Processor/CompactBlockProcessor.swift index 04392989..acea0ba8 100644 --- a/Sources/ZcashLightClientKit/Block/Processor/CompactBlockProcessor.swift +++ b/Sources/ZcashLightClientKit/Block/Processor/CompactBlockProcessor.swift @@ -1397,7 +1397,7 @@ extension CompactBlockProcessor { queue: DispatchQueue?, result: @escaping (Result) -> Void ) { - let dispatchQueue = queue ?? DispatchQueue.global(qos: .default) + let dispatchQueue = queue ?? DispatchQueue.global(qos: .userInitiated) dispatchQueue.async { do { diff --git a/Sources/ZcashLightClientKit/DAO/PagedTransactionDao.swift b/Sources/ZcashLightClientKit/DAO/PagedTransactionDao.swift index e6655605..a7215722 100644 --- a/Sources/ZcashLightClientKit/DAO/PagedTransactionDao.swift +++ b/Sources/ZcashLightClientKit/DAO/PagedTransactionDao.swift @@ -50,7 +50,7 @@ class PagedTransactionDAO: PaginatedTransactionRepository { } func page(_ number: Int, result: @escaping (Result<[TransactionEntity]?, Error>) -> Void) { - DispatchQueue.global(qos: .default).async { [weak self] in + DispatchQueue.global(qos: .userInitiated).async { [weak self] in guard let self = self else { return } do { result(.success(try self.page(number))) diff --git a/Sources/ZcashLightClientKit/Transaction/PersistentTransactionManager.swift b/Sources/ZcashLightClientKit/Transaction/PersistentTransactionManager.swift index c5d81d6d..c93db928 100644 --- a/Sources/ZcashLightClientKit/Transaction/PersistentTransactionManager.swift +++ b/Sources/ZcashLightClientKit/Transaction/PersistentTransactionManager.swift @@ -35,7 +35,7 @@ class PersistentTransactionManager: OutboundTransactionManager { self.encoder = encoder self.service = service self.network = networkType - self.queue = DispatchQueue.init(label: "PersistentTransactionManager.serial.queue", qos: .default) + self.queue = DispatchQueue.init(label: "PersistentTransactionManager.serial.queue", qos: .userInitiated) } func initSpend(