[#1129] Final check of all State Machine Action tests

- XTCAsset messages checked
- test naming checked and fixed

Tests/OfflineTests/CompactBlockProcessorActions/ClearAlreadyScannedBlocksActionTests.swift

@@ -34,7 +34,7 @@ final class ClearAlreadyScannedBlocksActionTests: ZcashTestCase {
                 "nextContext after .clearAlreadyScannedBlocks is expected to be .enhance but received \(nextState)"
             )
         } catch {
-            XCTFail("testClearAlreadyScannedBlocksActionTests_NextAction is not expected to fail. \(error)")
+            XCTFail("testClearAlreadyScannedBlocksAction_NextAction is not expected to fail. \(error)")
         }
     }
 }

Tests/OfflineTests/CompactBlockProcessorActions/ClearCacheActionTests.swift

@@ -30,7 +30,7 @@ final class ClearCacheActionTests: ZcashTestCase {
                 "nextContext after .clearCache is expected to be .finished but received \(nextState)"
             )
         } catch {
-            XCTFail("testClearCacheActionTests_NextAction is not expected to fail. \(error)")
+            XCTFail("testClearCacheAction_NextAction is not expected to fail. \(error)")
         }
     }
 }

Tests/OfflineTests/CompactBlockProcessorActions/DownloadActionTests.swift

@@ -125,7 +125,7 @@ final class DownloadActionTests: ZcashTestCase {
                 "nextContext after .download is expected to be .validate but received \(nextState)"
             )
         } catch {
-            XCTFail("testDownloadAction_NoDownloadAndScanRange is not expected to fail. \(error)")
+            XCTFail("testDownloadAction_NothingMoreToDownload is not expected to fail. \(error)")
         }
     }
     

Tests/OfflineTests/CompactBlockProcessorActions/MigrateLegacyCacheDBActionTests.swift

@@ -230,7 +230,7 @@ final class MigrateLegacyCacheDBActionTests: ZcashTestCase {
                 "nextContext after .migrateLegacyCacheDB is expected to be .validateServer but received \(nextState)"
             )
         } catch {
-            XCTFail("testMigrateLegacyCacheDBAction_aliasDoesntMatchDefault is not expected to fail. \(error)")
+            XCTFail("testMigrateLegacyCacheDBAction_nextAction is not expected to fail. \(error)")
         }
     }
 

Tests/OfflineTests/CompactBlockProcessorActions/ScanActionTests.swift

@@ -62,7 +62,7 @@ final class ScanActionTests: ZcashTestCase {
             XCTAssertFalse(loggerMock.debugFileFunctionLineCalled, "logger.debug(...) is not expected to be called.")
             XCTAssertFalse(blockScannerMock.scanBlocksAtTotalProgressRangeDidScanCalled, "blockScanner.scanBlocks(...) is not expected to be called.")
         } catch {
-            XCTFail("testScanAction_NextAction is not expected to fail. \(error)")
+            XCTFail("testScanAction_EarlyOutForNoDownloadAndScanRangeSet is not expected to fail. \(error)")
         }
     }
     
@@ -82,7 +82,7 @@ final class ScanActionTests: ZcashTestCase {
             XCTAssertFalse(loggerMock.debugFileFunctionLineCalled, "logger.debug(...) is not expected to be called.")
             XCTAssertFalse(blockScannerMock.scanBlocksAtTotalProgressRangeDidScanCalled, "blockScanner.scanBlocks(...) is not expected to be called.")
         } catch {
-            XCTFail("testScanAction_NextAction is not expected to fail. \(error)")
+            XCTFail("testScanAction_StartRangeHigherThanEndRange is not expected to fail. \(error)")
         }
     }