From 1a52d8f6b8cb64543ff560d8019a396387ba5f24 Mon Sep 17 00:00:00 2001
From: therealyingtong <yingtong@electriccoin.co>
Date: Sun, 13 Sep 2020 11:39:35 +0800
Subject: [PATCH] Add MSM to PLONK verifier signature

---
 src/plonk.rs          | 3 ++-
 src/plonk/verifier.rs | 8 ++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/plonk.rs b/src/plonk.rs
index b0dc869d..b7c01200 100644
--- a/src/plonk.rs
+++ b/src/plonk.rs
@@ -345,6 +345,7 @@ fn test_proving() {
         let proof = Proof::create::<DummyHash<Fq>, DummyHash<Fp>, _>(&params, &srs, &circuit)
             .expect("proof generation should not fail");
 
-        assert!(proof.verify::<DummyHash<Fq>, DummyHash<Fp>>(&params, &srs));
+        let msm_default = params.msm();
+        assert!(proof.verify::<DummyHash<Fq>, DummyHash<Fp>>(&params, &srs, msm_default));
     }
 }
diff --git a/src/plonk/verifier.rs b/src/plonk/verifier.rs
index fe390c80..7ba9103c 100644
--- a/src/plonk/verifier.rs
+++ b/src/plonk/verifier.rs
@@ -12,6 +12,7 @@ impl<C: CurveAffine> Proof<C> {
         &self,
         params: &Params<C>,
         srs: &SRS<C>,
+        msm: MSM<C>,
     ) -> bool {
         // Create a transcript for obtaining Fiat-Shamir challenges.
         let mut transcript = HBase::init(C::Base::one());
@@ -264,12 +265,11 @@ impl<C: CurveAffine> Proof<C> {
         }
 
         // Verify the opening proof
-        let default_msm = params.msm();
         let guard = self
             .opening
             .verify(
                 params,
-                default_msm,
+                msm,
                 &mut transcript,
                 x_6,
                 &f_commitment.to_affine(),
@@ -277,8 +277,8 @@ impl<C: CurveAffine> Proof<C> {
             )
             .unwrap();
 
-        let msm: &MSM<C> = &guard.use_challenges();
+        let msm_challenges = guard.use_challenges();
 
-        msm.is_zero()
+        msm_challenges.is_zero()
     }
 }