Merge pull request #269 from zcash/ci-fixes

CI fixes

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: stable
+          toolchain: 1.49.0
           override: true
       - name: Run tests
         uses: actions-rs/cargo@v1
@@ -37,7 +37,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: stable
+          toolchain: 1.49.0
           override: true
       - name: Add target
         run: rustup target add ${{ matrix.target }}
@@ -55,7 +55,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: stable
+          toolchain: 1.49.0
           override: true
       # Build benchmarks to prevent bitrot
       - name: Build benchmarks
@@ -71,7 +71,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: stable
+          toolchain: 1.49.0
           override: true
       - name: cargo build
         uses: actions-rs/cargo@v1
@@ -141,7 +141,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: stable
+          toolchain: 1.49.0
           override: true
       - run: rustup component add rustfmt
       - uses: actions-rs/cargo@v1

.github/workflows/lints-stable.yml

@@ -5,7 +5,7 @@ on: pull_request
 
 jobs:
   clippy:
-    name: Clippy (stable)
+    name: Clippy (1.49.0)
     timeout-minutes: 30
     runs-on: ubuntu-latest
 
@@ -13,12 +13,12 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: stable
+          toolchain: 1.49.0
           components: clippy
           override: true
       - name: Run clippy
         uses: actions-rs/clippy-check@v1
         with:
-          name: Clippy (stable)
+          name: Clippy (1.49.0)
           token: ${{ secrets.GITHUB_TOKEN }}
           args: --all-features --all-targets -- -D warnings

book/src/user/dev-tools.md

@@ -42,7 +42,7 @@ chips that it uses.
 The `cost-model` binary takes high-level parameters for a circuit design, and estimates
 the verification cost, as well as resulting proof size.
 
-```
+```plaintext
 Usage: cargo run --example cost-model -- [OPTIONS] k
 
 Positional arguments:

src/lib.rs

@@ -1,7 +1,13 @@
 //! # halo2
 
 #![cfg_attr(docsrs, feature(doc_cfg))]
+// Build without warnings on stable 1.51 and later.
 #![allow(unknown_lints)]
+// Disable old lint warnings until our MSRV is at least 1.51.
+#![allow(renamed_and_removed_lints)]
+// Use the old lint name to build without warnings until our MSRV is at least 1.51.
+#![allow(clippy::unknown_clippy_lints)]
+// The actual lints we want to disable.
 #![allow(
     clippy::op_ref,
     clippy::assign_op_pattern,
@@ -9,8 +15,7 @@
     clippy::suspicious_arithmetic_impl,
     clippy::many_single_char_names,
     clippy::same_item_push,
-    clippy::upper_case_acronyms,
-    clippy::unknown_clippy_lints
+    clippy::upper_case_acronyms
 )]
 #![deny(broken_intra_doc_links)]
 #![deny(missing_debug_implementations)]