From 3c8befa0f3ab346138c72a90d448b61fddb6ab8d Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Tue, 16 Mar 2021 09:36:59 +1300 Subject: [PATCH] Remove TODO from extract_p The protocol spec now returns \mathbb{P}_x instead of a bit sequence, matching what we do here. --- src/spec.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/spec.rs b/src/spec.rs index 2b4222a5..36ce59d7 100644 --- a/src/spec.rs +++ b/src/spec.rs @@ -101,8 +101,6 @@ pub(crate) fn ka_orchard(sk: &pallas::Scalar, b: &pallas::Point) -> pallas::Poin /// /// [concreteextractorpallas]: https://zips.z.cash/protocol/nu5.pdf#concreteextractorpallas pub(crate) fn extract_p(point: &pallas::Point) -> pallas::Base { - // TODO: Should we return the actual bits in a Vec, or allow the caller to use - // PrimeField::to_le_bits on the returned pallas::Base? if let Some((x, _)) = point.to_affine().get_xy().into() { x } else {