zec
/
halo2
mirror of https://github.com/zcash/halo2.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Clarify a comment

This commit is contained in:
Daira Hopwood 2022-04-19 12:36:02 +01:00 committed by GitHub
parent b48b032041
commit 424a2748d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
halo2_proofs/src/dev.rs
View File

@ -917,11 +917,12 @@ impl<F: FieldExt> MockProver<F> {
assert!(lookup.table_expressions.len() == lookup.input_expressions.len()); assert!(lookup.table_expressions.len() == lookup.input_expressions.len());
assert!(self.usable_rows.end > 0); assert!(self.usable_rows.end > 0);
// We optimize on the basis that the last usable row might have been repeated to fill // We optimize on the basis that the table might have been filled so that the last
// the table (it doesn't matter if it wasn't). Note that this "fill row" necessarily // usable row now has the fill contents (it doesn't matter if there was no filling).
// exists in the table, and we use that fact to slightly simplify the optimization: // Note that this "fill row" necessarily exists in the table, and we use that fact to
// we're only trying to check that all input rows are contained in the table, and so // slightly simplify the optimization: we're only trying to check that all input rows
// we can safely just drop input rows that match the fill row. // are contained in the table, and so we can safely just drop input rows that
// match the fill row.
let fill_row: Vec<_> = lookup let fill_row: Vec<_> = lookup
.table_expressions .table_expressions
.iter() .iter()