From 6ffe61fd812e36d751635ee1867c4be8b44cfd5d Mon Sep 17 00:00:00 2001 From: str4d Date: Mon, 3 Jan 2022 17:00:47 +0000 Subject: [PATCH] Add some extra `Assigned` test cases Co-authored-by: Daira Hopwood --- src/plonk/assigned.rs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/plonk/assigned.rs b/src/plonk/assigned.rs index b546434b..8bb002e5 100644 --- a/src/plonk/assigned.rs +++ b/src/plonk/assigned.rs @@ -190,6 +190,7 @@ mod tests { // 2 + (1,0) = 2 + 0 = 2 // This fails if addition is implemented using normal rules for rationals. assert_eq!((a + b).evaluate(), a.evaluate()); + assert_eq!((b + a).evaluate(), a.evaluate()); } #[test] @@ -202,6 +203,7 @@ mod tests { // (1,2) + (1,0) = (1,2) + 0 = (1,2) // This fails if addition is implemented using normal rules for rationals. assert_eq!((a + b).evaluate(), a.evaluate()); + assert_eq!((b + a).evaluate(), a.evaluate()); } #[test] @@ -214,6 +216,9 @@ mod tests { // (1,0) - 2 = 0 - 2 = -2 // This fails if subtraction is implemented using normal rules for rationals. assert_eq!((b - a).evaluate(), (-a).evaluate()); + + // 2 - (1,0) = 2 - 0 = 2 + assert_eq!((a - b).evaluate(), a.evaluate()); } #[test] @@ -226,6 +231,9 @@ mod tests { // (1,0) - (1,2) = 0 - (1,2) = -(1,2) // This fails if subtraction is implemented using normal rules for rationals. assert_eq!((b - a).evaluate(), (-a).evaluate()); + + // (1,2) - (1,0) = (1,2) - 0 = (1,2) + assert_eq!((a - b).evaluate(), a.evaluate()); } #[test] @@ -237,6 +245,9 @@ mod tests { // (1,2) * (1,0) = (1,2) * 0 = 0 assert_eq!((a * b).evaluate(), Fp::zero()); + + // (1,0) * (1,2) = 0 * (1,2) = 0 + assert_eq!((b * a).evaluate(), Fp::zero()); } }