diff --git a/src/plonk/lookup.rs b/src/plonk/lookup.rs index 2618ec5c..ea312eed 100644 --- a/src/plonk/lookup.rs +++ b/src/plonk/lookup.rs @@ -36,7 +36,7 @@ impl Argument { // // Enable the permutation argument for only the rows involved. // degree (2 + input_degree + table_degree) or 4, whichever is larger: - // (1 - (l_last + l_blind)) * ( + // (1 - (l_last(X) + l_blind(X))) * ( // z(\omega X) (a'(X) + \beta) (s'(X) + \gamma) // - z(X) (\theta^{m-1} a_0(X) + ... + a_{m-1}(X) + \beta) (\theta^{m-1} s_0(X) + ... + s_{m-1}(X) + \gamma) // ) = 0 @@ -48,7 +48,7 @@ impl Argument { // Either the two values are the same, or the previous // value of a' is the same as the current value. // degree 3: - // (1 - (l_last + l_blind)) * (a′(X) − s′(X))⋅(a′(X) − a′(\omega^{-1} X)) = 0 + // (1 - (l_last(X) + l_blind(X))) * (a′(X) − s′(X))⋅(a′(X) − a′(\omega^{-1} X)) = 0 let mut input_degree = 1; for expr in self.input_expressions.iter() { input_degree = std::cmp::max(input_degree, expr.degree()); diff --git a/src/plonk/lookup/prover.rs b/src/plonk/lookup/prover.rs index eef9d5bc..d560c0a3 100644 --- a/src/plonk/lookup/prover.rs +++ b/src/plonk/lookup/prover.rs @@ -444,7 +444,7 @@ impl<'a, C: CurveAffine> Committed { (self.product_coset.clone() * &self.product_coset - &self.product_coset) * &pk.l_last, )) - // (1 - (l_last + l_blind)) * ( + // (1 - (l_last(X) + l_blind(X))) * ( // z(\omega X) (a'(X) + \beta) (s'(X) + \gamma) // - z(X) (\theta^{m-1} a_0(X) + ... + a_{m-1}(X) + \beta) (\theta^{m-1} s_0(X) + ... + s_{m-1}(X) + \gamma) // ) = 0 diff --git a/src/plonk/lookup/verifier.rs b/src/plonk/lookup/verifier.rs index de0de10d..c014577d 100644 --- a/src/plonk/lookup/verifier.rs +++ b/src/plonk/lookup/verifier.rs @@ -161,7 +161,7 @@ impl Evaluated { Some(l_last * &(self.product_eval.square() - &self.product_eval)), ) .chain( - // (1 - (l_last + l_blind)) * ( + // (1 - (l_last(X) + l_blind(X))) * ( // z(\omega X) (a'(X) + \beta) (s'(X) + \gamma) // - z(X) (\theta^{m-1} a_0(X) + ... + a_{m-1}(X) + \beta) (\theta^{m-1} s_0(X) + ... + s_{m-1}(X) + \gamma) // ) = 0 @@ -172,7 +172,7 @@ impl Evaluated { l_0 * &(self.permuted_input_eval - &self.permuted_table_eval), )) .chain(Some( - // (1 - (l_last + l_blind)) * (a′(X) − s′(X))⋅(a′(X) − a′(\omega^{-1} X)) = 0 + // (1 - (l_last(X) + l_blind(X))) * (a′(X) − s′(X))⋅(a′(X) − a′(\omega^{-1} X)) = 0 (self.permuted_input_eval - &self.permuted_table_eval) * &(self.permuted_input_eval - &self.permuted_input_inv_eval) * &active_rows, diff --git a/src/plonk/permutation.rs b/src/plonk/permutation.rs index 5677c119..31c2b6be 100644 --- a/src/plonk/permutation.rs +++ b/src/plonk/permutation.rs @@ -34,7 +34,7 @@ impl Argument { // following will not affect the required degree of // this middleware. // - // (1 - (l_last + l_blind)) * ( + // (1 - (l_last(X) + l_blind(X))) * ( // z(\omega X) \prod (p(X) + \beta s_i(X) + \gamma) // - z(X) \prod (p(X) + \delta^i \beta X + \gamma) // ) diff --git a/src/plonk/permutation/prover.rs b/src/plonk/permutation/prover.rs index 340179a3..6aa3dff5 100644 --- a/src/plonk/permutation/prover.rs +++ b/src/plonk/permutation/prover.rs @@ -259,7 +259,7 @@ impl Committed { .collect::>(), ) // And for all the sets we enforce: - // (1 - (l_last + l_blind)) * ( + // (1 - (l_last(X) + l_blind(X))) * ( // z_i(\omega X) \prod_j (p(X) + \beta s_j(X) + \gamma) // - z_i(X) \prod_j (p(X) + \delta^j \beta X + \gamma) // ) diff --git a/src/plonk/permutation/verifier.rs b/src/plonk/permutation/verifier.rs index 21e10ba6..a6aa88b0 100644 --- a/src/plonk/permutation/verifier.rs +++ b/src/plonk/permutation/verifier.rs @@ -146,7 +146,7 @@ impl Evaluated { .map(move |(set, prev_last)| (set - &prev_last) * &l_0), ) // And for all the sets we enforce: - // (1 - (l_last + l_blind)) * ( + // (1 - (l_last(X) + l_blind(X))) * ( // z_i(\omega X) \prod (p(X) + \beta s_i(X) + \gamma) // - z_i(X) \prod (p(X) + \delta^i \beta X + \gamma) // )