mirror of https://github.com/zcash/halo2.git
Apply suggestions from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
This commit is contained in:
parent
3c2e32e156
commit
7d243ae60a
|
@ -139,9 +139,9 @@ pub struct Bundle<T: Authorization> {
|
||||||
actions: NonEmpty<Action<T::SpendAuth>>,
|
actions: NonEmpty<Action<T::SpendAuth>>,
|
||||||
/// Orchard-specific transaction-level flags for this bundle.
|
/// Orchard-specific transaction-level flags for this bundle.
|
||||||
flags: Flags,
|
flags: Flags,
|
||||||
/// The net value moved into or out of the Orchard shielded pool.
|
/// The net value moved out of the Orchard shielded pool.
|
||||||
///
|
///
|
||||||
/// This is the sum of Orchard spends minus the sum Orchard outputs.
|
/// This is the sum of Orchard spends minus the sum of Orchard outputs.
|
||||||
value_balance: ValueSum,
|
value_balance: ValueSum,
|
||||||
/// The root of the Orchard commitment tree that this bundle commits to.
|
/// The root of the Orchard commitment tree that this bundle commits to.
|
||||||
anchor: Anchor,
|
anchor: Anchor,
|
||||||
|
@ -203,7 +203,7 @@ impl<T: Authorization> Bundle<T> {
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Transitions this bundle from one authorization state to another.
|
/// Transitions this bundle from one authorization state to another.
|
||||||
pub fn map<U: Authorization>(
|
pub fn authorize<U: Authorization>(
|
||||||
self,
|
self,
|
||||||
mut spend_auth: impl FnMut(&T, T::SpendAuth) -> U::SpendAuth,
|
mut spend_auth: impl FnMut(&T, T::SpendAuth) -> U::SpendAuth,
|
||||||
step: impl FnOnce(T) -> U,
|
step: impl FnOnce(T) -> U,
|
||||||
|
@ -221,7 +221,7 @@ impl<T: Authorization> Bundle<T> {
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Transitions this bundle from one authorization state to another.
|
/// Transitions this bundle from one authorization state to another.
|
||||||
pub fn try_map<U: Authorization, E>(
|
pub fn try_authorize<U: Authorization, E>(
|
||||||
self,
|
self,
|
||||||
mut spend_auth: impl FnMut(&T, T::SpendAuth) -> Result<U::SpendAuth, E>,
|
mut spend_auth: impl FnMut(&T, T::SpendAuth) -> Result<U::SpendAuth, E>,
|
||||||
step: impl FnOnce(T) -> Result<U, E>,
|
step: impl FnOnce(T) -> Result<U, E>,
|
||||||
|
|
Loading…
Reference in New Issue