mirror of https://github.com/zcash/halo2.git
Minor fixes.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
This commit is contained in:
parent
fa560d3aee
commit
8c8a12a8df
|
@ -87,7 +87,6 @@ pub trait EccInstructions<C: CurveAffine>: Chip<C::Base> + UtilitiesInstructions
|
|||
) -> Result<Self::Point, Error>;
|
||||
|
||||
/// Performs variable-base scalar multiplication, returning `[scalar] base`.
|
||||
/// Multiplication of the identity `[scalar] 𝒪 ` returns an error.
|
||||
fn mul(
|
||||
&self,
|
||||
layouter: &mut impl Layouter<C::Base>,
|
||||
|
|
|
@ -142,6 +142,10 @@ impl Config {
|
|||
|| "variable-base scalar mul",
|
||||
|mut region| {
|
||||
let offset = 0;
|
||||
|
||||
// Case `base` into an `EccPoint` for later use.
|
||||
let base_point: EccPoint = (*base).into();
|
||||
|
||||
// Decompose `k = alpha + t_q` bitwise (big-endian bit order).
|
||||
let bits = decompose_for_scalar_mul(alpha.value());
|
||||
|
||||
|
@ -151,12 +155,9 @@ impl Config {
|
|||
let lsb = bits[pallas::Scalar::NUM_BITS as usize - 1];
|
||||
|
||||
// Initialize the accumulator `acc = [2]base`
|
||||
let acc = self.add_config.assign_region(
|
||||
&(base.clone()).into(),
|
||||
&(base.clone()).into(),
|
||||
offset,
|
||||
&mut region,
|
||||
)?;
|
||||
let acc =
|
||||
self.add_config
|
||||
.assign_region(&base_point, &base_point, offset, &mut region)?;
|
||||
|
||||
// Increase the offset by 1 after complete addition.
|
||||
let offset = offset + 1;
|
||||
|
@ -210,7 +211,7 @@ impl Config {
|
|||
&mut region,
|
||||
offset,
|
||||
bits_complete,
|
||||
&(*base).into(),
|
||||
&base_point,
|
||||
x_a,
|
||||
y_a,
|
||||
*z,
|
||||
|
|
Loading…
Reference in New Issue