From bc9d05e67b0581c8f34d5450a45696d6f976ba48 Mon Sep 17 00:00:00 2001 From: ebfull Date: Wed, 17 Feb 2021 13:44:28 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: str4d --- src/plonk.rs | 4 ++-- src/plonk/circuit.rs | 2 +- src/poly/domain.rs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plonk.rs b/src/plonk.rs index c0adddab..c7c39a5d 100644 --- a/src/plonk.rs +++ b/src/plonk.rs @@ -92,7 +92,7 @@ impl VerifyingKey { // Hash in final Blake2bState transcript.common_scalar(C::Scalar::from_bytes_wide( - hasher.finalize().as_bytes().try_into().unwrap(), + hasher.finalize().as_array(), ))?; Ok(()) @@ -103,7 +103,7 @@ impl std::fmt::Display for VerifyingKey { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> { write!( f, - "VerificationKey {{\ + "VerificationKey {{ \ base_modulus = {base_modulus}, \ scalar_modulus = {scalar_modulus}, \ domain = {domain}, \ diff --git a/src/plonk/circuit.rs b/src/plonk/circuit.rs index 42464afb..3360c05b 100644 --- a/src/plonk/circuit.rs +++ b/src/plonk/circuit.rs @@ -384,7 +384,7 @@ impl std::fmt::Display for ConstraintSystem { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> { write!( f, - "ConstraintSystem {{\ + "ConstraintSystem {{ \ num_fixed_columns: {num_fixed_columns}, \ num_advice_columns: {num_advice_columns}, \ num_instance_columns: {num_instance_columns}, \ diff --git a/src/poly/domain.rs b/src/poly/domain.rs index c103e107..eb5ef9ea 100644 --- a/src/poly/domain.rs +++ b/src/poly/domain.rs @@ -381,7 +381,7 @@ impl std::fmt::Display for EvaluationDomain { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> { write!( f, - "Domain {{\ + "Domain {{ \ k = {k:?}, \ extended_k = {extended_k:?}, \ omega = {omega:?} \