zec
/
halo2
mirror of https://github.com/zcash/halo2.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: str4d <jack@electriccoin.co>
This commit is contained in:
Daira Hopwood 2021-09-28 21:09:39 +01:00 committed by GitHub
parent d0056d9050
commit d77cb82c8d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/circuit/gadget/ecc.rs
View File

@ -57,7 +57,8 @@ pub trait EccInstructions<C: CurveAffine>: Chip<C::Base> + UtilitiesInstructions
) -> Result<(), Error>; ) -> Result<(), Error>;
/// Witnesses the given point as a private input to the circuit. /// Witnesses the given point as a private input to the circuit.
/// This allows the point to be the identity. /// This allows the point to be the identity, mapped to (0, 0) in
/// affine coordinates.
fn witness_point( fn witness_point(
&self, &self,
layouter: &mut impl Layouter<C::Base>, layouter: &mut impl Layouter<C::Base>,

2
src/circuit/gadget/sinsemilla/note_commit.rs
View File

@ -1680,7 +1680,7 @@ mod tests {
.to_affine(); .to_affine();
NonIdentityPoint::new( NonIdentityPoint::new(
ecc_chip, ecc_chip,
layouter.namespace(|| "witness g_d"), layouter.namespace(|| "witness cm"),
Some(point), Some(point),
)? )?
}; };