From ddde5f200c9b7e34694148bcbc1ce6ece66297ba Mon Sep 17 00:00:00 2001 From: therealyingtong Date: Tue, 25 May 2021 00:55:34 +0800 Subject: [PATCH] Remove unused Challenge trait. --- benches/plonk.rs | 6 +++--- src/transcript.rs | 6 ------ 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/benches/plonk.rs b/benches/plonk.rs index 8af94dee..2b922031 100644 --- a/benches/plonk.rs +++ b/benches/plonk.rs @@ -256,7 +256,7 @@ fn bench_with_k(name: &str, k: u32, c: &mut Criterion) { }; // Create a proof - let mut transcript = Blake2bWrite::<_, _, Challenge255>::init(vec![]); + let mut transcript = Blake2bWrite::<_, _, Challenge255<_>>::init(vec![]); create_proof(¶ms, &pk, &[circuit], &[&[]], &mut transcript) .expect("proof generation should not fail") }); @@ -268,7 +268,7 @@ fn bench_with_k(name: &str, k: u32, c: &mut Criterion) { }; // Create a proof - let mut transcript = Blake2bWrite::<_, _, Challenge255>::init(vec![]); + let mut transcript = Blake2bWrite::<_, _, Challenge255<_>>::init(vec![]); create_proof(¶ms, &pk, &[circuit], &[&[]], &mut transcript) .expect("proof generation should not fail"); let proof = transcript.finalize(); @@ -276,7 +276,7 @@ fn bench_with_k(name: &str, k: u32, c: &mut Criterion) { c.bench_function(&verifier_name, |b| { b.iter(|| { let msm = params.empty_msm(); - let mut transcript = Blake2bRead::<_, _, Challenge255>::init(&proof[..]); + let mut transcript = Blake2bRead::<_, _, Challenge255<_>>::init(&proof[..]); let guard = verify_proof(¶ms, pk.get_vk(), msm, &[&[]], &mut transcript).unwrap(); let msm = guard.clone().use_challenges(); assert!(msm.eval()); diff --git a/src/transcript.rs b/src/transcript.rs index e7a4ff16..dde7091d 100644 --- a/src/transcript.rs +++ b/src/transcript.rs @@ -209,12 +209,6 @@ impl Transcript> } } -/// `Challenge` trait implemented for challenges of different lengths -pub trait Challenge: Copy + Clone + std::fmt::Debug { - /// Try to create challenge of appropriate length. - fn new(challenge: &[u8]) -> Self; -} - /// The scalar representation of a verifier challenge. /// /// The `Type` type can be used to scope the challenge to a specific context, or