From de024999a55d30b0f6a4ab7882e17da2ba813f58 Mon Sep 17 00:00:00 2001 From: Eduard S Date: Mon, 22 Jan 2024 13:26:58 +0000 Subject: [PATCH] Checkpoint --- common/src/plonk/circuit.rs | 9 ++++----- common/src/plonk/shuffle.rs | 8 -------- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/common/src/plonk/circuit.rs b/common/src/plonk/circuit.rs index 0b4fee82..fe5fd003 100644 --- a/common/src/plonk/circuit.rs +++ b/common/src/plonk/circuit.rs @@ -12,7 +12,6 @@ use ff::Field; use halo2_middleware::circuit::{ AdviceQueryMid, Challenge, ExpressionMid, FixedQueryMid, InstanceQueryMid, }; -use halo2_middleware::lookup::ArgumentV2; use halo2_middleware::poly::Rotation; use sealed::SealedPhase; use std::collections::BTreeSet; @@ -1715,11 +1714,11 @@ pub struct ConstraintSystemV2Backend { // Vector of lookup arguments, where each corresponds to a sequence of // input expressions and a sequence of table expressions involved in the lookup. - pub(crate) lookups: Vec>, + pub(crate) lookups: Vec>, // Vector of shuffle arguments, where each corresponds to a sequence of // input expressions and a sequence of shuffle expressions involved in the shuffle. - pub(crate) shuffles: Vec>, + pub(crate) shuffles: Vec>, // List of indexes of Fixed columns which are associated to a circuit-general Column tied to their annotation. pub(crate) general_column_annotations: HashMap, @@ -1756,7 +1755,7 @@ impl Into> for ConstraintSystem { lookups: self .lookups .iter() - .map(|l| ArgumentV2 { + .map(|l| halo2_middleware::lookup::ArgumentV2 { name: l.name.clone(), input_expressions: l .input_expressions @@ -1775,7 +1774,7 @@ impl Into> for ConstraintSystem { shuffles: self .shuffles .iter() - .map(|s| shuffle::ArgumentV2 { + .map(|s| halo2_middleware::shuffle::ArgumentV2 { name: s.name.clone(), input_expressions: s .input_expressions diff --git a/common/src/plonk/shuffle.rs b/common/src/plonk/shuffle.rs index 8656a3b8..496f691c 100644 --- a/common/src/plonk/shuffle.rs +++ b/common/src/plonk/shuffle.rs @@ -6,14 +6,6 @@ use std::fmt::{self, Debug}; pub(crate) mod prover; pub(crate) mod verifier; -/// Expressions involved in a shuffle argument, with a name as metadata. -#[derive(Clone, Debug)] -pub struct ArgumentV2 { - pub(crate) name: String, - pub(crate) input_expressions: Vec>, - pub(crate) shuffle_expressions: Vec>, -} - /// Expressions involved in a shuffle argument, with a name as metadata. #[derive(Clone)] pub struct Argument {