Commit Graph

2478 Commits

Author SHA1 Message Date
Jack Grigg 165e993e83 CI: Run tests on 32-bit target 2023-03-02 19:56:22 +00:00
Jack Grigg 0eb65d4927 Add a `TracingFloorPlanner` that does nothing
As currently implemented, all this does is transparently wrap another
`FloorPlanner`, in order to transparently wrap every other circuit type
that passes through it.
2023-02-28 14:53:31 +00:00
Jack Grigg ca3dacffdb halo2_proofs: Add `Region::instance_value`
Closes zcash/halo2#740.
2023-02-28 14:52:36 +00:00
CarloModicaPortfolio ba52d72ae4 fixing mistake in decorator of MyCircuit struct 2023-02-15 17:48:32 +01:00
CarloModicaPortfolio cdf5260b04 fixing mistake in decorator 2023-02-15 17:47:44 +01:00
CarloModicaPortfolio 272315b87b update of SHA256 to pull #654 2023-02-15 17:22:57 +01:00
str4d 47f2cc8349
Merge pull request #728 from nagatoism/disable-rayon
Add feature "multicore"  and you can disable rayon by disabling the  "multicore" feature.
2023-02-14 20:32:28 +00:00
Jack Grigg c4abcd5fd1 Disable default features of halo2_proofs in other crates
Now that `multicore` is a default feature instead of just being always
on, we can ensure it is not enabled just as a result of depending on
`halo2_gadgets` or `halo2`.
2023-02-14 19:06:18 +00:00
Jack Grigg b60e9a4eb6 Explicitly fail if `multicore` is enabled for wasm32 without atomics
`maybe-rayon` has this case fall back to not using rayon, which while
correct is potentially confusingly non-performant. Developers building
for WASM will have similar things they need to handle themselves; they
can conditionally enable `multicore` there.
2023-02-14 19:06:18 +00:00
str4d 5ff0e83616 Take accumulator as `T` in `halo2_proofs::multicore::TryFoldAndReduce`
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-02-14 18:53:36 +00:00
str4d b90522797e Fix formatting of `halo2_proofs::multicore` comments
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-02-14 18:53:36 +00:00
wangyao 36055ab47d add comment explaining the type of try_fold_and_reduce 2023-02-14 18:53:36 +00:00
wangyao 6fbde15d11 Add `multicore` feature flag to allow `rayon` to be disabled
Closes zcash/halo2#648.

Co-authored-by: Jack Grigg <jack@electriccoin.co>
2023-02-14 18:53:36 +00:00
str4d 210483df8e
Merge pull request #734 from zcash/inferno-msrv-1.59
Constrain `inferno` transitive dependency to our MSRV
2023-02-14 18:53:17 +00:00
Jack Grigg 280f838c5c Constrain `inferno` transitive dependency to our MSRV
`inferno 0.11.5` raised its MSRV to 1.64.0. Adding this range constraint
is fine because it's only a dev-dependency.
2023-02-14 18:16:50 +00:00
str4d e0f6512165
Merge pull request #731 from zcash/msrv-1.60
Bump MSRV to 1.60
2023-02-10 20:36:20 +00:00
Jack Grigg 8dbc554f6c CI: Prepare feature flags in the internal composite action
This ensures that we only run CI on crate-external feature flags that we
intend to be covered by our MSRV.
2023-02-10 20:06:29 +00:00
Jack Grigg 55abb2464a CI: Use an internal composite action to reduce MSRV definitions 2023-02-10 18:32:23 +00:00
Jack Grigg 09f9c095d0 Bump MSRV to 1.60
- `blake2b_simd 1.0.1` raised its MSRV to 1.59.
- `proptest 1.1.0` added a dependency on `unarray` which has an implicit
  MSRV of 1.60.
2023-02-10 18:09:11 +00:00
str4d 94b454ca2f
Merge pull request #723 from ImmanuelSegol/feat/avoid-wasm-error
bug fix - wasm pack compile error
2023-01-20 23:55:57 +00:00
dante 9eb8eadbd7
chore: instance columns for poseidon bench (#712) 2023-01-20 23:08:24 +00:00
ImmanuelSegol aae4dce533 Fix rustc type inferring bug by pinning some types
This has been occurring spuriously during development for a while, but
only when other compilation issues were present. However, now that it
also occurs when using wasm-pack, we are fixing it.

Co-authored-by: Jack Grigg <jack@electriccoin.co>
2023-01-20 22:45:50 +00:00
str4d caf9e71b30
Merge pull request #722 from zcash/book-patch-pedersen
[book] Fix typo in description of Pedersen commitments
2023-01-20 21:37:43 +00:00
str4d 2d60a5b946
Merge pull request #724 from zcash/fix-book-rendering
Fix book rendering
2023-01-20 21:24:57 +00:00
Jack Grigg 5e51272551 CI: Publish correct book path
zcash/halo2#713 added a second renderer to mdBook, and it turns out
that causes mdBook to generate subfolders that it doesn't do with a
single renderer. We now handle the presence of the subfolders when
publishing the book to GitHub Pages.
2023-01-20 21:18:42 +00:00
Jack Grigg 53639f9cc3 book: Make PDF rendering optional
PDF book rendering is slow, so don't require it if the developer doesn't
have mdbook-pdf installed.
2023-01-20 21:17:16 +00:00
str4d d771a48f68
Merge pull request #718 from HollowMan6/main
Fix book deploying CI and add pdf uploading
2023-01-20 20:52:28 +00:00
str4d 1b1fdc2e2d
Merge pull request #721 from daira/safari-rayon-status
Update the status of support for nested web workers in Safari
2023-01-20 20:48:51 +00:00
ying tong a688c19f0d
Update groups.md 2023-01-18 10:49:29 -05:00
Daira Hopwood 450aa16c48 Update the status of support for nested web workers in Safari.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2023-01-17 16:58:22 +00:00
Hollow Man 398f80bb03
Use revision of the patched mdbook
Signed-off-by: Hollow Man <hollowman@opensuse.org>
2023-01-10 22:02:17 +02:00
ebfull 476980efcd
Merge pull request #633 from zcash/fixed-cur
Only allow fixed queries at `Rotation::cur`
2023-01-10 12:44:47 -07:00
Hollow Man 79c5517d21
Fix book deploying CI and add pdf uploading
Signed-off-by: Hollow Man <hollowman@opensuse.org>
2023-01-08 21:34:51 +02:00
str4d 942b2f84aa
Merge pull request #713 from HollowMan6/main
Book PDF generation
2023-01-06 22:19:14 +00:00
str4d 136eed1df4
Merge pull request #716 from zcash/707-in-situ-dev-workflow
Add harness for `nightly -> beta -> stable` dev workflow
2023-01-06 11:34:02 +00:00
Jack Grigg 4b804a141a Make SHA-256 gadget a nightly feature
This was effectively the meaning of the prior `unstable` feature flag.
2023-01-03 19:12:39 +00:00
Jack Grigg 01323b9eb6 Add harness for `nightly -> beta -> stable` dev workflow
Part of zcash/halo2#707.
2023-01-03 19:12:39 +00:00
Dimitris Apostolou 9dfc5d9393 Fix typos 2023-01-03 18:37:51 +08:00
Hollow Man eebc480cb7
Book PDF generation
Signed-off-by: Hollow Man <hollowman@opensuse.org>
2022-12-27 23:13:24 +02:00
therealyingtong 41c87eac0f Restrict query_fixed to current Rotation.
query_fixed no longer takes a Rotation argument and can only be
used to query the current rotation.
2022-12-09 16:47:19 +08:00
therealyingtong 153a08c755 query_any: panic if query_fixed is called with non-cur Rotation. 2022-12-09 16:47:14 +08:00
str4d 7239a02ea3
Merge pull request #701 from zcash/ff-0.13
Migrate to published `ff 0.13`
2022-12-07 10:21:33 +00:00
Jack Grigg 1d9790b2ce Migrate to published `ff 0.13` 2022-12-06 04:55:21 +00:00
str4d 677866d653
Merge pull request #697 from zcash/fieldext-finale
Migrate to `ff` revision without `FieldExt`
2022-12-05 19:27:06 +00:00
Jack Grigg cb819e47e9 Migrate to `ff` revision without `FieldExt` 2022-11-30 19:35:26 +00:00
str4d 6ae9f77e04
Merge pull request #678 from nuttycom/fix_clippy_lints
Fix beta and nightly clippy complaints
2022-11-30 19:25:54 +00:00
Daira Hopwood 9116ac13e2 Resolve `mdbook test` failures in `book/src/user/wasm-port.md`.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-30 15:13:55 +00:00
therealyingtong 966b5fc3b7 halo2_proofs/CHANGELOG: Document structs which now derive Eq 2022-11-30 15:13:55 +00:00
Daira Hopwood 23f63a8f50 Fix nightly clippy complaints.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-30 15:13:55 +00:00
Daira Hopwood c387aa7204 Fix additional beta clippy complaints.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-30 15:13:55 +00:00