zec
/
halo2
mirror of https://github.com/zcash/halo2.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
677 Commits 40 Branches 6 Tags 58 MiB
Commit Graph

677 Commits

Author SHA1 Message Date
Sean Bowe 6226426be0
Restore whitespace 2021-02-17 15:19:34 -07:00
ebfull bc9d05e67b
Apply suggestions from code review 
Co-authored-by: str4d <jack@electriccoin.co>
 2021-02-17 15:19:34 -07:00
Sean Bowe 98f5b17359
Remove unused import 2021-02-17 15:19:34 -07:00
Sean Bowe ea563434f4
Remove hash_into from Rotation. 2021-02-17 15:19:34 -07:00
Sean Bowe dfa7d96fa9
Refactor verification key hashing logic to use Display impls. 2021-02-17 15:19:34 -07:00
therealyingtong f35e190455
Hash in field modulus, curve parameters 2021-02-17 15:19:34 -07:00
therealyingtong 52c028b4da
Disambiguate naming of hash() -> hash_into() 2021-02-17 15:19:34 -07:00
therealyingtong e7d6f67564
Rename aux -> instance after rebasing 2021-02-17 15:19:34 -07:00
therealyingtong b204ff74a8
Do not return hash results from component hash() methods 2021-02-17 15:19:34 -07:00
therealyingtong 4aa4b4463a
Hash domain and cs into transcript 2021-02-17 15:19:34 -07:00
therealyingtong 437782e902
Hash fixed_commitments and permutations into transcript 2021-02-17 15:19:33 -07:00
Daira Hopwood ad771f89cb Book: improve the section explaining the permutation argument. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-02-17 21:26:39 +00:00
Jack Grigg 776016fe53 crossbeam-utils 0.8 2021-02-17 20:43:36 +00:00
Jack Grigg 0c4f779993 ff 0.9 2021-02-17 20:42:27 +00:00
Jack Grigg 2c77eccf01 metrics 0.14.2 2021-02-17 20:40:12 +00:00
Daira Hopwood a73560c842 Book: cosmetics and minor corrections / wording improvements. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-02-17 17:10:11 +00:00
Daira Hopwood 07af9ea3e7 Book: generalize input columns to expressions in lookup argument. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-02-17 17:09:10 +00:00
ebfull 068babe3d0
Merge pull request #193 from zcash/any-permutation 
Allow permutations to be over all column types
 2021-02-17 09:06:27 -07:00
ebfull b299542eea
Merge pull request #174 from zcash/ecc-gadget 
Add gadgets for elliptic curve operations
 2021-02-17 08:54:02 -07:00
therealyingtong a19dc68dee Use Column<Any> in Permutation::Argument 2021-02-17 21:32:17 +08:00
Jack Grigg bea5f7f418 Add gadgets for elliptic curve operations 2021-02-17 00:49:22 +00:00
Jack Grigg 25573bbeb8 Alter the SHA-256 gadget to require namespacing 2021-02-17 00:16:47 +00:00
ebfull 0a3933b76a
Merge pull request #166 from zcash/sha-256-gadget 
SHA-256 gadget
 2021-02-16 12:09:11 -07:00
str4d c10b84ce13
Merge pull request #187 from zcash/book-fixes 
Book fixes
 2021-02-17 06:53:10 +13:00
str4d e1a3cc5e9e
book: Evaluation points are elements of fields, not groups 
Polynomials require both addition and multiplication, which fields have, whereas a group only specifies a single operation.
 2021-02-17 06:46:28 +13:00
Jack Grigg 4c5a00b767 SHA-256 gadgets and chip traits 2021-02-15 16:35:58 +00:00
ebfull 89b007336a
Merge pull request #188 from zcash/clippy-beta 
CI updates
 2021-02-15 09:07:37 -07:00
Daira Hopwood 22297bbc89
Merge pull request #185 from daira/aux-to-instance 
Rename "auxiliary column" to "instance column" in the book and in code
 2021-02-15 15:42:54 +00:00
Jack Grigg 7d81971079 CI: Warn with clippy on beta instead of nightly 
We don't want the noise of changes to nightly clippy, but we _do_ want
advance warning of upcoming CI breakage. Running clippy on beta will
give us six weeks notice.
 2021-02-15 15:41:35 +00:00
Jack Grigg fb9eb3b483 CI: Run intra-doc checks on stable 2021-02-15 15:39:16 +00:00
ebfull 356ce36c71
Merge pull request #184 from zcash/fix-clippy 
Disable clippy::upper_case_acronyms lint
 2021-02-15 08:19:42 -07:00
Daira Hopwood c769dd0fa6 Address @str4d's review comment about advice and instance columns being treated almost identically. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-02-15 15:08:29 +00:00
Sean Bowe 3b954cdd3b
Allow unknown clippy lints so that lints added in nightly don't break CI 2021-02-15 07:53:27 -07:00
Jack Grigg ba9917e35c book: Linkify URLs in references 2021-02-15 14:38:46 +00:00
Jack Grigg cf68b5ba05 book: Clarify meaning of "evaluation point" in our context 
Polynomial evaluation points and elliptic curve points are both things
we rely on, but never in the same context (we either use elliptic curve
points inside circuits, or implement proving systems on top of them).
 2021-02-15 14:30:12 +00:00
Daira Hopwood 760d69bd2c Rename "auxiliary column" to "instance column" in the book and in code. fixes #181 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-02-14 21:09:49 +00:00
Sean Bowe 175c1449d3
Disable clippy::upper_case_acronyms lint. 2021-02-14 09:39:05 -07:00
ebfull 55122e5161
Merge pull request #183 from zcash/fix-ci 
Downgrade to funty 1.1.0 to fix CI
 2021-02-14 09:37:10 -07:00
Sean Bowe 4b960a7c0c
cargo fmt 2021-02-14 09:28:51 -07:00
Sean Bowe 4747112118
Downgrade to funty 1.1.0 to fix CI. 2021-02-14 09:24:15 -07:00
ebfull 9fc45ad11e
Merge pull request #163 from zcash/region-helpers 
Helpers for implementing regions
 2021-02-12 10:03:39 -07:00
Jack Grigg 821bca0abe Reduce FieldExt bound to Field for Neg and Sub impls on Expression<F> 2021-02-12 16:52:42 +00:00
ebfull da2d4eb71b
Merge pull request #179 from zcash/common-scalar 
Add common_scalar method to Transcript
 2021-02-12 09:19:21 -07:00
str4d c5e2a5e310
Merge pull request #177 from zcash/book-proving-system 
[book] Fill out design section about proving system
 2021-02-13 05:10:56 +13:00
str4d 13ac4e7573
Merge pull request #178 from zcash/simple-example-comments 
Reflow simple-example.rs comments
 2021-02-13 05:09:15 +13:00
Sean Bowe d3cd39fc6d
Add common_scalar method to Transcript. 2021-02-12 09:08:56 -07:00
Jack Grigg 4739aaae5c book: Clarify IPA inputs in tl;dr section 2021-02-12 16:05:44 +00:00
Jack Grigg 24eb3500cb examples: Fix typo 2021-02-12 15:53:04 +00:00
Jack Grigg b3f85d3e69 examples: Reflow simple-example.rs comments for easier reading in book 2021-02-12 15:53:04 +00:00
Jack Grigg 126abd151c book: Clarify why fixed columns are shown separately in commitments 2021-02-12 15:30:48 +00:00