Jack Grigg
25573bbeb8
Alter the SHA-256 gadget to require namespacing
2021-02-17 00:16:47 +00:00
ebfull
0a3933b76a
Merge pull request #166 from zcash/sha-256-gadget
...
SHA-256 gadget
2021-02-16 12:09:11 -07:00
str4d
c10b84ce13
Merge pull request #187 from zcash/book-fixes
...
Book fixes
2021-02-17 06:53:10 +13:00
str4d
e1a3cc5e9e
book: Evaluation points are elements of fields, not groups
...
Polynomials require both addition and multiplication, which fields have, whereas a group only specifies a single operation.
2021-02-17 06:46:28 +13:00
Jack Grigg
4c5a00b767
SHA-256 gadgets and chip traits
2021-02-15 16:35:58 +00:00
ebfull
89b007336a
Merge pull request #188 from zcash/clippy-beta
...
CI updates
2021-02-15 09:07:37 -07:00
Daira Hopwood
22297bbc89
Merge pull request #185 from daira/aux-to-instance
...
Rename "auxiliary column" to "instance column" in the book and in code
2021-02-15 15:42:54 +00:00
Jack Grigg
7d81971079
CI: Warn with clippy on beta instead of nightly
...
We don't want the noise of changes to nightly clippy, but we _do_ want
advance warning of upcoming CI breakage. Running clippy on beta will
give us six weeks notice.
2021-02-15 15:41:35 +00:00
Jack Grigg
fb9eb3b483
CI: Run intra-doc checks on stable
2021-02-15 15:39:16 +00:00
ebfull
356ce36c71
Merge pull request #184 from zcash/fix-clippy
...
Disable clippy::upper_case_acronyms lint
2021-02-15 08:19:42 -07:00
Daira Hopwood
c769dd0fa6
Address @str4d's review comment about advice and instance columns being treated almost identically.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-15 15:08:29 +00:00
Sean Bowe
3b954cdd3b
Allow unknown clippy lints so that lints added in nightly don't break CI
2021-02-15 07:53:27 -07:00
Jack Grigg
ba9917e35c
book: Linkify URLs in references
2021-02-15 14:38:46 +00:00
Jack Grigg
cf68b5ba05
book: Clarify meaning of "evaluation point" in our context
...
Polynomial evaluation points and elliptic curve points are both things
we rely on, but never in the same context (we either use elliptic curve
points inside circuits, or implement proving systems on top of them).
2021-02-15 14:30:12 +00:00
Daira Hopwood
760d69bd2c
Rename "auxiliary column" to "instance column" in the book and in code. fixes #181
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-14 21:09:49 +00:00
Sean Bowe
175c1449d3
Disable clippy::upper_case_acronyms lint.
2021-02-14 09:39:05 -07:00
ebfull
55122e5161
Merge pull request #183 from zcash/fix-ci
...
Downgrade to funty 1.1.0 to fix CI
2021-02-14 09:37:10 -07:00
Sean Bowe
4b960a7c0c
cargo fmt
2021-02-14 09:28:51 -07:00
Sean Bowe
4747112118
Downgrade to funty 1.1.0 to fix CI.
2021-02-14 09:24:15 -07:00
ebfull
9fc45ad11e
Merge pull request #163 from zcash/region-helpers
...
Helpers for implementing regions
2021-02-12 10:03:39 -07:00
Jack Grigg
821bca0abe
Reduce FieldExt bound to Field for Neg and Sub impls on Expression<F>
2021-02-12 16:52:42 +00:00
ebfull
da2d4eb71b
Merge pull request #179 from zcash/common-scalar
...
Add common_scalar method to Transcript
2021-02-12 09:19:21 -07:00
str4d
c5e2a5e310
Merge pull request #177 from zcash/book-proving-system
...
[book] Fill out design section about proving system
2021-02-13 05:10:56 +13:00
str4d
13ac4e7573
Merge pull request #178 from zcash/simple-example-comments
...
Reflow simple-example.rs comments
2021-02-13 05:09:15 +13:00
Sean Bowe
d3cd39fc6d
Add common_scalar method to Transcript.
2021-02-12 09:08:56 -07:00
Jack Grigg
4739aaae5c
book: Clarify IPA inputs in tl;dr section
2021-02-12 16:05:44 +00:00
Jack Grigg
24eb3500cb
examples: Fix typo
2021-02-12 15:53:04 +00:00
Jack Grigg
b3f85d3e69
examples: Reflow simple-example.rs comments for easier reading in book
2021-02-12 15:53:04 +00:00
Jack Grigg
126abd151c
book: Clarify why fixed columns are shown separately in commitments
2021-02-12 15:30:48 +00:00
Jack Grigg
67b6d197aa
book: Tweak wording for proving system stage 1 commitments
2021-02-12 15:18:12 +00:00
Jack Grigg
576796037a
book: Move lookup argument design page to have consistent URI
2021-02-12 15:15:05 +00:00
Jack Grigg
7820083c0d
book: Reword paragraph about degree of relation polynomials
2021-02-12 15:13:16 +00:00
Jack Grigg
3181a21cba
book: Add beta and gamma requirements for lookup permutation product
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-02-12 15:08:00 +00:00
Jack Grigg
2c647009fc
book: Fix notation for committing to lookup permutation product columns
2021-02-12 15:06:33 +00:00
Jack Grigg
f30cbcbfc9
book: Fix notation in example constraint system
2021-02-12 14:48:05 +00:00
str4d
0a2fb4781d
book: Small changes from review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-02-13 03:43:35 +13:00
Jack Grigg
59010c4674
book: Document commitments to lookup and equality constraint arguments
2021-02-11 21:22:18 +00:00
Jack Grigg
7b7346c462
book: Add a placeholder page for explaining the IPA
...
For now, it directs readers to the existing comparision page, which
describes Halo 2's IPA relative to another work.
2021-02-11 19:54:45 +00:00
Jack Grigg
6da0adb4e1
book: Refactor the multipoint opening argument section
2021-02-11 19:54:45 +00:00
Jack Grigg
91a90f1d9d
book: Renumber multipoint opening challenges to match implementation
2021-02-11 19:54:39 +00:00
Jack Grigg
ffa8dacaba
book: Add section about vanishing argument
2021-02-11 19:54:38 +00:00
Jack Grigg
9e9a92a912
book: Add section about circuit commitments
2021-02-11 19:54:20 +00:00
Jack Grigg
e666f8b966
book: Add summary and succinct description of the Halo 2 protocol
2021-02-11 19:16:08 +00:00
Jack Grigg
4aceada21a
book: Re-order "Proving system" sub-sections
2021-02-10 13:06:22 +00:00
str4d
7ac44e8d53
Merge pull request #168 from zcash/book-updates
...
Book updates
2021-02-10 12:01:53 +13:00
Jack Grigg
425c45d96b
book: Add a simple example showing how the API is used
2021-02-08 15:56:16 +00:00
Jack Grigg
5905230174
Fix stable clippy lints
2021-02-05 16:48:41 +00:00
Jack Grigg
bfbfa80900
book: Add a comparison to BCMS20
2021-02-04 16:04:37 +00:00
Jack Grigg
3fc245343e
Return results from assigned regions
...
This makes it easier to pass variables out of a region.
2021-02-01 21:42:57 +00:00
Jack Grigg
db0477a606
impl<F: FieldExt> {Neg, Sub} for Expression<F>
2021-02-01 21:42:57 +00:00