zec
/
halo2
mirror of https://github.com/zcash/halo2.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
970 Commits 40 Branches 6 Tags 58 MiB
Commit Graph

970 Commits

Author SHA1 Message Date
Sean Bowe f532b7e973
Return error if supplied instance slice is too large. 2021-07-13 11:44:58 -06:00
Sean Bowe f314f66f69
Fix clippy lint 2021-07-13 10:11:38 -06:00
Sean Bowe 574ce73d80
Minor changes to `distribute_powers_zeta`. 2021-07-13 10:10:03 -06:00
Sean Bowe c05ceab04d
Switch 5 to 3 in benchmark. 2021-07-13 09:15:30 -06:00
Sean Bowe 9155cd174b
Introduce `set_minimum_degree` to avoid performance regression in benchmark. 2021-07-12 15:28:16 -06:00
Daira Hopwood 20c347b269
Merge pull request #320 from daira/book-zk-changes 
[Book] Zero knowledge changes (and misc cleanups)
 2021-07-12 20:35:20 +01:00
Sean Bowe 827132302a
Remove the ability to rotate when switching to the extended domain. 2021-07-12 12:57:09 -06:00
Sean Bowe a091795aca
Switch to computing only Rotation::cur() cosets until rotation is needed. 2021-07-12 12:53:12 -06:00
Sean Bowe 55424c8c2f
Add `{mul,add,sub}_extended` and `rotate_extended` methods to `EvaluationDomain`. 2021-07-12 11:44:09 -06:00
Daira Hopwood 103c93391d Clarify the statement about the δ^i being distinct quadratic non-residues. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 17:24:21 +01:00
Daira Hopwood 8ac20608e4 Merge branch 'kw-halo-book' into book-zk-changes 
Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 02:32:36 +01:00
Daira Hopwood 06ff90ba95 Rename UPA to PLONKish. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 02:12:58 +01:00
Daira Hopwood 0a39457780
Merge pull request #319 from zcash/book-fixes 
Book fixes
 2021-07-12 02:06:14 +01:00
Daira Hopwood 6a11c2b97e Update the circuit commitments section for the changes to the permutation argument. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 02:03:41 +01:00
Daira Hopwood 1b3241d757 Clarify product argument and add a diagram. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 02:03:41 +01:00
Daira Hopwood fedcc1960d Permutation argument cosmetics. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 02:01:39 +01:00
Daira Hopwood 69ca38d2b1 Update permutation argument for zero knowledge changes in #316. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 02:01:39 +01:00
Daira Hopwood 25b42a531d Follow https://github.com/zcash/halo2/pull/316 and https://github.com/zcash/orchard/issues/143 
in using 1 - Z(X) instead of Z(X) - 1.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 02:01:39 +01:00
Daira Hopwood 0dbf7cf4af Match the order of q_last and q_blind in the implementation. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 02:01:39 +01:00
Daira Hopwood 5deb3fcd72 Lookup argument cosmetics. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 02:01:39 +01:00
Daira Hopwood 55c48007c9 Update lookup argument for zero knowledge changes in #316. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2021-07-12 02:01:39 +01:00
Sean Bowe d8df7a12d5
Fix clippy lint on beta. 2021-07-10 08:52:30 -06:00
Sean Bowe cc84e9bf52
Additional documentation suggestions from @str4d. 2021-07-10 08:47:57 -06:00
Sean Bowe 50768bff20
Add comment explaining the extra caution in minimum_rows(). 2021-07-10 08:43:01 -06:00
Sean Bowe 9023161988
Add bounds check to Assignment::query_instance impls. 2021-07-10 08:25:00 -06:00
Sean Bowe c4e2554654
Incorporate documentation improvements suggested by @str4d. 2021-07-10 08:20:34 -06:00
Sean Bowe 3942d4e2e8
(examples) Specify row when calling expose_public in simple-example. 2021-07-10 08:13:24 -06:00
Sean Bowe 1be7bf1df0
Address review comments from @daira. 2021-07-10 08:12:08 -06:00
Sean Bowe 20653acc39
Document `permutation::Argument::required_degree`. 2021-07-10 07:52:42 -06:00
str4d 66e4b0ee7f
Merge pull request #321 from zcash/ci-book-rustdoc 
book: Render latest rustdoc in book subdir
 2021-07-09 20:20:14 +01:00
Jack Grigg 4eb464e49d book: Render latest rustdoc in book subdir 2021-07-09 20:12:40 +01:00
Jack Grigg 5fe6323a8d book: Add note about efficient FFTs for Pallas and Vesta 2021-07-09 19:53:41 +01:00
Sean Bowe fc946d99bf
Use Option in sanity-check rather than a random value. 2021-07-09 12:47:36 -06:00
Sean Bowe 9e6277ef6b
Make `usable_rows` temporary to avoid duplicative code. 2021-07-09 12:45:51 -06:00
Sean Bowe 326cae153e
Fix minor typos in comments. 2021-07-09 12:44:27 -06:00
Sean Bowe 90be1c29ab
Fix bug in sanity check during lookup argument witness creation. 2021-07-09 12:41:52 -06:00
Sean Bowe bd29ebdb05
Use ranges to clarify bounds on cell assignment. 2021-07-09 12:38:38 -06:00
Jack Grigg fe4996af35 book: Add a note about the multiplicative subgroups we use for Halo 2 2021-07-09 17:48:43 +01:00
Jack Grigg 9f77c93d4e book: Fix definition of the nth roots of unity 2021-07-09 17:48:03 +01:00
Sean Bowe 00b0b6c535
Add documentation for ConstraintSystem::num_advice_queries. 2021-07-09 09:28:45 -06:00
Sean Bowe 1c48ace3d9
Simplify l_last assignment. 2021-07-09 09:22:25 -06:00
Sean Bowe 7c66323d87
Rename l_cover to l_blind for clarity. 2021-07-09 09:22:25 -06:00
Sean Bowe f89e27ad10
Address some comments from @daira. 2021-07-09 09:22:20 -06:00
Sean Bowe e16aa31357
clippy fixes 2021-07-09 09:00:35 -06:00
Daira Hopwood c026cb0776
Merge pull request #314 from zcash/patch-book-sqrt 
[book] Fix Sarkar square root explanation
 2021-07-09 14:28:31 +01:00
Sean Bowe 8582731073
Build examples during CI bitrot check. 2021-07-08 15:33:03 -06:00
Sean Bowe 26739bbffe
Improvement to error messages for permutation argument failures in the mock prover. 2021-07-08 15:32:56 -06:00
Sean Bowe 0766983686
Fix examples to account for public input API changes. 2021-07-08 15:32:56 -06:00
Sean Bowe b246897a8d
Add `constrain_instance` and `assign_advice_from_instance` APIs. 2021-07-08 15:32:56 -06:00
Sean Bowe fe215d153d
Update tests with API changes for public inputs and permutation argument. 2021-07-08 15:32:51 -06:00