Daira Hopwood
23f63a8f50
Fix nightly clippy complaints.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-30 15:13:55 +00:00
Daira Hopwood
c387aa7204
Fix additional beta clippy complaints.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-30 15:13:55 +00:00
Kris Nuttycombe
b3f7db16f8
Fix beta clippy complaints.
2022-11-30 14:57:15 +00:00
str4d
455ee88b96
Merge pull request #687 from naure/optim/linear-multiopen
...
Optimize multiopen verifier for many columns
2022-11-30 07:25:56 +00:00
str4d
a19ce33c39
Merge pull request #696 from zcash/fieldext-final-cleanups
...
Final cleanups before `FieldExt` removal
2022-11-30 05:01:33 +00:00
Jack Grigg
02eb00a303
halo2_gadgets: Add missing changelog entry
2022-11-30 04:48:06 +00:00
Jack Grigg
3e6df2b1de
halo2_proofs: Replace `pasta_curves::arithmetic::Group` with new blanket trait
2022-11-30 03:41:45 +00:00
Jack Grigg
49b2324f0a
Replace unnecessary dependencies on `FieldExt` trait
2022-11-30 03:41:19 +00:00
Jack Grigg
63e6bd882c
poseidon: Refactor MDS generation into a helper method
2022-11-30 03:39:16 +00:00
Daira Hopwood
b097f098ae
Merge pull request #685 from zcash/zero-area-region
...
[MockProver] failure::FailureLocation: Handle zero-area regions.
2022-11-29 19:26:12 +00:00
Daira Hopwood
733b4f3567
Merge pull request #694 from zcash/simplify-evaluationdomain
...
Simplify `EvaluationDomain` to only accept field elements
2022-11-29 18:39:46 +00:00
Daira Hopwood
627b35528d
Merge pull request #688 from zhiqiangxu/fix_typo
...
fix a typo
2022-11-29 18:18:18 +00:00
Jack Grigg
41860fa605
halo2_proofs: Fix `CircuitLayout` example
2022-11-24 02:30:46 +00:00
Jack Grigg
93af730c6c
Simplify `EvaluationDomain` to only accept field elements
...
We do not use `EvaluationDomain` with group elements, so there is no
need to directly use the FFT `Group` abstraction trait here.
2022-11-24 01:59:08 +00:00
Jack Grigg
0ba0e40b87
CI: Avoid testing against MSRV with test-dev-graph feature flag
...
We only need it for generating images of halo2_gadgets chips, and its
transitive dependencies have bumped MSRV in point releases.
2022-11-24 01:56:54 +00:00
zhiqiangxu
49cd4eaa6f
fix a typo
2022-11-12 12:11:27 +08:00
Aurélien Nicolas
f99799f69d
optim/linear-multiopen: remove tmp benchmark code
2022-10-27 16:27:24 +02:00
Aurélien Nicolas
6986d0ceef
optim/linear-multiopen: remove Horner's rule on MSM
2022-10-26 12:10:47 +02:00
Aurélien Nicolas
54f1e34d21
optim/linear-multiopen: measure
2022-10-26 11:45:38 +02:00
therealyingtong
41c28ae6b2
failure::FailureLocation: Handle zero-area regions.
2022-10-20 17:44:24 -07:00
ying tong
ec9dcefe91
[book] Include WASM guide in SUMMARY.md
2022-10-18 12:52:25 -04:00
Daira Hopwood
b432cb95f2
Merge pull request #662 from nalinbhardwaj/wasm-guide
...
WASM Guide
2022-10-18 17:46:53 +01:00
Daira Hopwood
bb31119652
Link to Params section
...
Co-authored-by: Greg Pfeil <greg@electriccoin.co>
2022-10-18 17:46:09 +01:00
Nalin
b00356f9fc
Apply suggestions from @daira 's code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-10-09 15:19:32 -07:00
Daira Hopwood
ccfe3e8ccd
Merge pull request #671 from zcash/refactor-lookup
...
`lookup::prover`: Compress expressions and cosets in `commit_permuted`
2022-10-08 13:29:44 +01:00
Daira Hopwood
def465de33
Merge pull request #658 from nalinbhardwaj/add-row-count
...
[MockProver] Add row and col count to cost model
2022-10-08 12:25:20 +01:00
therealyingtong
c443665224
lookup::prover: Compress expressions and cosets in commit_permuted
...
The theta challenge is used in the lookup argument to compress the
input and table expressions. This can be done fully in the
commit_permuted step, after which the original uncompressed
expressions are no longer needed.
Author: Ying Tong Lai <yingtong@z.cash>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-10-08 12:07:54 +01:00
Daira Hopwood
6c1f78d39e
clippy fixes and cargo fmt.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-10-08 11:52:25 +01:00
Daira Hopwood
0f7299c116
Merge pull request #625 from zcash/region-query-instance
...
halo2_proofs: Introduce `RegionLayouter::instance_value` method.
2022-10-08 11:18:46 +01:00
Daira Hopwood
de76fd48fc
Merge pull request #622 from zcash/patch-mockprover-query_instance
...
[MockProver] Check for instance values in gate queries.
2022-10-08 11:15:06 +01:00
Daira Hopwood
21a79182ed
Merge pull request #667 from Orbis-Tertius/fix-plonk-test
...
Don't use `include_bytes!` for `plonk_api` test
2022-10-07 15:14:38 +01:00
Daira Hopwood
c824785b7d
Merge pull request #677 from zcash/therealyingtong-patch-1
...
[doc] commitment::verifier: verify_proof does not have [-c]G term
2022-10-07 15:11:07 +01:00
ying tong
4d970865cb
[doc] commitment::verifier: verify_proof does not have [-c]G term
2022-10-05 17:57:48 -07:00
ying tong
ac738ca5a1
Update book/src/background/pc-ipa.md
2022-10-05 17:54:21 -07:00
Simon Masson
fcd6f8d1e4
typo pc-ipa.md
2022-10-05 17:54:21 -07:00
Nalin Bhardwaj
34a7d83932
add note about debugging
2022-09-26 10:45:07 -07:00
Daira Hopwood
6f692c0e53
There is no z' in the lookup argument, only z.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-09-26 20:14:08 +08:00
Las Safin
bc10548907
`cargo fmt`
2022-09-23 13:16:49 +00:00
Las Safin
6b3da1fb4b
Don't use `include_bytes!` for `plonk_api` test
...
The current working directory for a test always seems to be
the root of the crate, hence `./tests/plonk_api_proof.bin` is
always the correct path.
2022-09-23 11:25:37 +00:00
str4d
61b7a46a7f
Merge pull request #664 from zcash/dependabot/github_actions/codecov/codecov-action-3.1.1
...
build(deps): bump codecov/codecov-action from 3.1.0 to 3.1.1
2022-09-20 23:33:31 +01:00
dependabot[bot]
b503deea16
build(deps): bump codecov/codecov-action from 3.1.0 to 3.1.1
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/v3.1.0...v3.1.1 )
---
updated-dependencies:
- dependency-name: codecov/codecov-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-09-20 10:27:15 +00:00
Nalin Bhardwaj
fad6201b34
Merge layouter used by cost and graph into one
2022-09-16 16:27:51 +05:30
Nalin Bhardwaj
55d470ffd2
Add row and col count to cost model
2022-09-16 16:27:22 +05:30
Nalin Bhardwaj
0ffcb5048c
WASM Guide
2022-09-16 16:16:44 +05:30
ebfull
61a1f63fcb
Merge pull request #623 from zcash/table-col-equality
...
Allow `enable_equality` on `TableColumn`
2022-09-13 08:03:20 -06:00
ebfull
2bdb369393
Merge pull request #654 from zcash/bug-instances-len
...
`plonk::prover::create_proof`: Check that `circuits` and `instances` have equal lengths
2022-09-13 08:02:26 -06:00
ebfull
d5200aea58
Merge pull request #653 from zcash/minor-fixes
...
Minor fixes
2022-09-13 08:01:58 -06:00
therealyingtong
76c658b321
[MockProver] Check for instance values in gate queries.
2022-09-13 18:25:21 +08:00
therealyingtong
7ed2a4d529
plonk::prover::create_proof: Return error if circuits and instances have different lengths.
2022-09-13 18:19:45 +08:00
therealyingtong
d0bbcda590
plonk::prover: Test proof creation with wrong number of instances.
...
Currently, create_proof passes even if the number of circuits does
not equal the number of instances.
2022-09-13 18:19:45 +08:00