Daira Hopwood
|
25b42a531d
|
Follow https://github.com/zcash/halo2/pull/316 and https://github.com/zcash/orchard/issues/143
in using 1 - Z(X) instead of Z(X) - 1.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
|
2021-07-12 02:01:39 +01:00 |
Daira Hopwood
|
0dbf7cf4af
|
Match the order of q_last and q_blind in the implementation.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
|
2021-07-12 02:01:39 +01:00 |
Daira Hopwood
|
5deb3fcd72
|
Lookup argument cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
|
2021-07-12 02:01:39 +01:00 |
Daira Hopwood
|
55c48007c9
|
Update lookup argument for zero knowledge changes in #316.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
|
2021-07-12 02:01:39 +01:00 |
Sean Bowe
|
d8df7a12d5
|
Fix clippy lint on beta.
|
2021-07-10 08:52:30 -06:00 |
Sean Bowe
|
cc84e9bf52
|
Additional documentation suggestions from @str4d.
|
2021-07-10 08:47:57 -06:00 |
Sean Bowe
|
50768bff20
|
Add comment explaining the extra caution in minimum_rows().
|
2021-07-10 08:43:01 -06:00 |
Sean Bowe
|
9023161988
|
Add bounds check to Assignment::query_instance impls.
|
2021-07-10 08:25:00 -06:00 |
Sean Bowe
|
c4e2554654
|
Incorporate documentation improvements suggested by @str4d.
|
2021-07-10 08:20:34 -06:00 |
Sean Bowe
|
3942d4e2e8
|
(examples) Specify row when calling expose_public in simple-example.
|
2021-07-10 08:13:24 -06:00 |
Sean Bowe
|
1be7bf1df0
|
Address review comments from @daira.
|
2021-07-10 08:12:08 -06:00 |
Sean Bowe
|
20653acc39
|
Document `permutation::Argument::required_degree`.
|
2021-07-10 07:52:42 -06:00 |
str4d
|
66e4b0ee7f
|
Merge pull request #321 from zcash/ci-book-rustdoc
book: Render latest rustdoc in book subdir
|
2021-07-09 20:20:14 +01:00 |
Jack Grigg
|
4eb464e49d
|
book: Render latest rustdoc in book subdir
|
2021-07-09 20:12:40 +01:00 |
Jack Grigg
|
5fe6323a8d
|
book: Add note about efficient FFTs for Pallas and Vesta
|
2021-07-09 19:53:41 +01:00 |
Sean Bowe
|
fc946d99bf
|
Use Option in sanity-check rather than a random value.
|
2021-07-09 12:47:36 -06:00 |
Sean Bowe
|
9e6277ef6b
|
Make `usable_rows` temporary to avoid duplicative code.
|
2021-07-09 12:45:51 -06:00 |
Sean Bowe
|
326cae153e
|
Fix minor typos in comments.
|
2021-07-09 12:44:27 -06:00 |
Sean Bowe
|
90be1c29ab
|
Fix bug in sanity check during lookup argument witness creation.
|
2021-07-09 12:41:52 -06:00 |
Sean Bowe
|
bd29ebdb05
|
Use ranges to clarify bounds on cell assignment.
|
2021-07-09 12:38:38 -06:00 |
Jack Grigg
|
fe4996af35
|
book: Add a note about the multiplicative subgroups we use for Halo 2
|
2021-07-09 17:48:43 +01:00 |
Jack Grigg
|
9f77c93d4e
|
book: Fix definition of the nth roots of unity
|
2021-07-09 17:48:03 +01:00 |
Sean Bowe
|
00b0b6c535
|
Add documentation for ConstraintSystem::num_advice_queries.
|
2021-07-09 09:28:45 -06:00 |
Sean Bowe
|
1c48ace3d9
|
Simplify l_last assignment.
|
2021-07-09 09:22:25 -06:00 |
Sean Bowe
|
7c66323d87
|
Rename l_cover to l_blind for clarity.
|
2021-07-09 09:22:25 -06:00 |
Sean Bowe
|
f89e27ad10
|
Address some comments from @daira.
|
2021-07-09 09:22:20 -06:00 |
Sean Bowe
|
e16aa31357
|
clippy fixes
|
2021-07-09 09:00:35 -06:00 |
Daira Hopwood
|
c026cb0776
|
Merge pull request #314 from zcash/patch-book-sqrt
[book] Fix Sarkar square root explanation
|
2021-07-09 14:28:31 +01:00 |
Sean Bowe
|
8582731073
|
Build examples during CI bitrot check.
|
2021-07-08 15:33:03 -06:00 |
Sean Bowe
|
26739bbffe
|
Improvement to error messages for permutation argument failures in the mock prover.
|
2021-07-08 15:32:56 -06:00 |
Sean Bowe
|
0766983686
|
Fix examples to account for public input API changes.
|
2021-07-08 15:32:56 -06:00 |
Sean Bowe
|
b246897a8d
|
Add `constrain_instance` and `assign_advice_from_instance` APIs.
|
2021-07-08 15:32:56 -06:00 |
Sean Bowe
|
fe215d153d
|
Update tests with API changes for public inputs and permutation argument.
|
2021-07-08 15:32:51 -06:00 |
Sean Bowe
|
1f1b705fa6
|
Make lookup argument perfectly zero-knowledge and complete.
|
2021-07-08 14:52:44 -06:00 |
ebfull
|
d5be50a848
|
Merge pull request #311 from daira/rayon-threadpool
Use a rayon ThreadPool
|
2021-07-03 11:05:05 -06:00 |
Daira Hopwood
|
421c6fcc12
|
Rename *_cpus to *_threads.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
|
2021-07-03 15:17:21 +01:00 |
Daira Hopwood
|
f64b54156a
|
Use global rayon threadpool.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
|
2021-07-03 15:17:03 +01:00 |
Sean Bowe
|
7afe549524
|
clippy fixes
|
2021-07-02 16:33:22 -06:00 |
Sean Bowe
|
32df26d881
|
Make permutation argument perfectly complete and zero-knowledge.
|
2021-07-02 16:20:36 -06:00 |
Sean Bowe
|
2ef2f7e73c
|
Change create_proof API to take vectors of scalars and compute polynomials internally.
|
2021-07-01 13:53:54 -06:00 |
Sean Bowe
|
1c586c081c
|
Switch directionality of the permutation argument's constraints.
|
2021-07-01 13:47:03 -06:00 |
Sean Bowe
|
9118697213
|
Additional comment about blinding h(X)
|
2021-07-01 13:01:39 -06:00 |
Sean Bowe
|
7fda6f672e
|
Always commit to a random polynomial that is evaluated at x in order to blind the multiopen evaluation of h(X).
|
2021-07-01 12:59:53 -06:00 |
Sean Bowe
|
fa2d0b061e
|
Remove unnecessary clones of fixed columns.
|
2021-07-01 12:52:27 -06:00 |
Sean Bowe
|
0a6804bb30
|
Compute the number of blinding factors each advice polynomial needs.
|
2021-07-01 12:48:01 -06:00 |
Sean Bowe
|
8eb3b7313c
|
Add support for computing ranges of evaluations of the Lagrange basis polynomials.
|
2021-07-01 12:46:22 -06:00 |
Sean Bowe
|
7bf2bbb941
|
Clippy fixes
|
2021-07-01 12:45:14 -06:00 |
Sean Bowe
|
fd91b6b42c
|
Allow MSMs to be queried and not just raw commitments.
This allows us to avoid some interstitial arithmetic in the vanishing argument.
|
2021-07-01 12:42:24 -06:00 |
Sean Bowe
|
f7ef626858
|
Linearize the h(X) check.
|
2021-06-30 10:11:53 -06:00 |
therealyingtong
|
69e7fb8221
|
[book] Fix Sarkar square root explanation
|
2021-06-30 19:31:23 +08:00 |