Commit Graph

17 Commits

Author SHA1 Message Date
therealyingtong 72ce521084 circuit.rs: crate visibility modifications from code review
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: ebfull <ewillbefull@gmail.com>
2023-04-04 09:32:08 +07:00
therealyingtong c3c57c6e07 circuit::table_layouter: Better table errors 2023-04-04 09:32:08 +07:00
therealyingtong 327b47524c table_layouter::compute_table_lengths: Extract helper function 2023-04-04 09:32:08 +07:00
therealyingtong a8aebdb848 [move-only] circuit::table_layouter: Move TableLayouter, SimpleTableLayouter 2023-04-04 09:32:08 +07:00
ebfull cae65c4b60
Merge pull request #741 from zcash/738-tracing-floor-planner
Create a `TracingFloorPlanner` for debugging purposes
2023-03-21 14:48:15 -06:00
Jack Grigg 7d4aafe3f6 Add debug `tracing` spans and events to `TracingFloorPlanner` 2023-03-14 19:34:29 +00:00
Daira Hopwood ab1cae34e1
Apply suggestions from code review (changelog and comments only)
Co-authored-by: Greg Pfeil <greg@technomadic.org>
2023-03-11 00:21:03 +00:00
Daira Hopwood 8231d8ffab Fix a nondeterminism bug: we were depending on sort order.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2023-03-10 22:03:05 +00:00
Daira Hopwood 23f63a8f50 Fix nightly clippy complaints.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-30 15:13:55 +00:00
therealyingtong 6038b87a1d halo2_proofs: Introduce RegionLayouter::instance_value method.
This allows us to access instance column values within a region.
Previously, this was done only through assign_advice_from_instance.
2022-07-07 17:18:42 -04:00
str4d 7cb71b4814
Update halo2_proofs/src/circuit/value.rs
Co-authored-by: ying tong <yingtong@z.cash>
2022-06-13 16:41:05 +01:00
Jack Grigg 5752adf0e5 halo2_proofs: `impl {Add, Sub, Mul} for &Value<V>` 2022-06-09 22:44:25 +00:00
Jack Grigg 521d6edd1c halo2_proofs: Make `Value::{known, unknown}` const 2022-06-09 22:40:11 +00:00
Jack Grigg 47f25ad632 halo2_proofs: Replace `Option<V>` with `Value<V>` 2022-06-08 23:03:16 +00:00
Jack Grigg c17d52e5bf halo2_proofs: Add `halo2_proofs::circuit::Value<V>`
This is a more usable and type-safe replacement for `Option<V>` in
circuit synthesis.
2022-06-08 22:29:14 +00:00
Dimitris Apostolou e2f88e450b
Fix typos 2022-02-03 18:01:22 +02:00
Jack Grigg 3c6558f049 Move `halo2` code into `halo2_proofs` crate 2022-01-20 18:50:43 +00:00