Commit Graph

841 Commits

Author SHA1 Message Date
therealyingtong 1f6b3c0014 Remove CellValue type 2021-04-28 20:39:08 +08:00
therealyingtong f3021beda6 Clean up anchors in simple-example.rs
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-04-28 12:36:37 +08:00
therealyingtong b2d42ef344 Remove superfluous clone() in doc example
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-04-28 10:57:51 +08:00
therealyingtong 21aaab20f6 Remove empty() methods from Config and Loaded traits
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-04-28 10:47:26 +08:00
Steven dda60a3630
Merge pull request #244 from steven-ecc/change-tgppl-to-bosl
Change TGPPL references to BOSL
2021-04-26 16:44:40 -07:00
Steven 7593ca66f0
Update Cargo.toml
Co-authored-by: ebfull <ewillbefull@gmail.com>
2021-04-26 16:44:32 -07:00
therealyingtong 7524c95547 Clippy fixes 2021-04-26 08:53:43 +08:00
str4d bb3af99524
Merge pull request #255 from zcash/patch-test-plonk-api
[tests] Update commitments in PinnedVerificationKey
2021-04-23 22:50:53 +01:00
therealyingtong 85c5f4412d Refactor Transcript API
- remove method to return a challenge in the base field
- let ChallengeSpace decide length of raw challenge instead of limiting it to u128

Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-04-23 19:18:41 +08:00
therealyingtong cd3cc543cf Update examples and tests 2021-04-23 19:18:41 +08:00
therealyingtong 1a61eaa5d9 Propagate type changes 2021-04-23 19:18:41 +08:00
therealyingtong 1a9baab55b Introduce ChallengeSpace trait with to_challenge_scalar() method.
This is implemented for the ChallengeScalarEndo and ChallengeScalarFull types.

Co-authored-by: Kris Nuttycombe <kris@electriccoin.co>
2021-04-23 19:18:41 +08:00
therealyingtong 03da010d6a [tmp] Comment out sha256 example 2021-04-23 17:40:43 +08:00
therealyingtong 3ad1c43fb8 Only keep config() and loaded() generic on Chip trait
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-04-23 17:40:43 +08:00
therealyingtong 40e7bec352 Move config responsiblities from Layouter to Chip trait 2021-04-23 17:40:43 +08:00
therealyingtong 24d7100bd4 Update commitments in PinnedVerificationKey
The pinned commitments have changed, presumably after the hash_to_field fix in zcash/pasta_curves a1194672c55ee03a1631b6e1af9d86a3bd87ab70.
2021-04-23 17:32:09 +08:00
str4d 6acacf1aca
Merge pull request #254 from zcash/curveaffine-coordinates
Migrate to pasta_curves with Coordinates struct
2021-04-19 22:50:58 +01:00
Jack Grigg da6abf40de Migrate to pasta_curves with Coordinates struct 2021-04-20 09:29:02 +12:00
Steven Smith 4bb35e038f Wording change to README to reflect new explainer 2021-04-16 08:36:49 -07:00
Steven Smith bd39b5040e Changing TGPPL references to BOSL 2021-04-16 08:33:10 -07:00
ebfull e1ab3b16b7
Merge pull request #243 from steven-ecc/add-bosl
Adding the Bootstrap Open Source Licence
2021-04-14 16:26:47 -06:00
Steven Smith 63ba133bb7 Adding the Bootstrap Open Source Licence 2021-04-14 09:32:32 -07:00
ebfull 78c394645d
Merge pull request #237 from zcash/dev-permutation-any-cols
Minor fixes to dev tools
2021-04-09 09:54:52 -06:00
Jack Grigg 0df5bc4b45 dev: Track region offset correctly in halo2::dev::circuit_layout 2021-04-09 14:32:20 +12:00
Jack Grigg 4c9362c504 MockProver: Look up permutations from correct column types 2021-04-09 13:23:07 +12:00
Daira Hopwood d93a97a56a
Merge pull request #233 from daira/book-permutation
Improvements to permutation argument section and terminology
2021-03-30 12:49:00 +01:00
therealyingtong d7b88addd9 [book] Point compression background section 2021-03-30 04:29:35 +08:00
therealyingtong c3c80cd0a1 [book] Point addition background section 2021-03-29 23:08:56 +08:00
Daira Hopwood 532e5eb11c Fixed columns are not necessarily selector columns.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:14:38 +00:00
Daira Hopwood 25616616e3 "Copy constraints" -> "equality constraints". (There were no other uses of this terminology.)
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:14:12 +00:00
Daira Hopwood 2f34318510 Fix mistaken use of "extended domain" in the permutation argument section, and improve wording.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:13:11 +00:00
Daira Hopwood 8fbf20beae The algorithm for constructing the permutation needs to update the sizes array when merging cycles.
Thanks to @porcuquine for spotting this. (The implementation is correct.)

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:06:09 +00:00
str4d b079624ea7
Merge pull request #228 from zcash/pasta_curves-crate
Migrate to the pasta_curves crate
2021-03-07 08:42:44 +13:00
str4d eb97241e47
Merge pull request #229 from zcash/remove-metrics
Remove metrics crate and inline modelling
2021-03-05 11:52:47 +13:00
Jack Grigg 3a85f2269f Pin a specific pasta_curves revision 2021-03-04 22:45:11 +00:00
str4d cb5769e229
Merge pull request #216 from honeywest/fix-cargo
add rust toolchain file
2021-03-05 03:29:55 +13:00
str4d 655df84682
Merge pull request #217 from honeywest/fix-cargo-rep
fix cargo repository error
2021-03-05 03:28:21 +13:00
Jack Grigg a130edaade Remove metrics crate and inline modelling
It is causing problems in (some) downstream crates, and we won't want
these annotations in the codebase anyway if a downstream crate is
collecting metrics. We'll be replacing this with the cost model binary
in https://github.com/zcash/halo2/pull/225 shortly.
2021-03-03 23:13:34 +00:00
Jack Grigg 7774dd8235 Migrate to the pasta_curves crate 2021-03-03 18:48:45 +00:00
ebfull ec38a06fbf
Merge pull request #226 from zcash/fix-curve-random
Fix Group::random implementation for Pallas and Vesta
2021-03-02 15:17:26 -07:00
str4d 5e05845936
Remove unnecessary identity check from Group::random impl
Co-authored-by: ebfull <ewillbefull@gmail.com>
2021-03-03 11:11:13 +13:00
Jack Grigg 62e50ae6bd Fix Group::random implementation for Pallas and Vesta
Also removes the broken CurveAffine::from_bytes_wide and unused
CurveAffine::to_bytes_wide methods.
2021-03-02 21:29:59 +00:00
ebfull 8122ef3d5d
Merge pull request #223 from zcash/cofactor-group
impl group::cofactor::CofactorGroup for Pallas and Vesta
2021-03-02 08:32:28 -07:00
Jack Grigg 0a4db20d82 impl group::cofactor::CofactorGroup for Pallas and Vesta
Prime-order groups can be treated as a group with a cofactor of 1,
allowing them to be used in cofactor-aware protocols like RedDSA.
2021-03-01 20:27:34 +00:00
str4d 63083e418c
Merge pull request #218 from zcash/minor-cleanups
Minor cleanups
2021-02-27 07:00:59 +13:00
Sean Bowe 504203654d
Disable clippy::{many_single_char_names,op_ref} lint in integration test. 2021-02-26 10:42:43 -07:00
Sean Bowe cb59a40ff8
Move PLONK integration tests into the tests subdirectory. 2021-02-26 08:22:19 -07:00
Sean Bowe ef86a936ff
Remove print statements from tests. 2021-02-26 08:22:13 -07:00
Sean Bowe d92b1c4fb9
Relocate computation of the degree of the constraint system to the ConstraintSystem struct. 2021-02-26 08:22:05 -07:00
honeywest af84f60946 fix cargo repository error 2021-02-26 18:23:55 +08:00