zec
/
halo2
mirror of https://github.com/zcash/halo2.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
2,483 Commits 40 Branches 6 Tags 59 MiB
Commit Graph

142 Commits

Author SHA1 Message Date
Carlos Pérez b04cfa80de
Merge 580d982a64 into 7df93fd855 2024-03-01 11:27:10 -07:00
zhiqiangxu 2185856f26 fix typo 2023-05-05 15:51:10 +08:00
therealyingtong 72ce521084 circuit.rs: crate visibility modifications from code review 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: ebfull <ewillbefull@gmail.com>
 2023-04-04 09:32:08 +07:00
therealyingtong c3c57c6e07 circuit::table_layouter: Better table errors 2023-04-04 09:32:08 +07:00
therealyingtong 3f4710892a plonk::Error: Introduce TableError variant 2023-04-04 09:32:08 +07:00
therealyingtong 327b47524c table_layouter::compute_table_lengths: Extract helper function 2023-04-04 09:32:08 +07:00
therealyingtong a8aebdb848 [move-only] circuit::table_layouter: Move TableLayouter, SimpleTableLayouter 2023-04-04 09:32:08 +07:00
Sean Bowe 82dd2fb3f5 Make `Error` a non_exhaustive type. 2023-03-21 15:17:22 -06:00
ebfull cae65c4b60
Merge pull request #741 from zcash/738-tracing-floor-planner 
Create a `TracingFloorPlanner` for debugging purposes
 2023-03-21 14:48:15 -06:00
therealyingtong 0e5c7a1bd5 dev::cost: Handle circuits with zero permutation_chunks() 2023-03-20 15:35:42 +07:00
therealyingtong 95ce948cf9 dev::cost: Minimal failing example for circuit without permutation 2023-03-20 15:23:52 +07:00
Jack Grigg f6f7a4ba3d Add documentation and example to `TracingFloorPlanner` 2023-03-14 19:34:29 +00:00
Jack Grigg 7d4aafe3f6 Add debug `tracing` spans and events to `TracingFloorPlanner` 2023-03-14 19:34:29 +00:00
Daira Hopwood ab1cae34e1
Apply suggestions from code review (changelog and comments only) 
Co-authored-by: Greg Pfeil <greg@technomadic.org>
 2023-03-11 00:21:03 +00:00
Daira Hopwood 8231d8ffab Fix a nondeterminism bug: we were depending on sort order. 
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2023-03-10 22:03:05 +00:00
Jack Grigg 0eb65d4927 Add a `TracingFloorPlanner` that does nothing 
As currently implemented, all this does is transparently wrap another
`FloorPlanner`, in order to transparently wrap every other circuit type
that passes through it.
 2023-02-28 14:53:31 +00:00
Jack Grigg ca3dacffdb halo2_proofs: Add `Region::instance_value` 
Closes zcash/halo2#740.
 2023-02-28 14:52:36 +00:00
CPerezz 580d982a64
chore: Update `k` to be obtained from struct 2023-02-28 09:20:23 +01:00
CPerezz a4cc9f60e0
fix: Upstream concurrent poly generation fixes 2023-02-28 09:13:15 +01:00
CPerezz e49cf60f59
fix: Split RngCore and SeedableRng imports 2023-02-27 16:39:02 +01:00
CPerezz 36899251cc
chore: Speed up random poly generation 
As noted in
https://github.com/privacy-scaling-explorations/halo2/issues/151 the
generation of a random poly for degrees bigger than 20 starts to get
quite slow.

This PR tries to include some minimal changes in the `commit` fn so that
we upstream the improvements achieved in PSE/halo2
 2023-02-27 16:24:30 +01:00
Jack Grigg b60e9a4eb6 Explicitly fail if `multicore` is enabled for wasm32 without atomics 
`maybe-rayon` has this case fall back to not using rayon, which while
correct is potentially confusingly non-performant. Developers building
for WASM will have similar things they need to handle themselves; they
can conditionally enable `multicore` there.
 2023-02-14 19:06:18 +00:00
str4d 5ff0e83616 Take accumulator as `T` in `halo2_proofs::multicore::TryFoldAndReduce` 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2023-02-14 18:53:36 +00:00
str4d b90522797e Fix formatting of `halo2_proofs::multicore` comments 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2023-02-14 18:53:36 +00:00
wangyao 36055ab47d add comment explaining the type of try_fold_and_reduce 2023-02-14 18:53:36 +00:00
wangyao 6fbde15d11 Add `multicore` feature flag to allow `rayon` to be disabled 
Closes zcash/halo2#648.

Co-authored-by: Jack Grigg <jack@electriccoin.co>
 2023-02-14 18:53:36 +00:00
therealyingtong 41c87eac0f Restrict query_fixed to current Rotation. 
query_fixed no longer takes a Rotation argument and can only be
used to query the current rotation.
 2022-12-09 16:47:19 +08:00
therealyingtong 153a08c755 query_any: panic if query_fixed is called with non-cur Rotation. 2022-12-09 16:47:14 +08:00
Jack Grigg cb819e47e9 Migrate to `ff` revision without `FieldExt` 2022-11-30 19:35:26 +00:00
Daira Hopwood 23f63a8f50 Fix nightly clippy complaints. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-11-30 15:13:55 +00:00
Daira Hopwood c387aa7204 Fix additional beta clippy complaints. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-11-30 15:13:55 +00:00
Kris Nuttycombe b3f7db16f8 Fix beta clippy complaints. 2022-11-30 14:57:15 +00:00
str4d 455ee88b96
Merge pull request #687 from naure/optim/linear-multiopen 
Optimize multiopen verifier for many columns
 2022-11-30 07:25:56 +00:00
Jack Grigg 3e6df2b1de halo2_proofs: Replace `pasta_curves::arithmetic::Group` with new blanket trait 2022-11-30 03:41:45 +00:00
Jack Grigg 49b2324f0a Replace unnecessary dependencies on `FieldExt` trait 2022-11-30 03:41:19 +00:00
Daira Hopwood b097f098ae
Merge pull request #685 from zcash/zero-area-region 
[MockProver] failure::FailureLocation: Handle zero-area regions.
 2022-11-29 19:26:12 +00:00
Jack Grigg 93af730c6c Simplify `EvaluationDomain` to only accept field elements 
We do not use `EvaluationDomain` with group elements, so there is no
need to directly use the FFT `Group` abstraction trait here.
 2022-11-24 01:59:08 +00:00
Aurélien Nicolas f99799f69d optim/linear-multiopen: remove tmp benchmark code 2022-10-27 16:27:24 +02:00
Aurélien Nicolas 6986d0ceef optim/linear-multiopen: remove Horner's rule on MSM 2022-10-26 12:10:47 +02:00
Aurélien Nicolas 54f1e34d21 optim/linear-multiopen: measure 2022-10-26 11:45:38 +02:00
therealyingtong 41c28ae6b2 failure::FailureLocation: Handle zero-area regions. 2022-10-20 17:44:24 -07:00
Daira Hopwood ccfe3e8ccd
Merge pull request #671 from zcash/refactor-lookup 
`lookup::prover`: Compress expressions and cosets in `commit_permuted`
 2022-10-08 13:29:44 +01:00
Daira Hopwood def465de33
Merge pull request #658 from nalinbhardwaj/add-row-count 
[MockProver] Add row and col count to cost model
 2022-10-08 12:25:20 +01:00
therealyingtong c443665224 lookup::prover: Compress expressions and cosets in commit_permuted 
The theta challenge is used in the lookup argument to compress the
input and table expressions. This can be done fully in the
commit_permuted step, after which the original uncompressed
expressions are no longer needed.

Author: Ying Tong Lai <yingtong@z.cash>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-10-08 12:07:54 +01:00
Daira Hopwood 6c1f78d39e clippy fixes and cargo fmt. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-10-08 11:52:25 +01:00
Daira Hopwood 0f7299c116
Merge pull request #625 from zcash/region-query-instance 
halo2_proofs: Introduce `RegionLayouter::instance_value` method.
 2022-10-08 11:18:46 +01:00
Daira Hopwood de76fd48fc
Merge pull request #622 from zcash/patch-mockprover-query_instance 
[MockProver] Check for instance values in gate queries.
 2022-10-08 11:15:06 +01:00
ying tong 4d970865cb
[doc] commitment::verifier: verify_proof does not have [-c]G term 2022-10-05 17:57:48 -07:00
Daira Hopwood 6f692c0e53 There is no z' in the lookup argument, only z. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-09-26 20:14:08 +08:00
Nalin Bhardwaj fad6201b34 Merge layouter used by cost and graph into one 2022-09-16 16:27:51 +05:30