mirror of https://github.com/zcash/halo2.git
1943 lines
70 KiB
Rust
1943 lines
70 KiB
Rust
//! Tools for developing circuits.
|
|
|
|
use std::collections::HashMap;
|
|
use std::collections::HashSet;
|
|
use std::iter;
|
|
use std::ops::{Add, Mul, Neg, Range};
|
|
|
|
use ff::Field;
|
|
|
|
use crate::plonk::Assigned;
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
use crate::plonk::{DynamicTable, TableTag};
|
|
use crate::{
|
|
circuit,
|
|
plonk::{
|
|
permutation, Advice, Any, Assignment, Circuit, Column, ConstraintSystem, Error, Expression,
|
|
Fixed, FloorPlanner, Instance, Selector,
|
|
},
|
|
};
|
|
|
|
pub mod metadata;
|
|
mod util;
|
|
|
|
mod failure;
|
|
pub use failure::{FailureLocation, VerifyFailure};
|
|
|
|
pub mod cost;
|
|
pub use cost::CircuitCost;
|
|
|
|
mod gates;
|
|
pub use gates::CircuitGates;
|
|
|
|
mod tfp;
|
|
pub use tfp::TracingFloorPlanner;
|
|
|
|
#[cfg(feature = "dev-graph")]
|
|
mod graph;
|
|
|
|
#[cfg(feature = "dev-graph")]
|
|
#[cfg_attr(docsrs, doc(cfg(feature = "dev-graph")))]
|
|
pub use graph::{circuit_dot_graph, layout::CircuitLayout};
|
|
|
|
#[derive(Debug)]
|
|
struct Region {
|
|
/// The name of the region. Not required to be unique.
|
|
name: String,
|
|
/// The columns involved in this region.
|
|
columns: HashSet<Column<Any>>,
|
|
/// The rows that this region starts and ends on, if known.
|
|
rows: Option<(usize, usize)>,
|
|
/// The selectors that have been enabled in this region. All other selectors are by
|
|
/// construction not enabled.
|
|
enabled_selectors: HashMap<Selector, Vec<usize>>,
|
|
/// The cells assigned in this region. We store this as a `Vec` so that if any cells
|
|
/// are double-assigned, they will be visibly darker.
|
|
cells: Vec<(Column<Any>, usize)>,
|
|
}
|
|
|
|
impl Region {
|
|
fn update_extent(&mut self, column: Column<Any>, row: usize) {
|
|
self.columns.insert(column);
|
|
|
|
// The region start is the earliest row assigned to.
|
|
// The region end is the latest row assigned to.
|
|
let (mut start, mut end) = self.rows.unwrap_or((row, row));
|
|
if row < start {
|
|
// The first row assigned was not at start 0 within the region.
|
|
start = row;
|
|
}
|
|
if row > end {
|
|
end = row;
|
|
}
|
|
self.rows = Some((start, end));
|
|
}
|
|
}
|
|
|
|
/// The value of a particular cell within the circuit.
|
|
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
|
|
enum CellValue<F: Field> {
|
|
// An unassigned cell.
|
|
Unassigned,
|
|
// A cell that has been assigned a value.
|
|
Assigned(F),
|
|
// A unique poisoned cell.
|
|
Poison(usize),
|
|
}
|
|
|
|
/// A value within an expression.
|
|
#[derive(Clone, Copy, Debug, PartialEq, Eq, Ord, PartialOrd)]
|
|
enum Value<F: Field> {
|
|
Real(F),
|
|
Poison,
|
|
}
|
|
|
|
impl<F: Field> From<CellValue<F>> for Value<F> {
|
|
fn from(value: CellValue<F>) -> Self {
|
|
match value {
|
|
// Cells that haven't been explicitly assigned to, default to zero.
|
|
CellValue::Unassigned => Value::Real(F::ZERO),
|
|
CellValue::Assigned(v) => Value::Real(v),
|
|
CellValue::Poison(_) => Value::Poison,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<F: Field> Neg for Value<F> {
|
|
type Output = Self;
|
|
|
|
fn neg(self) -> Self::Output {
|
|
match self {
|
|
Value::Real(a) => Value::Real(-a),
|
|
_ => Value::Poison,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<F: Field> Add for Value<F> {
|
|
type Output = Self;
|
|
|
|
fn add(self, rhs: Self) -> Self::Output {
|
|
match (self, rhs) {
|
|
(Value::Real(a), Value::Real(b)) => Value::Real(a + b),
|
|
_ => Value::Poison,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<F: Field> Mul for Value<F> {
|
|
type Output = Self;
|
|
|
|
fn mul(self, rhs: Self) -> Self::Output {
|
|
match (self, rhs) {
|
|
(Value::Real(a), Value::Real(b)) => Value::Real(a * b),
|
|
// If poison is multiplied by zero, then we treat the poison as unconstrained
|
|
// and we don't propagate it.
|
|
(Value::Real(x), Value::Poison) | (Value::Poison, Value::Real(x))
|
|
if x.is_zero_vartime() =>
|
|
{
|
|
Value::Real(F::ZERO)
|
|
}
|
|
_ => Value::Poison,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<F: Field> Mul<F> for Value<F> {
|
|
type Output = Self;
|
|
|
|
fn mul(self, rhs: F) -> Self::Output {
|
|
match self {
|
|
Value::Real(lhs) => Value::Real(lhs * rhs),
|
|
// If poison is multiplied by zero, then we treat the poison as unconstrained
|
|
// and we don't propagate it.
|
|
Value::Poison if rhs.is_zero_vartime() => Value::Real(F::ZERO),
|
|
_ => Value::Poison,
|
|
}
|
|
}
|
|
}
|
|
|
|
/// A test prover for debugging circuits.
|
|
///
|
|
/// The normal proving process, when applied to a buggy circuit implementation, might
|
|
/// return proofs that do not validate when they should, but it can't indicate anything
|
|
/// other than "something is invalid". `MockProver` can be used to figure out _why_ these
|
|
/// are invalid: it stores all the private inputs along with the circuit internals, and
|
|
/// then checks every constraint manually.
|
|
///
|
|
/// # Examples
|
|
///
|
|
/// ```
|
|
/// use group::ff::PrimeField;
|
|
/// use halo2_proofs::{
|
|
/// circuit::{Layouter, SimpleFloorPlanner, Value},
|
|
/// dev::{FailureLocation, MockProver, VerifyFailure},
|
|
/// pasta::Fp,
|
|
/// plonk::{Advice, Any, Circuit, Column, ConstraintSystem, Error, Selector},
|
|
/// poly::Rotation,
|
|
/// };
|
|
/// const K: u32 = 5;
|
|
///
|
|
/// #[derive(Copy, Clone)]
|
|
/// struct MyConfig {
|
|
/// a: Column<Advice>,
|
|
/// b: Column<Advice>,
|
|
/// c: Column<Advice>,
|
|
/// s: Selector,
|
|
/// }
|
|
///
|
|
/// #[derive(Clone, Default)]
|
|
/// struct MyCircuit {
|
|
/// a: Value<u64>,
|
|
/// b: Value<u64>,
|
|
/// }
|
|
///
|
|
/// impl<F: PrimeField> Circuit<F> for MyCircuit {
|
|
/// type Config = MyConfig;
|
|
/// type FloorPlanner = SimpleFloorPlanner;
|
|
///
|
|
/// fn without_witnesses(&self) -> Self {
|
|
/// Self::default()
|
|
/// }
|
|
///
|
|
/// fn configure(meta: &mut ConstraintSystem<F>) -> MyConfig {
|
|
/// let a = meta.advice_column();
|
|
/// let b = meta.advice_column();
|
|
/// let c = meta.advice_column();
|
|
/// let s = meta.selector();
|
|
///
|
|
/// meta.create_gate("R1CS constraint", |meta| {
|
|
/// let a = meta.query_advice(a, Rotation::cur());
|
|
/// let b = meta.query_advice(b, Rotation::cur());
|
|
/// let c = meta.query_advice(c, Rotation::cur());
|
|
/// let s = meta.query_selector(s);
|
|
///
|
|
/// // BUG: Should be a * b - c
|
|
/// Some(("buggy R1CS", s * (a * b + c)))
|
|
/// });
|
|
///
|
|
/// MyConfig { a, b, c, s }
|
|
/// }
|
|
///
|
|
/// fn synthesize(&self, config: MyConfig, mut layouter: impl Layouter<F>) -> Result<(), Error> {
|
|
/// layouter.assign_region(|| "Example region", |mut region| {
|
|
/// config.s.enable(&mut region, 0)?;
|
|
/// region.assign_advice(|| "a", config.a, 0, || {
|
|
/// self.a.map(F::from)
|
|
/// })?;
|
|
/// region.assign_advice(|| "b", config.b, 0, || {
|
|
/// self.b.map(F::from)
|
|
/// })?;
|
|
/// region.assign_advice(|| "c", config.c, 0, || {
|
|
/// (self.a * self.b).map(F::from)
|
|
/// })?;
|
|
/// Ok(())
|
|
/// })
|
|
/// }
|
|
/// }
|
|
///
|
|
/// // Assemble the private inputs to the circuit.
|
|
/// let circuit = MyCircuit {
|
|
/// a: Value::known(2),
|
|
/// b: Value::known(4),
|
|
/// };
|
|
///
|
|
/// // This circuit has no public inputs.
|
|
/// let instance = vec![];
|
|
///
|
|
/// let prover = MockProver::<Fp>::run(K, &circuit, instance).unwrap();
|
|
/// assert_eq!(
|
|
/// prover.verify(),
|
|
/// Err(vec![VerifyFailure::ConstraintNotSatisfied {
|
|
/// constraint: ((0, "R1CS constraint").into(), 0, "buggy R1CS").into(),
|
|
/// location: FailureLocation::InRegion {
|
|
/// region: (0, "Example region").into(),
|
|
/// offset: 0,
|
|
/// },
|
|
/// cell_values: vec![
|
|
/// (((Any::Advice, 0).into(), 0).into(), "0x2".to_string()),
|
|
/// (((Any::Advice, 1).into(), 0).into(), "0x4".to_string()),
|
|
/// (((Any::Advice, 2).into(), 0).into(), "0x8".to_string()),
|
|
/// ],
|
|
/// }])
|
|
/// );
|
|
///
|
|
/// // If we provide a too-small K, we get an error.
|
|
/// assert!(matches!(
|
|
/// MockProver::<Fp>::run(2, &circuit, vec![]).unwrap_err(),
|
|
/// Error::NotEnoughRowsAvailable {
|
|
/// current_k,
|
|
/// } if current_k == 2,
|
|
/// ));
|
|
/// ```
|
|
#[derive(Debug)]
|
|
pub struct MockProver<F: Field> {
|
|
k: u32,
|
|
n: u32,
|
|
cs: ConstraintSystem<F>,
|
|
|
|
/// The regions in the circuit.
|
|
regions: Vec<Region>,
|
|
/// The current region being assigned to. Will be `None` after the circuit has been
|
|
/// synthesized.
|
|
current_region: Option<Region>,
|
|
|
|
// The fixed cells in the circuit, arranged as [column][row].
|
|
fixed: Vec<Vec<CellValue<F>>>,
|
|
// The advice cells in the circuit, arranged as [column][row].
|
|
advice: Vec<Vec<CellValue<F>>>,
|
|
// The instance cells in the circuit, arranged as [column][row].
|
|
instance: Vec<Vec<InstanceValue<F>>>,
|
|
|
|
selectors: Vec<Vec<bool>>,
|
|
/// A map between DynamicTable.index, and rows included.
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
dynamic_tables: Vec<Vec<bool>>,
|
|
|
|
permutation: permutation::keygen::Assembly,
|
|
|
|
// A range of available rows for assignment and copies.
|
|
usable_rows: Range<usize>,
|
|
}
|
|
|
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
|
enum InstanceValue<F: Field> {
|
|
Assigned(F),
|
|
Padding,
|
|
}
|
|
|
|
impl<F: Field> InstanceValue<F> {
|
|
fn value(&self) -> F {
|
|
match self {
|
|
InstanceValue::Assigned(v) => *v,
|
|
InstanceValue::Padding => F::ZERO,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<F: Field> Assignment<F> for MockProver<F> {
|
|
fn enter_region<NR, N>(&mut self, name: N)
|
|
where
|
|
NR: Into<String>,
|
|
N: FnOnce() -> NR,
|
|
{
|
|
assert!(self.current_region.is_none());
|
|
self.current_region = Some(Region {
|
|
name: name().into(),
|
|
columns: HashSet::default(),
|
|
rows: None,
|
|
enabled_selectors: HashMap::default(),
|
|
cells: vec![],
|
|
});
|
|
}
|
|
|
|
fn exit_region(&mut self) {
|
|
self.regions.push(self.current_region.take().unwrap());
|
|
}
|
|
|
|
fn enable_selector<A, AR>(&mut self, _: A, selector: &Selector, row: usize) -> Result<(), Error>
|
|
where
|
|
A: FnOnce() -> AR,
|
|
AR: Into<String>,
|
|
{
|
|
if !self.usable_rows.contains(&row) {
|
|
return Err(Error::not_enough_rows_available(self.k));
|
|
}
|
|
|
|
// Track that this selector was enabled. We require that all selectors are enabled
|
|
// inside some region (i.e. no floating selectors).
|
|
self.current_region
|
|
.as_mut()
|
|
.unwrap()
|
|
.enabled_selectors
|
|
.entry(*selector)
|
|
.or_default()
|
|
.push(row);
|
|
|
|
self.selectors[selector.0][row] = true;
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
fn add_to_lookup(&mut self, table: TableTag, row: usize) -> Result<(), Error> {
|
|
self.dynamic_tables[table.0][row] = true;
|
|
|
|
if let Some(region) = self.current_region.as_mut() {
|
|
for column in self.cs.dynamic_tables[table.0].columns.iter() {
|
|
region.update_extent(*column, row);
|
|
}
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn query_instance(
|
|
&self,
|
|
column: Column<Instance>,
|
|
row: usize,
|
|
) -> Result<circuit::Value<F>, Error> {
|
|
if !self.usable_rows.contains(&row) {
|
|
return Err(Error::not_enough_rows_available(self.k));
|
|
}
|
|
|
|
self.instance
|
|
.get(column.index())
|
|
.and_then(|column| column.get(row))
|
|
.map(|v| circuit::Value::known(v.value()))
|
|
.ok_or(Error::BoundsFailure)
|
|
}
|
|
|
|
fn assign_advice<V, VR, A, AR>(
|
|
&mut self,
|
|
_: A,
|
|
column: Column<Advice>,
|
|
row: usize,
|
|
to: V,
|
|
) -> Result<(), Error>
|
|
where
|
|
V: FnOnce() -> circuit::Value<VR>,
|
|
VR: Into<Assigned<F>>,
|
|
A: FnOnce() -> AR,
|
|
AR: Into<String>,
|
|
{
|
|
if !self.usable_rows.contains(&row) {
|
|
return Err(Error::not_enough_rows_available(self.k));
|
|
}
|
|
|
|
if let Some(region) = self.current_region.as_mut() {
|
|
region.update_extent(column.into(), row);
|
|
region.cells.push((column.into(), row));
|
|
}
|
|
|
|
*self
|
|
.advice
|
|
.get_mut(column.index())
|
|
.and_then(|v| v.get_mut(row))
|
|
.ok_or(Error::BoundsFailure)? =
|
|
CellValue::Assigned(to().into_field().evaluate().assign()?);
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn assign_fixed<V, VR, A, AR>(
|
|
&mut self,
|
|
_: A,
|
|
column: Column<Fixed>,
|
|
row: usize,
|
|
to: V,
|
|
) -> Result<(), Error>
|
|
where
|
|
V: FnOnce() -> circuit::Value<VR>,
|
|
VR: Into<Assigned<F>>,
|
|
A: FnOnce() -> AR,
|
|
AR: Into<String>,
|
|
{
|
|
if !self.usable_rows.contains(&row) {
|
|
return Err(Error::not_enough_rows_available(self.k));
|
|
}
|
|
|
|
if let Some(region) = self.current_region.as_mut() {
|
|
region.update_extent(column.into(), row);
|
|
region.cells.push((column.into(), row));
|
|
}
|
|
|
|
*self
|
|
.fixed
|
|
.get_mut(column.index())
|
|
.and_then(|v| v.get_mut(row))
|
|
.ok_or(Error::BoundsFailure)? =
|
|
CellValue::Assigned(to().into_field().evaluate().assign()?);
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn copy(
|
|
&mut self,
|
|
left_column: Column<Any>,
|
|
left_row: usize,
|
|
right_column: Column<Any>,
|
|
right_row: usize,
|
|
) -> Result<(), crate::plonk::Error> {
|
|
if !self.usable_rows.contains(&left_row) || !self.usable_rows.contains(&right_row) {
|
|
return Err(Error::not_enough_rows_available(self.k));
|
|
}
|
|
|
|
self.permutation
|
|
.copy(left_column, left_row, right_column, right_row)
|
|
}
|
|
|
|
fn fill_from_row(
|
|
&mut self,
|
|
col: Column<Fixed>,
|
|
from_row: usize,
|
|
to: circuit::Value<Assigned<F>>,
|
|
) -> Result<(), Error> {
|
|
if !self.usable_rows.contains(&from_row) {
|
|
return Err(Error::not_enough_rows_available(self.k));
|
|
}
|
|
|
|
for row in self.usable_rows.clone().skip(from_row) {
|
|
self.assign_fixed(|| "", col, row, || to)?;
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn push_namespace<NR, N>(&mut self, _: N)
|
|
where
|
|
NR: Into<String>,
|
|
N: FnOnce() -> NR,
|
|
{
|
|
// TODO: Do something with namespaces :)
|
|
}
|
|
|
|
fn pop_namespace(&mut self, _: Option<String>) {
|
|
// TODO: Do something with namespaces :)
|
|
}
|
|
}
|
|
|
|
impl<F: Field + Ord + From<u64>> MockProver<F> {
|
|
/// Runs a synthetic keygen-and-prove operation on the given circuit, collecting data
|
|
/// about the constraints and their assignments.
|
|
pub fn run<ConcreteCircuit: Circuit<F>>(
|
|
k: u32,
|
|
circuit: &ConcreteCircuit,
|
|
instance: Vec<Vec<F>>,
|
|
) -> Result<Self, Error> {
|
|
let n = 1 << k;
|
|
|
|
let mut cs = ConstraintSystem::default();
|
|
let config = ConcreteCircuit::configure(&mut cs);
|
|
let cs = cs;
|
|
|
|
if n < cs.minimum_rows() {
|
|
return Err(Error::not_enough_rows_available(k));
|
|
}
|
|
|
|
if instance.len() != cs.num_instance_columns {
|
|
return Err(Error::InvalidInstances);
|
|
}
|
|
|
|
let instance = instance
|
|
.into_iter()
|
|
.map(|instance| {
|
|
if instance.len() > n - (cs.blinding_factors() + 1) {
|
|
return Err(Error::InstanceTooLarge);
|
|
}
|
|
|
|
let mut instance_values = vec![InstanceValue::Padding; n];
|
|
for (idx, value) in instance.into_iter().enumerate() {
|
|
instance_values[idx] = InstanceValue::Assigned(value);
|
|
}
|
|
|
|
Ok(instance_values)
|
|
})
|
|
.collect::<Result<Vec<_>, _>>()?;
|
|
|
|
// Fixed columns contain no blinding factors.
|
|
let fixed = vec![vec![CellValue::Unassigned; n]; cs.num_fixed_columns];
|
|
let selectors = vec![vec![false; n]; cs.num_selectors];
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
let dynamic_tables = vec![vec![false; n]; cs.dynamic_tables.len()];
|
|
// Advice columns contain blinding factors.
|
|
let blinding_factors = cs.blinding_factors();
|
|
let usable_rows = n - (blinding_factors + 1);
|
|
let advice = vec![
|
|
{
|
|
let mut column = vec![CellValue::Unassigned; n];
|
|
// Poison unusable rows.
|
|
for (i, cell) in column.iter_mut().enumerate().skip(usable_rows) {
|
|
*cell = CellValue::Poison(i);
|
|
}
|
|
column
|
|
};
|
|
cs.num_advice_columns
|
|
];
|
|
let permutation = permutation::keygen::Assembly::new(n, &cs.permutation);
|
|
let constants = cs.constants.clone();
|
|
|
|
let mut prover = MockProver {
|
|
k,
|
|
n: n as u32,
|
|
cs,
|
|
regions: vec![],
|
|
current_region: None,
|
|
fixed,
|
|
advice,
|
|
instance,
|
|
selectors,
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
dynamic_tables,
|
|
permutation,
|
|
usable_rows: 0..usable_rows,
|
|
};
|
|
|
|
ConcreteCircuit::FloorPlanner::synthesize(&mut prover, circuit, config, constants)?;
|
|
|
|
let (cs, selector_polys) = prover.cs.compress_selectors(prover.selectors.clone());
|
|
prover.cs = cs;
|
|
prover.fixed.extend(selector_polys.into_iter().map(|poly| {
|
|
let mut v = vec![CellValue::Unassigned; n];
|
|
for (v, p) in v.iter_mut().zip(&poly[..]) {
|
|
*v = CellValue::Assigned(*p);
|
|
}
|
|
v
|
|
}));
|
|
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
{
|
|
let (cs, tag_polys) = prover
|
|
.cs
|
|
.compress_dynamic_table_tags(prover.dynamic_tables.clone());
|
|
prover.cs = cs;
|
|
prover.fixed.extend(tag_polys.into_iter().map(|poly| {
|
|
let mut v = vec![CellValue::Unassigned; n];
|
|
for (v, p) in v.iter_mut().zip(&poly[..]) {
|
|
*v = CellValue::Assigned(*p);
|
|
}
|
|
v
|
|
}));
|
|
}
|
|
|
|
Ok(prover)
|
|
}
|
|
|
|
/// Returns `Ok(())` if this `MockProver` is satisfied, or a list of errors indicating
|
|
/// the reasons that the circuit is not satisfied.
|
|
pub fn verify(&self) -> Result<(), Vec<VerifyFailure>> {
|
|
let n = self.n as i32;
|
|
|
|
// Check that within each region, all cells used in instantiated gates have been
|
|
// assigned to.
|
|
let selector_errors = self.regions.iter().enumerate().flat_map(|(r_i, r)| {
|
|
r.enabled_selectors.iter().flat_map(move |(selector, at)| {
|
|
// Find the gates enabled by this selector
|
|
self.cs
|
|
.gates
|
|
.iter()
|
|
// Assume that if a queried selector is enabled, the user wants to use the
|
|
// corresponding gate in some way.
|
|
//
|
|
// TODO: This will trip up on the reverse case, where leaving a selector
|
|
// un-enabled keeps a gate enabled. We could alternatively require that
|
|
// every selector is explicitly enabled or disabled on every row? But that
|
|
// seems messy and confusing.
|
|
.enumerate()
|
|
.filter(move |(_, g)| g.queried_selectors().contains(selector))
|
|
.flat_map(move |(gate_index, gate)| {
|
|
at.iter().flat_map(move |selector_row| {
|
|
// Selectors are queried with no rotation.
|
|
let gate_row = *selector_row as i32;
|
|
|
|
gate.queried_cells().iter().filter_map(move |cell| {
|
|
// Determine where this cell should have been assigned.
|
|
let cell_row = ((gate_row + n + cell.rotation.0) % n) as usize;
|
|
|
|
match cell.column.column_type() {
|
|
Any::Instance => {
|
|
// Handle instance cells, which are not in the region.
|
|
let instance_value =
|
|
&self.instance[cell.column.index()][cell_row];
|
|
match instance_value {
|
|
InstanceValue::Assigned(_) => None,
|
|
_ => Some(VerifyFailure::InstanceCellNotAssigned {
|
|
gate: (gate_index, gate.name()).into(),
|
|
region: (r_i, r.name.clone()).into(),
|
|
gate_offset: *selector_row,
|
|
column: cell.column.try_into().unwrap(),
|
|
row: cell_row,
|
|
}),
|
|
}
|
|
}
|
|
_ => {
|
|
// Check that it was assigned!
|
|
if r.cells.contains(&(cell.column, cell_row)) {
|
|
None
|
|
} else {
|
|
Some(VerifyFailure::CellNotAssigned {
|
|
gate: (gate_index, gate.name()).into(),
|
|
region: (r_i, r.name.clone()).into(),
|
|
gate_offset: *selector_row,
|
|
column: cell.column,
|
|
offset: cell_row as isize
|
|
- r.rows.unwrap().0 as isize,
|
|
})
|
|
}
|
|
}
|
|
}
|
|
})
|
|
})
|
|
})
|
|
})
|
|
});
|
|
|
|
// Check that all gates are satisfied for all rows.
|
|
let gate_errors =
|
|
self.cs
|
|
.gates
|
|
.iter()
|
|
.enumerate()
|
|
.flat_map(|(gate_index, gate)| {
|
|
// We iterate from n..2n so we can just reduce to handle wrapping.
|
|
(n..(2 * n)).flat_map(move |row| {
|
|
gate.polynomials().iter().enumerate().filter_map(
|
|
move |(poly_index, poly)| match poly.evaluate(
|
|
&|scalar| Value::Real(scalar),
|
|
&|_| panic!("virtual selectors are removed during optimization"),
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
&|_| panic!("virtual table tags are removed during optimization"),
|
|
&util::load(n, row, &self.cs.fixed_queries, &self.fixed),
|
|
&util::load(n, row, &self.cs.advice_queries, &self.advice),
|
|
&util::load_instance(
|
|
n,
|
|
row,
|
|
&self.cs.instance_queries,
|
|
&self.instance,
|
|
),
|
|
&|a| -a,
|
|
&|a, b| a + b,
|
|
&|a, b| a * b,
|
|
&|a, scalar| a * scalar,
|
|
) {
|
|
Value::Real(x) if x.is_zero_vartime() => None,
|
|
Value::Real(_) => Some(VerifyFailure::ConstraintNotSatisfied {
|
|
constraint: (
|
|
(gate_index, gate.name()).into(),
|
|
poly_index,
|
|
gate.constraint_name(poly_index),
|
|
)
|
|
.into(),
|
|
location: FailureLocation::find_expressions(
|
|
&self.cs,
|
|
&self.regions,
|
|
(row - n) as usize,
|
|
Some(poly).into_iter(),
|
|
),
|
|
cell_values: util::cell_values(
|
|
gate,
|
|
poly,
|
|
&util::load(n, row, &self.cs.fixed_queries, &self.fixed),
|
|
&util::load(n, row, &self.cs.advice_queries, &self.advice),
|
|
&util::load_instance(
|
|
n,
|
|
row,
|
|
&self.cs.instance_queries,
|
|
&self.instance,
|
|
),
|
|
),
|
|
}),
|
|
Value::Poison => Some(VerifyFailure::ConstraintPoisoned {
|
|
constraint: (
|
|
(gate_index, gate.name()).into(),
|
|
poly_index,
|
|
gate.constraint_name(poly_index),
|
|
)
|
|
.into(),
|
|
}),
|
|
},
|
|
)
|
|
})
|
|
});
|
|
|
|
// Check that all lookups exist in their respective tables.
|
|
let lookup_errors =
|
|
self.cs
|
|
.lookups
|
|
.iter()
|
|
.enumerate()
|
|
.flat_map(|(lookup_index, lookup)| {
|
|
let load = |expression: &Expression<F>, row| {
|
|
expression.evaluate(
|
|
&|scalar| Value::Real(scalar),
|
|
&|_| panic!("virtual selectors are removed during optimization"),
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
&|_| panic!("virtual table tags are removed during optimization"),
|
|
&|query| {
|
|
let query = self.cs.fixed_queries[query.index];
|
|
let column_index = query.0.index();
|
|
let rotation = query.1 .0;
|
|
self.fixed[column_index]
|
|
[(row as i32 + n + rotation) as usize % n as usize]
|
|
.into()
|
|
},
|
|
&|query| {
|
|
let query = self.cs.advice_queries[query.index];
|
|
let column_index = query.0.index();
|
|
let rotation = query.1 .0;
|
|
self.advice[column_index]
|
|
[(row as i32 + n + rotation) as usize % n as usize]
|
|
.into()
|
|
},
|
|
&|query| {
|
|
let query = self.cs.instance_queries[query.index];
|
|
let column_index = query.0.index();
|
|
let rotation = query.1 .0;
|
|
Value::Real(
|
|
self.instance[column_index]
|
|
[(row as i32 + n + rotation) as usize % n as usize]
|
|
.value(),
|
|
)
|
|
},
|
|
&|a| -a,
|
|
&|a, b| a + b,
|
|
&|a, b| a * b,
|
|
&|a, scalar| a * scalar,
|
|
)
|
|
};
|
|
|
|
assert!(lookup.table_expressions.len() == lookup.input_expressions.len());
|
|
assert!(self.usable_rows.end > 0);
|
|
|
|
// We optimize on the basis that the table might have been filled so that the last
|
|
// usable row now has the fill contents (it doesn't matter if there was no filling).
|
|
// Note that this "fill row" necessarily exists in the table, and we use that fact to
|
|
// slightly simplify the optimization: we're only trying to check that all input rows
|
|
// are contained in the table, and so we can safely just drop input rows that
|
|
// match the fill row.
|
|
let fill_row: Vec<_> = lookup
|
|
.table_expressions
|
|
.iter()
|
|
.map(move |c| load(c, self.usable_rows.end - 1))
|
|
.collect();
|
|
|
|
// In the real prover, the lookup expressions are never enforced on
|
|
// unusable rows, due to the (1 - (l_last(X) + l_blind(X))) term.
|
|
let mut table: Vec<Vec<_>> = self
|
|
.usable_rows
|
|
.clone()
|
|
.filter_map(|table_row| {
|
|
let t = lookup
|
|
.table_expressions
|
|
.iter()
|
|
.map(move |c| load(c, table_row))
|
|
.collect();
|
|
|
|
if t != fill_row {
|
|
Some(t)
|
|
} else {
|
|
None
|
|
}
|
|
})
|
|
.collect();
|
|
table.sort_unstable();
|
|
|
|
let mut inputs: Vec<(Vec<_>, usize)> = self
|
|
.usable_rows
|
|
.clone()
|
|
.filter_map(|input_row| {
|
|
let t = lookup
|
|
.input_expressions
|
|
.iter()
|
|
.map(move |c| load(c, input_row))
|
|
.collect();
|
|
|
|
if t != fill_row {
|
|
// Also keep track of the original input row, since we're going to sort.
|
|
Some((t, input_row))
|
|
} else {
|
|
None
|
|
}
|
|
})
|
|
.collect();
|
|
inputs.sort_unstable();
|
|
|
|
let mut i = 0;
|
|
inputs
|
|
.iter()
|
|
.filter_map(move |(input, input_row)| {
|
|
while i < table.len() && &table[i] < input {
|
|
i += 1;
|
|
}
|
|
if i == table.len() || &table[i] > input {
|
|
assert!(table.binary_search(input).is_err());
|
|
|
|
Some(VerifyFailure::Lookup {
|
|
lookup_index,
|
|
location: FailureLocation::find_expressions(
|
|
&self.cs,
|
|
&self.regions,
|
|
*input_row,
|
|
lookup.input_expressions.iter(),
|
|
),
|
|
})
|
|
} else {
|
|
None
|
|
}
|
|
})
|
|
.collect::<Vec<_>>()
|
|
});
|
|
|
|
// Check that permutations preserve the original values of the cells.
|
|
let perm_errors = {
|
|
// Original values of columns involved in the permutation.
|
|
let original = |column, row| {
|
|
self.cs
|
|
.permutation
|
|
.get_columns()
|
|
.get(column)
|
|
.map(|c: &Column<Any>| match c.column_type() {
|
|
Any::Advice => self.advice[c.index()][row],
|
|
Any::Fixed => self.fixed[c.index()][row],
|
|
Any::Instance => {
|
|
let cell: &InstanceValue<F> = &self.instance[c.index()][row];
|
|
CellValue::Assigned(cell.value())
|
|
}
|
|
})
|
|
.unwrap()
|
|
};
|
|
|
|
// Iterate over each column of the permutation
|
|
self.permutation
|
|
.mapping
|
|
.iter()
|
|
.enumerate()
|
|
.flat_map(move |(column, values)| {
|
|
// Iterate over each row of the column to check that the cell's
|
|
// value is preserved by the mapping.
|
|
values.iter().enumerate().filter_map(move |(row, cell)| {
|
|
let original_cell = original(column, row);
|
|
let permuted_cell = original(cell.0, cell.1);
|
|
if original_cell == permuted_cell {
|
|
None
|
|
} else {
|
|
let columns = self.cs.permutation.get_columns();
|
|
let column = columns.get(column).unwrap();
|
|
Some(VerifyFailure::Permutation {
|
|
column: (*column).into(),
|
|
location: FailureLocation::find(
|
|
&self.regions,
|
|
row,
|
|
Some(column).into_iter().cloned().collect(),
|
|
),
|
|
})
|
|
}
|
|
})
|
|
})
|
|
};
|
|
|
|
// Check that all cell included in dynamic tables are assigned.
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
let dynamic_table_errors = {
|
|
fn unassigned_error<F: Field>(
|
|
regions: &[Region],
|
|
cell: CellValue<F>,
|
|
dynamic_table: &DynamicTable,
|
|
column: Column<Any>,
|
|
row: usize,
|
|
) -> Option<VerifyFailure> {
|
|
match cell {
|
|
CellValue::Unassigned => {
|
|
if let FailureLocation::InRegion { region, offset } =
|
|
FailureLocation::find(regions, row, iter::once(column).collect())
|
|
{
|
|
Some(VerifyFailure::DynamicTableCellNotAssigned {
|
|
dynamic_table: dynamic_table.clone(),
|
|
region,
|
|
column,
|
|
offset,
|
|
})
|
|
} else {
|
|
panic!("Rows cannot be included in a dynamic table outside of a region")
|
|
}
|
|
}
|
|
CellValue::Assigned(_) => None,
|
|
CellValue::Poison(_) => panic!("A poisoned cell was used in a dynamic table"),
|
|
}
|
|
}
|
|
|
|
self.dynamic_tables
|
|
.iter()
|
|
.enumerate()
|
|
.flat_map(|(table_index, virtual_rows)| {
|
|
self.fixed[self.cs.dynamic_table_tag_map[table_index].index()]
|
|
.iter()
|
|
.zip(virtual_rows)
|
|
.enumerate()
|
|
.filter_map(move |(row, r)| match r {
|
|
(CellValue::Assigned(tag), true) => {
|
|
if F::from(table_index as u64 + 1) == *tag {
|
|
let table = &self.cs.dynamic_tables[table_index];
|
|
Some(table.columns.iter().filter_map(move |col| match col.column_type() {
|
|
Any::Advice => unassigned_error(&self.regions, self. advice[col.index()][row], table, *col, row),
|
|
Any::Fixed => unassigned_error(&self.regions, self.fixed[col.index()][row], table, *col, row),
|
|
Any::Instance => panic!("This should be imposible. Instance columns are not yet supported in dynamic tables"),
|
|
}))
|
|
} else {
|
|
panic!("There was an error in dynamic table tag compression, The wrong tag was found in a row")
|
|
}
|
|
}
|
|
(CellValue::Unassigned, true) => panic!("There was an error in dynamic table tag compression, The tag cell was not assigned."),
|
|
(CellValue::Poison(_), true) => panic!("There was an error in dynamic table tag compression, The tag cell was poisoned."),
|
|
_ => None,
|
|
}).flatten()
|
|
})
|
|
};
|
|
|
|
let errors = iter::empty()
|
|
.chain(selector_errors)
|
|
.chain(gate_errors)
|
|
.chain(lookup_errors)
|
|
.chain(perm_errors);
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
let errors = errors.chain(dynamic_table_errors);
|
|
let mut errors: Vec<_> = errors.collect();
|
|
if errors.is_empty() {
|
|
Ok(())
|
|
} else {
|
|
// Remove any duplicate `ConstraintPoisoned` errors (we check all unavailable
|
|
// rows in case the trigger is row-specific, but the error message only points
|
|
// at the constraint).
|
|
errors.dedup_by(|a, b| match (a, b) {
|
|
(
|
|
a @ VerifyFailure::ConstraintPoisoned { .. },
|
|
b @ VerifyFailure::ConstraintPoisoned { .. },
|
|
) => a == b,
|
|
_ => false,
|
|
});
|
|
Err(errors)
|
|
}
|
|
}
|
|
|
|
/// Panics if the circuit being checked by this `MockProver` is not satisfied.
|
|
///
|
|
/// Any verification failures will be pretty-printed to stderr before the function
|
|
/// panics.
|
|
///
|
|
/// Apart from the stderr output, this method is equivalent to:
|
|
/// ```ignore
|
|
/// assert_eq!(prover.verify(), Ok(()));
|
|
/// ```
|
|
pub fn assert_satisfied(&self) {
|
|
if let Err(errs) = self.verify() {
|
|
for err in errs {
|
|
err.emit(self);
|
|
eprintln!();
|
|
}
|
|
panic!("circuit was not satisfied");
|
|
}
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use group::ff::Field;
|
|
use pasta_curves::{EqAffine, Fp};
|
|
|
|
use super::{FailureLocation, MockProver, VerifyFailure};
|
|
use crate::{
|
|
circuit::{Layouter, SimpleFloorPlanner, Value},
|
|
plonk::{
|
|
Advice, Any, Circuit, Column, ConstraintSystem, Error, Expression, Selector,
|
|
TableColumn,
|
|
},
|
|
poly::Rotation,
|
|
};
|
|
|
|
#[test]
|
|
fn unassigned_cell() {
|
|
const K: u32 = 4;
|
|
|
|
#[derive(Clone)]
|
|
struct FaultyCircuitConfig {
|
|
a: Column<Advice>,
|
|
q: Selector,
|
|
}
|
|
|
|
struct FaultyCircuit {}
|
|
|
|
impl Circuit<Fp> for FaultyCircuit {
|
|
type Config = FaultyCircuitConfig;
|
|
type FloorPlanner = SimpleFloorPlanner;
|
|
|
|
fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
|
|
let a = meta.advice_column();
|
|
let b = meta.advice_column();
|
|
let q = meta.selector();
|
|
|
|
meta.create_gate("Equality check", |cells| {
|
|
let a = cells.query_advice(a, Rotation::prev());
|
|
let b = cells.query_advice(b, Rotation::cur());
|
|
let q = cells.query_selector(q);
|
|
|
|
// If q is enabled, a and b must be assigned to.
|
|
vec![q * (a - b)]
|
|
});
|
|
|
|
FaultyCircuitConfig { a, q }
|
|
}
|
|
|
|
fn without_witnesses(&self) -> Self {
|
|
Self {}
|
|
}
|
|
|
|
fn synthesize(
|
|
&self,
|
|
config: Self::Config,
|
|
mut layouter: impl Layouter<Fp>,
|
|
) -> Result<(), Error> {
|
|
layouter.assign_region(
|
|
|| "Faulty synthesis",
|
|
|mut region| {
|
|
// Enable the equality gate.
|
|
config.q.enable(&mut region, 1)?;
|
|
|
|
// Assign a = 0.
|
|
region.assign_advice(|| "a", config.a, 0, || Value::known(Fp::ZERO))?;
|
|
|
|
// BUG: Forget to assign b = 0! This could go unnoticed during
|
|
// development, because cell values default to zero, which in this
|
|
// case is fine, but for other assignments would be broken.
|
|
Ok(())
|
|
},
|
|
)
|
|
}
|
|
}
|
|
|
|
let prover = MockProver::run(K, &FaultyCircuit {}, vec![]).unwrap();
|
|
assert_eq!(
|
|
prover.verify(),
|
|
Err(vec![VerifyFailure::CellNotAssigned {
|
|
gate: (0, "Equality check").into(),
|
|
region: (0, "Faulty synthesis".to_owned()).into(),
|
|
gate_offset: 1,
|
|
column: Column::new(1, Any::Advice),
|
|
offset: 1,
|
|
}])
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn bad_lookup() {
|
|
const K: u32 = 4;
|
|
|
|
#[derive(Clone)]
|
|
struct FaultyCircuitConfig {
|
|
a: Column<Advice>,
|
|
q: Selector,
|
|
table: TableColumn,
|
|
}
|
|
|
|
struct FaultyCircuit {}
|
|
|
|
impl Circuit<Fp> for FaultyCircuit {
|
|
type Config = FaultyCircuitConfig;
|
|
type FloorPlanner = SimpleFloorPlanner;
|
|
|
|
fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
|
|
let a = meta.advice_column();
|
|
let q = meta.complex_selector();
|
|
let table = meta.lookup_table_column();
|
|
|
|
meta.lookup(|cells| {
|
|
let a = cells.query_advice(a, Rotation::cur());
|
|
let q = cells.query_selector(q);
|
|
|
|
// If q is enabled, a must be in the table.
|
|
// When q is not enabled, lookup the default value instead.
|
|
let not_q = Expression::Constant(Fp::one()) - q.clone();
|
|
let default = Expression::Constant(Fp::from(2));
|
|
vec![(q * a + not_q * default, table)]
|
|
});
|
|
|
|
FaultyCircuitConfig { a, q, table }
|
|
}
|
|
|
|
fn without_witnesses(&self) -> Self {
|
|
Self {}
|
|
}
|
|
|
|
fn synthesize(
|
|
&self,
|
|
config: Self::Config,
|
|
mut layouter: impl Layouter<Fp>,
|
|
) -> Result<(), Error> {
|
|
layouter.assign_table(
|
|
|| "Doubling table",
|
|
|mut table| {
|
|
(1..(1 << (K - 1)))
|
|
.map(|i| {
|
|
table.assign_cell(
|
|
|| format!("table[{}] = {}", i, 2 * i),
|
|
config.table,
|
|
i - 1,
|
|
|| Value::known(Fp::from(2 * i as u64)),
|
|
)
|
|
})
|
|
.fold(Ok(()), |acc, res| acc.and(res))
|
|
},
|
|
)?;
|
|
|
|
layouter.assign_region(
|
|
|| "Good synthesis",
|
|
|mut region| {
|
|
// Enable the lookup on rows 0 and 1.
|
|
config.q.enable(&mut region, 0)?;
|
|
config.q.enable(&mut region, 1)?;
|
|
|
|
// Assign a = 2 and a = 6.
|
|
region.assign_advice(
|
|
|| "a = 2",
|
|
config.a,
|
|
0,
|
|
|| Value::known(Fp::from(2)),
|
|
)?;
|
|
region.assign_advice(
|
|
|| "a = 6",
|
|
config.a,
|
|
1,
|
|
|| Value::known(Fp::from(6)),
|
|
)?;
|
|
|
|
Ok(())
|
|
},
|
|
)?;
|
|
|
|
layouter.assign_region(
|
|
|| "Faulty synthesis",
|
|
|mut region| {
|
|
// Enable the lookup on rows 0 and 1.
|
|
config.q.enable(&mut region, 0)?;
|
|
config.q.enable(&mut region, 1)?;
|
|
|
|
// Assign a = 4.
|
|
region.assign_advice(
|
|
|| "a = 4",
|
|
config.a,
|
|
0,
|
|
|| Value::known(Fp::from(4)),
|
|
)?;
|
|
|
|
// BUG: Assign a = 5, which doesn't exist in the table!
|
|
region.assign_advice(
|
|
|| "a = 5",
|
|
config.a,
|
|
1,
|
|
|| Value::known(Fp::from(5)),
|
|
)?;
|
|
|
|
Ok(())
|
|
},
|
|
)
|
|
}
|
|
}
|
|
|
|
let prover = MockProver::run(K, &FaultyCircuit {}, vec![]).unwrap();
|
|
assert_eq!(
|
|
prover.verify(),
|
|
Err(vec![VerifyFailure::Lookup {
|
|
lookup_index: 0,
|
|
location: FailureLocation::InRegion {
|
|
region: (2, "Faulty synthesis").into(),
|
|
offset: 1,
|
|
}
|
|
}])
|
|
);
|
|
}
|
|
|
|
#[cfg(test)]
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
mod dynamic_lookups {
|
|
use crate::plonk::DynamicTable;
|
|
|
|
use super::*;
|
|
|
|
const K: u32 = 7;
|
|
|
|
#[derive(Clone)]
|
|
struct DynLookupCircuitConfig {
|
|
q: Selector,
|
|
a: Column<Advice>,
|
|
// A table containing table_vals.
|
|
table: DynamicTable,
|
|
}
|
|
|
|
impl DynLookupCircuitConfig {
|
|
fn assign_lookups(
|
|
&self,
|
|
layouter: &mut impl Layouter<Fp>,
|
|
lookup: impl Iterator<Item = usize> + Clone,
|
|
) -> Result<(), Error> {
|
|
layouter.assign_region(
|
|
|| "lookups",
|
|
|mut region| {
|
|
// Enable the lookup on rows
|
|
for (offset, val) in lookup.clone().enumerate() {
|
|
self.q.enable(&mut region, offset)?;
|
|
|
|
region.assign_advice(
|
|
|| "",
|
|
self.a,
|
|
offset,
|
|
|| Value::known(Fp::from(val as u64)),
|
|
)?;
|
|
}
|
|
|
|
Ok(())
|
|
},
|
|
)
|
|
}
|
|
}
|
|
|
|
/// Just like dynamic_lookup, but breaks the table into single row regions.
|
|
/// TODO refactor to remove code duplication
|
|
#[test]
|
|
fn dynamic_lookup_success() {
|
|
struct DynLookupCircuit {}
|
|
impl Circuit<Fp> for DynLookupCircuit {
|
|
type Config = DynLookupCircuitConfig;
|
|
type FloorPlanner = SimpleFloorPlanner;
|
|
|
|
fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
|
|
let a = meta.advice_column();
|
|
let table_vals = meta.advice_column();
|
|
let q = meta.complex_selector();
|
|
let table = meta.create_dynamic_table("table", &[], &[table_vals]);
|
|
|
|
meta.lookup_dynamic(&table, |cells| {
|
|
let a = cells.query_advice(a, Rotation::cur());
|
|
|
|
// If q is enabled, a must be in the table.
|
|
(q, vec![(a, table_vals.into())])
|
|
});
|
|
|
|
DynLookupCircuitConfig { a, q, table }
|
|
}
|
|
|
|
fn without_witnesses(&self) -> Self {
|
|
Self {}
|
|
}
|
|
|
|
fn synthesize(
|
|
&self,
|
|
config: Self::Config,
|
|
mut layouter: impl Layouter<Fp>,
|
|
) -> Result<(), Error> {
|
|
config.assign_lookups(&mut layouter, 0..=5)?;
|
|
let table_vals = config.table.columns()[0];
|
|
|
|
layouter.assign_region(
|
|
|| "table",
|
|
|mut region| {
|
|
for i in 0..=5 {
|
|
region.assign_advice(
|
|
|| "",
|
|
table_vals.try_into().unwrap(),
|
|
i,
|
|
|| Value::known(Fp::from(i as u64)),
|
|
)?;
|
|
region.add_to_lookup(config.table.tag(), i)?;
|
|
}
|
|
Ok(())
|
|
},
|
|
)?;
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
MockProver::run(K, &DynLookupCircuit {}, vec![])
|
|
.unwrap()
|
|
.verify()
|
|
.unwrap()
|
|
}
|
|
|
|
#[test]
|
|
fn dynamic_lookup_multi_region_success() {
|
|
struct DynLookupCircuit {}
|
|
impl Circuit<Fp> for DynLookupCircuit {
|
|
type Config = DynLookupCircuitConfig;
|
|
type FloorPlanner = SimpleFloorPlanner;
|
|
|
|
fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
|
|
let a = meta.advice_column();
|
|
let table_vals = meta.advice_column();
|
|
let q = meta.complex_selector();
|
|
let table = meta.create_dynamic_table("table", &[], &[table_vals]);
|
|
|
|
meta.lookup_dynamic(&table, |cells| {
|
|
let a = cells.query_advice(a, Rotation::cur());
|
|
|
|
// If q is enabled, a must be in the table.
|
|
(q, vec![(a, table_vals.into())])
|
|
});
|
|
|
|
DynLookupCircuitConfig { a, q, table }
|
|
}
|
|
|
|
fn without_witnesses(&self) -> Self {
|
|
Self {}
|
|
}
|
|
|
|
fn synthesize(
|
|
&self,
|
|
config: Self::Config,
|
|
mut layouter: impl Layouter<Fp>,
|
|
) -> Result<(), Error> {
|
|
config.assign_lookups(&mut layouter, 0..=5)?;
|
|
let table_vals = config.table.columns()[0];
|
|
|
|
for i in 0..=5 {
|
|
layouter.assign_region(
|
|
|| format!("table {}", i),
|
|
|mut region| {
|
|
region.assign_advice(
|
|
|| "",
|
|
table_vals.try_into().unwrap(),
|
|
0,
|
|
|| Value::known(Fp::from(i as u64)),
|
|
)?;
|
|
region.add_to_lookup(config.table.tag(), 0)?;
|
|
Ok(())
|
|
},
|
|
)?;
|
|
}
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
MockProver::run(K, &DynLookupCircuit {}, vec![])
|
|
.unwrap()
|
|
.verify()
|
|
.unwrap()
|
|
}
|
|
|
|
#[test]
|
|
fn dynamic_lookup_not_in_table_err() {
|
|
struct DynLookupCircuit {}
|
|
impl Circuit<Fp> for DynLookupCircuit {
|
|
type Config = DynLookupCircuitConfig;
|
|
type FloorPlanner = SimpleFloorPlanner;
|
|
|
|
fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
|
|
let a = meta.advice_column();
|
|
let table_vals = meta.advice_column();
|
|
let q = meta.complex_selector();
|
|
let table = meta.create_dynamic_table("table", &[], &[table_vals]);
|
|
|
|
meta.lookup_dynamic(&table, |cells| {
|
|
let a = cells.query_advice(a, Rotation::cur());
|
|
|
|
// If q is enabled, a must be in the table.
|
|
(q, vec![(a, table_vals.into())])
|
|
});
|
|
|
|
DynLookupCircuitConfig { a, q, table }
|
|
}
|
|
|
|
fn without_witnesses(&self) -> Self {
|
|
Self {}
|
|
}
|
|
|
|
fn synthesize(
|
|
&self,
|
|
config: Self::Config,
|
|
mut layouter: impl Layouter<Fp>,
|
|
) -> Result<(), Error> {
|
|
config.assign_lookups(&mut layouter, 0..=6)?;
|
|
let table_vals = config.table.columns()[0];
|
|
|
|
for i in 0..=5 {
|
|
layouter.assign_region(
|
|
|| format!("table {}", i),
|
|
|mut region| {
|
|
region.assign_advice(
|
|
|| "",
|
|
table_vals.try_into().unwrap(),
|
|
0,
|
|
|| Value::known(Fp::from(i as u64)),
|
|
)?;
|
|
config.table.add_row(&mut region, 0)
|
|
},
|
|
)?;
|
|
}
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
let errs = MockProver::run(K, &DynLookupCircuit {}, vec![])
|
|
.unwrap()
|
|
.verify()
|
|
.expect_err("The table only contains 0..=5, but lookups on 0..=6 succeeded");
|
|
|
|
assert_eq!(
|
|
errs[0],
|
|
VerifyFailure::Lookup {
|
|
lookup_index: 0,
|
|
location: FailureLocation::InRegion {
|
|
region: (0, "lookups").into(),
|
|
offset: 6,
|
|
}
|
|
}
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn dynamic_lookup_no_rows_included() {
|
|
struct DynLookupCircuit {}
|
|
impl Circuit<Fp> for DynLookupCircuit {
|
|
type Config = DynLookupCircuitConfig;
|
|
type FloorPlanner = SimpleFloorPlanner;
|
|
|
|
fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
|
|
let a = meta.advice_column();
|
|
let table_vals = meta.advice_column();
|
|
let q = meta.complex_selector();
|
|
let table = meta.create_dynamic_table("table", &[], &[table_vals]);
|
|
|
|
meta.lookup_dynamic(&table, |cells| {
|
|
let a = cells.query_advice(a, Rotation::cur());
|
|
|
|
// If q is enabled, a must be in the table.
|
|
(q, vec![(a, table_vals.into())])
|
|
});
|
|
|
|
DynLookupCircuitConfig { a, q, table }
|
|
}
|
|
|
|
fn without_witnesses(&self) -> Self {
|
|
Self {}
|
|
}
|
|
|
|
fn synthesize(
|
|
&self,
|
|
config: Self::Config,
|
|
mut layouter: impl Layouter<Fp>,
|
|
) -> Result<(), Error> {
|
|
config.assign_lookups(&mut layouter, 0..=5)?;
|
|
let table_vals = config.table.columns()[0];
|
|
|
|
for i in 0..=5 {
|
|
layouter.assign_region(
|
|
|| format!("table {}", i),
|
|
|mut region| {
|
|
region.assign_advice(
|
|
|| "",
|
|
table_vals.try_into().unwrap(),
|
|
0,
|
|
|| Value::known(Fp::from(i as u64)),
|
|
)
|
|
// We should error since the table is empty without this line.
|
|
// table.include_row(|| "", &mut region, 0)?;
|
|
},
|
|
)?;
|
|
}
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
let res = MockProver::run(K, &DynLookupCircuit {}, vec![])
|
|
.unwrap()
|
|
.verify();
|
|
|
|
use FailureLocation::*;
|
|
use VerifyFailure::*;
|
|
assert_eq!(
|
|
res,
|
|
Err(vec![
|
|
Lookup {
|
|
lookup_index: 0,
|
|
location: InRegion {
|
|
region: (0, "lookups",).into(),
|
|
offset: 0,
|
|
},
|
|
},
|
|
Lookup {
|
|
lookup_index: 0,
|
|
location: InRegion {
|
|
region: (0, "lookups",).into(),
|
|
offset: 1,
|
|
},
|
|
},
|
|
Lookup {
|
|
lookup_index: 0,
|
|
location: InRegion {
|
|
region: (0, "lookups",).into(),
|
|
offset: 2,
|
|
},
|
|
},
|
|
Lookup {
|
|
lookup_index: 0,
|
|
location: InRegion {
|
|
region: (0, "lookups",).into(),
|
|
offset: 3,
|
|
},
|
|
},
|
|
Lookup {
|
|
lookup_index: 0,
|
|
location: InRegion {
|
|
region: (0, "lookups",).into(),
|
|
offset: 4,
|
|
},
|
|
},
|
|
Lookup {
|
|
lookup_index: 0,
|
|
location: InRegion {
|
|
region: (0, "lookups",).into(),
|
|
offset: 5,
|
|
},
|
|
},
|
|
],)
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn unassigned_dynamic_table_cell() {
|
|
struct DynLookupCircuit {}
|
|
impl Circuit<Fp> for DynLookupCircuit {
|
|
type Config = DynLookupCircuitConfig;
|
|
type FloorPlanner = SimpleFloorPlanner;
|
|
|
|
fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
|
|
let a = meta.advice_column();
|
|
let table_vals = meta.advice_column();
|
|
let q = meta.complex_selector();
|
|
let table = meta.create_dynamic_table("table", &[], &[table_vals]);
|
|
|
|
meta.lookup_dynamic(&table, |cells| {
|
|
let a = cells.query_advice(a, Rotation::cur());
|
|
|
|
// If q is enabled, a must be in the table.
|
|
(q, vec![(a, table_vals.into())])
|
|
});
|
|
|
|
DynLookupCircuitConfig { a, q, table }
|
|
}
|
|
|
|
fn without_witnesses(&self) -> Self {
|
|
Self {}
|
|
}
|
|
|
|
fn synthesize(
|
|
&self,
|
|
config: Self::Config,
|
|
mut layouter: impl Layouter<Fp>,
|
|
) -> Result<(), Error> {
|
|
layouter.assign_region(
|
|
|| "table",
|
|
|mut region| {
|
|
config.table.add_row(&mut region, 0)?;
|
|
Ok(())
|
|
},
|
|
)?;
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
let res = MockProver::run(K, &DynLookupCircuit {}, vec![])
|
|
.unwrap()
|
|
.verify();
|
|
|
|
assert_eq!(
|
|
res,
|
|
Err(vec![VerifyFailure::DynamicTableCellNotAssigned {
|
|
dynamic_table: DynamicTable {
|
|
name: "table".to_string(),
|
|
index: 0,
|
|
columns: vec![Column::new(1, Any::Advice)],
|
|
},
|
|
region: (0, "table".to_string(),).into(),
|
|
column: Column::new(1, Any::Advice),
|
|
offset: 0,
|
|
}])
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
#[should_panic]
|
|
fn column_not_in_dynamic_table() {
|
|
struct DynLookupCircuit {}
|
|
impl Circuit<Fp> for DynLookupCircuit {
|
|
type Config = DynLookupCircuitConfig;
|
|
type FloorPlanner = SimpleFloorPlanner;
|
|
|
|
fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
|
|
let a = meta.advice_column();
|
|
let not_table_vals = meta.advice_column();
|
|
let table_vals = meta.advice_column();
|
|
let q = meta.complex_selector();
|
|
let table = meta.create_dynamic_table("table", &[], &[table_vals]);
|
|
|
|
meta.lookup_dynamic(&table, |cells| {
|
|
let a = cells.query_advice(a, Rotation::cur());
|
|
|
|
// If q is enabled, a must be in the table.
|
|
(
|
|
q,
|
|
// Note that we are looking up a in not_table_vals.
|
|
// not_table_vals is not a column in the dynamic table.
|
|
vec![(a, not_table_vals.into())],
|
|
)
|
|
});
|
|
|
|
DynLookupCircuitConfig { a, q, table }
|
|
}
|
|
|
|
fn without_witnesses(&self) -> Self {
|
|
Self {}
|
|
}
|
|
|
|
fn synthesize(
|
|
&self,
|
|
config: Self::Config,
|
|
mut layouter: impl Layouter<Fp>,
|
|
) -> Result<(), Error> {
|
|
layouter.assign_region(
|
|
|| "table",
|
|
|mut region| {
|
|
config.table.add_row(&mut region, 0)?;
|
|
Ok(())
|
|
},
|
|
)?;
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
let res = MockProver::run(K, &DynLookupCircuit {}, vec![])
|
|
.unwrap()
|
|
.verify();
|
|
|
|
assert_eq!(
|
|
res,
|
|
Err(vec![VerifyFailure::DynamicTableCellNotAssigned {
|
|
dynamic_table: DynamicTable {
|
|
name: "table".to_string(),
|
|
index: 0,
|
|
columns: vec![Column::new(1, Any::Advice)],
|
|
},
|
|
region: (0, "table".to_string(),).into(),
|
|
column: Column::new(1, Any::Advice),
|
|
offset: 0,
|
|
}])
|
|
)
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
mod even_odd_dyn_tables {
|
|
use crate::plonk::DynamicTable;
|
|
|
|
use super::*;
|
|
|
|
const K: u32 = 7;
|
|
|
|
#[derive(Clone)]
|
|
struct EvenOddCircuitConfig {
|
|
is_even: Selector,
|
|
is_odd: Selector,
|
|
a: Column<Advice>,
|
|
even: DynamicTable,
|
|
odd: DynamicTable,
|
|
}
|
|
|
|
#[test]
|
|
fn even_odd_dyn_tables() {
|
|
struct DynLookupCircuit {}
|
|
impl Circuit<Fp> for DynLookupCircuit {
|
|
type Config = EvenOddCircuitConfig;
|
|
type FloorPlanner = SimpleFloorPlanner;
|
|
|
|
fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
|
|
let a = meta.advice_column();
|
|
let table_vals = meta.advice_column();
|
|
let is_even = meta.complex_selector();
|
|
let is_odd = meta.complex_selector();
|
|
let even = meta.create_dynamic_table("even", &[], &[table_vals]);
|
|
let odd = meta.create_dynamic_table("odd", &[], &[table_vals]);
|
|
|
|
meta.lookup_dynamic(&even, |cells| {
|
|
let a = cells.query_advice(a, Rotation::cur());
|
|
|
|
(is_even, vec![(a, table_vals.into())])
|
|
});
|
|
|
|
meta.lookup_dynamic(&odd, |cells| {
|
|
let a = cells.query_advice(a, Rotation::cur());
|
|
|
|
(is_odd, vec![(a, table_vals.into())])
|
|
});
|
|
|
|
EvenOddCircuitConfig {
|
|
a,
|
|
is_even,
|
|
is_odd,
|
|
even,
|
|
odd,
|
|
}
|
|
}
|
|
|
|
fn without_witnesses(&self) -> Self {
|
|
Self {}
|
|
}
|
|
|
|
fn synthesize(
|
|
&self,
|
|
config: Self::Config,
|
|
mut layouter: impl Layouter<Fp>,
|
|
) -> Result<(), Error> {
|
|
let table_vals = config.even.columns()[0];
|
|
|
|
for i in 0..=5 {
|
|
layouter.assign_region(
|
|
|| format!("lookup {}", i),
|
|
|mut region| {
|
|
// Enable the lookup on rows
|
|
if i % 2 == 0 {
|
|
config.is_even.enable(&mut region, 0)?;
|
|
} else {
|
|
config.is_odd.enable(&mut region, 0)?;
|
|
};
|
|
|
|
region.assign_advice(
|
|
|| "",
|
|
config.a,
|
|
0,
|
|
|| Value::known(Fp::from(i as u64)),
|
|
)
|
|
},
|
|
)?;
|
|
}
|
|
layouter.assign_region(
|
|
|| "table",
|
|
|mut region| {
|
|
for i in 0..=5 {
|
|
region.assign_advice(
|
|
|| "",
|
|
table_vals.try_into().unwrap(),
|
|
i,
|
|
|| Value::known(Fp::from(i as u64)),
|
|
)?;
|
|
|
|
let table = if i % 2 == 0 {
|
|
&config.even
|
|
} else {
|
|
&config.odd
|
|
};
|
|
table.add_row(&mut region, i)?;
|
|
}
|
|
Ok(())
|
|
},
|
|
)?;
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
MockProver::run(K, &DynLookupCircuit {}, vec![])
|
|
.unwrap()
|
|
.verify()
|
|
.unwrap();
|
|
}
|
|
}
|
|
|
|
#[cfg(feature = "unstable-dynamic-lookups")]
|
|
#[test]
|
|
fn failing() {
|
|
struct FailingCircuit {}
|
|
#[derive(Clone)]
|
|
struct FailingConfig {
|
|
first_input: Column<Advice>,
|
|
second_input: Column<Advice>,
|
|
is_first_table: Selector,
|
|
is_second_table: Selector,
|
|
first_table: crate::plonk::DynamicTable,
|
|
second_table: crate::plonk::DynamicTable,
|
|
}
|
|
impl Circuit<Fp> for FailingCircuit {
|
|
type Config = FailingConfig;
|
|
type FloorPlanner = SimpleFloorPlanner;
|
|
|
|
fn configure(meta: &mut ConstraintSystem<Fp>) -> Self::Config {
|
|
let first_input = meta.advice_column();
|
|
let second_input = meta.advice_column();
|
|
let first_table_vals = meta.advice_column();
|
|
// Reuse table column
|
|
let second_table_vals = first_table_vals;
|
|
let is_first_table = meta.complex_selector();
|
|
let is_second_table = meta.complex_selector();
|
|
let first_table =
|
|
meta.create_dynamic_table("first_table", &[], &[first_table_vals]);
|
|
let second_table =
|
|
meta.create_dynamic_table("second_table", &[], &[second_table_vals]);
|
|
|
|
meta.lookup_dynamic(&first_table, |cells| (is_first_table, vec![]));
|
|
|
|
meta.lookup_dynamic(&second_table, |cells| (is_second_table, vec![]));
|
|
|
|
FailingConfig {
|
|
first_input,
|
|
second_input,
|
|
is_first_table,
|
|
is_second_table,
|
|
first_table,
|
|
second_table,
|
|
}
|
|
}
|
|
|
|
fn without_witnesses(&self) -> Self {
|
|
Self {}
|
|
}
|
|
|
|
fn synthesize(
|
|
&self,
|
|
config: Self::Config,
|
|
mut layouter: impl Layouter<Fp>,
|
|
) -> Result<(), Error> {
|
|
layouter.assign_region(
|
|
|| "",
|
|
|mut region| {
|
|
config.is_first_table.enable(&mut region, 0)?;
|
|
|
|
Ok(())
|
|
},
|
|
)?;
|
|
|
|
layouter.assign_region(
|
|
|| "",
|
|
|mut region| {
|
|
config.is_second_table.enable(&mut region, 0)?;
|
|
|
|
Ok(())
|
|
},
|
|
)?;
|
|
|
|
layouter.assign_region(
|
|
|| "table",
|
|
|mut region| {
|
|
region.assign_advice(
|
|
|| "",
|
|
config.first_table.columns()[0].try_into().unwrap(),
|
|
0,
|
|
|| Value::known(Fp::from(1)),
|
|
)?;
|
|
config.first_table.add_row(&mut region, 0)?;
|
|
|
|
Ok(())
|
|
},
|
|
)?;
|
|
|
|
layouter.assign_region(
|
|
|| "table",
|
|
|mut region| {
|
|
region.assign_advice(
|
|
|| "",
|
|
config.second_table.columns()[0].try_into().unwrap(),
|
|
0,
|
|
|| Value::known(Fp::from(1)),
|
|
)?;
|
|
config.second_table.add_row(&mut region, 0)?;
|
|
|
|
Ok(())
|
|
},
|
|
)?;
|
|
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
const K: u32 = 3;
|
|
MockProver::run(K, &FailingCircuit {}, vec![])
|
|
.unwrap()
|
|
.assert_satisfied();
|
|
}
|
|
}
|