From 69d444c439b6fc5229ddc2c0a5b84181f708340e Mon Sep 17 00:00:00 2001 From: Kris Nuttycombe Date: Mon, 10 Apr 2023 14:49:47 -0600 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Daira Hopwood --- incrementalmerkletree/src/lib.rs | 2 +- incrementalmerkletree/src/witness.rs | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/incrementalmerkletree/src/lib.rs b/incrementalmerkletree/src/lib.rs index 36c08d1..42d53de 100644 --- a/incrementalmerkletree/src/lib.rs +++ b/incrementalmerkletree/src/lib.rs @@ -502,7 +502,7 @@ impl MerklePath { .enumerate() .fold(leaf, |root, (i, h)| { let level = Level(i as u8); - if self.position.0 >> i & 0x1 == 0 { + if (self.position.0 >> i) & 0x1 == 0 { H::combine(level, &root, h) } else { H::combine(level, h, &root) diff --git a/incrementalmerkletree/src/witness.rs b/incrementalmerkletree/src/witness.rs index 1d3ac8b..5bbe20d 100644 --- a/incrementalmerkletree/src/witness.rs +++ b/incrementalmerkletree/src/witness.rs @@ -18,6 +18,7 @@ use crate::{ /// use incrementalmerkletree::{ /// frontier::{CommitmentTree, testing::TestNode}, /// witness::IncrementalWitness, +/// Position /// }; /// /// let mut tree = CommitmentTree::::empty(); @@ -25,7 +26,7 @@ use crate::{ /// tree.append(TestNode(0)); /// tree.append(TestNode(1)); /// let mut witness = IncrementalWitness::from_tree(tree.clone()); -/// assert_eq!(witness.position(), 1); +/// assert_eq!(witness.position(), Position::from(1)); /// assert_eq!(tree.root(), witness.root()); /// /// let next = TestNode(2);