zec
/
kotlin-bip39
mirror of https://github.com/zcash/kotlin-bip39.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix: Conversion to list. 

When converting from an array of characters into a list of words, there was an off-by-one error that was causing the words to display incorrectly. This issue did not effect the seed that was used it only impacted the display. The problem has been fixed and the tests updated to catch this type of problem in the future.
This commit is contained in:
Kevin Gorham 2020-06-11 20:15:26 -04:00
parent c02842fbfc
commit 300e25dba9
No known key found for this signature in database
GPG Key ID: CCA55602DF49FC38
4 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
buildSrc/src/main/java/cash/z/ecc/android/Dependencies.kt
View File

@ -6,9 +6,10 @@ object Deps {
const val kotlinVersion = "1.3.72"
const val group = "cash.z.ecc.android"
const val artifactName = "kotlin-bip39"
const val versionName = "1.0.0-beta08"
const val versionName = "1.0.0-beta09"
const val description = "A concise implementation of BIP-0039 in Kotlin for Android."
const val githubUrl = "https://github.com/zcash/kotlin-bip39"
const val publishingActive = false // set to true to activate bintrayUpload task
object Kotlin : Version(kotlinVersion) {
val STDLIB = "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$version"

2
lib/publish.gradle
View File

@ -78,7 +78,7 @@ bintray {
userOrg = 'ecc-mobile'
licenses = ['MIT']
vcsUrl = Deps.githubUrl
dryRun = true
dryRun = !Deps.publishingActive
version {
name = Deps.versionName
desc = Deps.description

2
lib/src/main/java/cash/z/ecc/android/bip39/Mnemonics.kt
View File

@ -72,7 +72,7 @@ object Mnemonics {
var cursor = 0
chars.forEachIndexed { i, c ->
if (c == ' ' || i == chars.lastIndex) {
add(chars.copyOfRange(cursor, if (chars[i].isWhitespace()) i else i - 1))
add(chars.copyOfRange(cursor, if (chars[i].isWhitespace()) i else i + 1))
cursor = i + 1
}
}

5
lib/src/test/java/cash/z/ecc/android/bip39/MnemonicsTest.kt
View File

@ -11,6 +11,7 @@ import io.kotest.assertions.throwables.shouldThrow
import io.kotest.core.spec.style.BehaviorSpec
import io.kotest.data.forAll
import io.kotest.data.row
import io.kotest.matchers.collections.shouldContainAll
import io.kotest.matchers.shouldBe
import io.kotest.matchers.shouldNotBe
import io.kotest.matchers.string.shouldContain
@ -81,8 +82,8 @@ class MnemonicsTest : BehaviorSpec({
words.size shouldBe wordCount.count
}
Then("Each word is present in the original phrase") {
words.forEach {
phraseString shouldContain "$it"
phraseString.split(' ').let { correctWords ->
words.shouldContainAll(correctWords)
}
}
}