From 3ba0e481417957738e07897b798c605f00755628 Mon Sep 17 00:00:00 2001 From: Honza Rychnovsky Date: Mon, 17 Apr 2023 18:37:52 +0200 Subject: [PATCH] PR template update (#176) - We applied the same changes as we agreed on in the Secant project in the task [#632]. --- .github/PULL_REQUEST_TEMPLATE.md | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8725153..c788b80 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,19 +1,25 @@ -This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see [Code Review Guidelines](../blob/main/docs/CODE_REVIEW_GUIDELINES.md). + + +> **Note** +>This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see [Code Review Guidelines](../blob/main/docs/CODE_REVIEW_GUIDELINES.md). # Author -- [ ] Self-review: Did you review your own code in GitHub's web interface? _Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs._ -- [ ] Automated tests: Did you add appropriate automated tests for any code changes? -- [ ] Code coverage: Did you check the code coverage report for the automated tests? _While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Run `./gradlew check` then coverage reports are generated under `build/reports/kover`. -- [ ] Documentation: Did you update documentation as appropriate? (e.g [README.md](../blob/master/README.md), etc.) -- [ ] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? _Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit._ +- [ ] **Self-review** your own code in GitHub's web interface[^1] +- [ ] Add **automated tests** as appropriate +- [ ] Check the **code coverage**[^2] report for the automated tests +- [ ] Update **documentation** as appropriate (e.g [README.md](../blob/main/README.md), etc.) +- [ ] Pull in the latest changes from the **main** branch and **squash** your commits before assigning a reviewer[^3] # Reviewer -- [ ] Checklist review: Did you go through the code with the [Code Review Guidelines](../blob/master/docs/CODE_REVIEW_GUIDELINES.md) checklist? -- [ ] Ad hoc review: Did you perform an ad hoc review? _In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass._ -- [ ] Automated tests: Did you review the automated tests? -- [ ] Manual tests: Did you review the manual tests? -- [ ] How is code coverage affected by this PR? _We encourage you to compare coverage before and after changes and when possible, leaving it in a better place._ -- [ ] Documentation: Did you review Docs and [README.md](../blob/master/README.md) as appropriate? +- [ ] Check the code with the [Code Review Guidelines](../blob/main/docs/CODE_REVIEW_GUIDELINES.md) **checklist** +- [ ] Perform an **ad hoc review**[^4] +- [ ] Review the **automated tests** +- [ ] Review the **documentation**, [README.md](../blob/main/README.md), etc. as appropriate + +[^1]: _Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs._ +[^2]: _While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: `./gradlew check`._ +[^3]: _Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit._ +[^4]: _In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass._