zec
/
librustzcash
mirror of https://github.com/zcash/librustzcash.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

pedersen hashes: example of size limit bug

This commit is contained in:
Kobi Gurkan 2018-08-17 18:34:54 +03:00 committed by Jack Grigg
parent 414d651c9c
commit 15633ad434
No known key found for this signature in database
GPG Key ID: 9E8255172BBF9898
3 changed files with 23 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
bellman/src/gadgets/lookup.rs
View File

@ -154,6 +154,7 @@ where
Ok(tmp) Ok(tmp)
})?; })?;
let one = CS::one(); let one = CS::one();
// Compute the coefficients for the lookup constraints // Compute the coefficients for the lookup constraints

19
zcash_primitives/src/pedersen_hash.rs
View File

@ -18,7 +18,7 @@ impl Personalization {
(0..6).map(|i| (num >> i) & 1 == 1).collect() (0..6).map(|i| (num >> i) & 1 == 1).collect()
} }
Personalization::Empty => { Personalization::Empty => {
vec![true, true, true, false, false, false] vec![true, true, true, true, true, true]
} }
} }
} }
@ -115,13 +115,26 @@ where
#[cfg(test)] #[cfg(test)]
mod test { mod test {
use crate::jubjub::*; use crate::{
jubjub::*,
pedersen_hash::{pedersen_hash, Personalization},
};
use pairing::bls12_381::{Bls12, Fr};
#[test] #[test]
fn test_pedersen_hash_generators() { fn test_pedersen_hash_noncircuit() {
let params = &JubjubBls12::new(); let params = &JubjubBls12::new();
/*
for (i, generator) in params.pedersen_hash_generators().iter().enumerate() { for (i, generator) in params.pedersen_hash_generators().iter().enumerate() {
println!("generator {}, x={}, y={}", i, generator.to_xy().0, generator.to_xy().1) println!("generator {}, x={}, y={}", i, generator.to_xy().0, generator.to_xy().1)
} }
*/
let mut input: Vec<bool> = vec![];
for i in 0..(63*3*4+1) {
input.push(true);
}
let p = pedersen_hash::<Bls12, _>(Personalization::Empty, input, &params).to_xy();
println!("hash = {}, {}", p.0, p.1);
} }
} }

8
zcash_proofs/src/circuit/pedersen_hash.rs
View File

@ -41,6 +41,7 @@ where
let b = bits.next().unwrap_or(&boolean_false); let b = bits.next().unwrap_or(&boolean_false);
let c = bits.next().unwrap_or(&boolean_false); let c = bits.next().unwrap_or(&boolean_false);
let tmp = lookup3_xy_with_conditional_negation( let tmp = lookup3_xy_with_conditional_negation(
cs.namespace(|| format!("segment {}, window {}", segment_i, window_i)), cs.namespace(|| format!("segment {}, window {}", segment_i, window_i)),
&[a.clone(), b.clone(), c.clone()], &[a.clone(), b.clone(), c.clone()],
@ -213,16 +214,19 @@ mod test {
fn test_pedersen_hash_alternative() { fn test_pedersen_hash_alternative() {
let params = &JubjubBls12::new(); let params = &JubjubBls12::new();
let mut input: Vec<bool> = vec![true, true, true, false, false, false, true, true, true, false, false, false, true, true, true, false, false, false, true, true, true, false, false, false, true, true, true, false, false, false, true, true, true, false, false, false, true, true, true, false, true, false, true, true, true, true, true, false, true, false, false, false, true, true, false, false, false, false, false, false, false, false, false, false, true, false, false, false, true, false, true, true, true, false, false, true, true, false, true, true, true, true, true, false, true, true, false, true, true, false, true, false, true, false, true, true, false, true, false, true, true, false, false, false, false, false, true, true, false, true, false, true, true, true, true, false, true, false, true, false, false, false, false, true, true, true, false, true, true, true, false, true, false, false, true, false, true, true, true, false, false, false, true, true]; let mut input: Vec<bool> = vec![];
for i in 0..(63*3*4+1) {
input.push(true);
}
let mut cs = TestConstraintSystem::<Bls12>::new(); let mut cs = TestConstraintSystem::<Bls12>::new();
let input_bools: Vec<Boolean> = input.iter().enumerate().map(|(i, b)| { let input_bools: Vec<Boolean> = input.iter().enumerate().map(|(i, b)| {
Boolean::from( Boolean::from(
AllocatedBit::alloc(cs.namespace(|| format!("input {}", i)), Some(*b)).unwrap() AllocatedBit::alloc(cs.namespace(|| format!("input {}", i)), Some(*b)).unwrap()
) )
}).collect(); }).collect();
let res = pedersen_hash( let res = pedersen_hash(
cs.namespace(|| "pedersen hash"), cs.namespace(|| "pedersen hash"),
Personalization::Empty, Personalization::Empty,