From 6410bdf998d48a5b4f9753ad8030e83a655ae50c Mon Sep 17 00:00:00 2001
From: Sean Bowe <ewillbefull@gmail.com>
Date: Mon, 31 Jul 2017 09:39:57 -0600
Subject: [PATCH] Adopt idiomatic code suggestions.

---
 src/bls12_381/fq.rs | 2 +-
 src/bls12_381/fr.rs | 2 +-
 src/lib.rs          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/bls12_381/fq.rs b/src/bls12_381/fq.rs
index cf81975ae..edfe1500c 100644
--- a/src/bls12_381/fq.rs
+++ b/src/bls12_381/fq.rs
@@ -334,7 +334,7 @@ impl PrimeFieldRepr for FqRepr {
 
         while n >= 64 {
             let mut t = 0;
-            for i in self.0.iter_mut() {
+            for i in &mut self.0 {
                 ::std::mem::swap(&mut t, i);
             }
             n -= 64;
diff --git a/src/bls12_381/fr.rs b/src/bls12_381/fr.rs
index dcfc11b0e..9fc90ee0a 100644
--- a/src/bls12_381/fr.rs
+++ b/src/bls12_381/fr.rs
@@ -170,7 +170,7 @@ impl PrimeFieldRepr for FrRepr {
 
         while n >= 64 {
             let mut t = 0;
-            for i in self.0.iter_mut() {
+            for i in &mut self.0 {
                 ::std::mem::swap(&mut t, i);
             }
             n -= 64;
diff --git a/src/lib.rs b/src/lib.rs
index 55b0c1975..35e9a63b5 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -482,7 +482,7 @@ pub trait PrimeField: Field
     /// Interpret a string of numbers as a (congruent) prime field element.
     /// Does not accept unnecessary leading zeroes or a blank string.
     fn from_str(s: &str) -> Option<Self> {
-        if s.len() == 0 {
+        if s.is_empty() {
             return None;
         }