From 74abb88dcec52e742ec62c4b186270cd335f1956 Mon Sep 17 00:00:00 2001 From: Daira Hopwood Date: Sat, 22 Aug 2020 00:56:17 +0100 Subject: [PATCH] Fix some comments. Signed-off-by: Daira Hopwood --- zcash_proofs/src/circuit/ecc.rs | 2 +- zcash_proofs/src/circuit/sapling.rs | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/zcash_proofs/src/circuit/ecc.rs b/zcash_proofs/src/circuit/ecc.rs index 933764366..61667e1f3 100644 --- a/zcash_proofs/src/circuit/ecc.rs +++ b/zcash_proofs/src/circuit/ecc.rs @@ -539,7 +539,7 @@ impl MontgomeryPoint { } /// Performs an affine point addition, not defined for - /// coincident points. + /// points with the same x-coordinate. pub fn add(&self, mut cs: CS, other: &Self) -> Result where CS: ConstraintSystem, diff --git a/zcash_proofs/src/circuit/sapling.rs b/zcash_proofs/src/circuit/sapling.rs index 8715af5c0..93e3e97e9 100644 --- a/zcash_proofs/src/circuit/sapling.rs +++ b/zcash_proofs/src/circuit/sapling.rs @@ -153,9 +153,9 @@ impl Circuit for Spend { )?; // NB: We don't ensure that the bit representation of nsk - // is "in the field" (Fs) because it's not used except to - // demonstrate the prover knows it. If they know a - // congruency then that's equivalent. + // is "in the field" (jubjub::Fr) because it's not used + // except to demonstrate the prover knows it. If they know + // a congruency then that's equivalent. // Compute nk = [nsk] ProvingPublicKey nk = ecc::fixed_base_multiplication( @@ -501,8 +501,8 @@ impl Circuit for Output { // Only the u-coordinate of the output is revealed, // since we know it is prime order, and we know that - // the x-coordinate is an injective encoding for - // prime-order elements. + // the u-coordinate is an injective encoding for + // elements in the prime-order subgroup. cm.get_u().inputize(cs.namespace(|| "commitment"))?; Ok(())