zec
/
librustzcash
mirror of https://github.com/zcash/librustzcash.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

zcash_address: Invert Typecode::is_shielded to Typecode::is_transparent 

Co-authored-by: Daira Hopwood <daira@jacaranda.org>
This commit is contained in:
Jack Grigg 2021-07-12 20:19:26 +01:00
parent 060a15eaf8
commit 77d1f0c778
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
components/zcash_address/src/kind/unified.rs
View File

@ -100,11 +100,13 @@ impl From<Typecode> for u8 {
}
impl Typecode {
fn is_shielded(&self) -> bool {
fn is_transparent(&self) -> bool {
match self {
Typecode::P2pkh | Typecode::P2sh => false,
// Assume that unknown typecodes are shielded, because they might be.
_ => true,
Typecode::P2pkh | Typecode::P2sh => true,
// Unknown typecodes are treated as not transparent for the purpose of
// disallowing only-transparent UAs, which can be represented with existing
// address encodings.
_ => false,
}
}
}
@ -263,7 +265,7 @@ impl TryFrom<Vec<Receiver>> for Address {
}
}
if !typecodes.iter().any(|t| t.is_shielded()) {
if typecodes.iter().all(|t| t.is_transparent()) {
Err(ParseError::OnlyTransparent)
} else {
// All checks pass!