From 8c4433ee820d233a03c3669aecc0986542853030 Mon Sep 17 00:00:00 2001
From: Sean Bowe <ewillbefull@gmail.com>
Date: Thu, 14 Dec 2017 11:34:57 -0700
Subject: [PATCH] Add 2A precomputation to jubjub parameters.

---
 src/jubjub/mod.rs   | 12 +++++++++++-
 src/jubjub/tests.rs |  8 ++++++++
 2 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/src/jubjub/mod.rs b/src/jubjub/mod.rs
index e510eb899..d281b9665 100644
--- a/src/jubjub/mod.rs
+++ b/src/jubjub/mod.rs
@@ -16,6 +16,7 @@
 
 use pairing::{
     Engine,
+    Field,
     PrimeField,
     SqrtField
 };
@@ -39,6 +40,7 @@ pub trait JubjubEngine: Engine {
 pub trait JubjubParams<E: JubjubEngine>: Sized {
     fn edwards_d(&self) -> &E::Fr;
     fn montgomery_a(&self) -> &E::Fr;
+    fn montgomery_2a(&self) -> &E::Fr;
     fn scale(&self) -> &E::Fr;
 }
 
@@ -55,22 +57,30 @@ impl JubjubEngine for Bls12 {
 pub struct JubjubBls12 {
     edwards_d: Fr,
     montgomery_a: Fr,
+    montgomery_2a: Fr,
     scale: Fr
 }
 
 impl JubjubParams<Bls12> for JubjubBls12 {
     fn edwards_d(&self) -> &Fr { &self.edwards_d }
     fn montgomery_a(&self) -> &Fr { &self.montgomery_a }
+    fn montgomery_2a(&self) -> &Fr { &self.montgomery_2a }
     fn scale(&self) -> &Fr { &self.scale }
 }
 
 impl JubjubBls12 {
     pub fn new() -> Self {
+        let montgomery_a = Fr::from_str("40962").unwrap();
+        let mut montgomery_2a = montgomery_a;
+        montgomery_2a.double();
+
         JubjubBls12 {
             // d = -(10240/10241)
             edwards_d: Fr::from_str("19257038036680949359750312669786877991949435402254120286184196891950884077233").unwrap(),
             // A = 40962
-            montgomery_a: Fr::from_str("40962").unwrap(),
+            montgomery_a: montgomery_a,
+            // 2A = 2.A
+            montgomery_2a: montgomery_2a,
             // scaling factor = sqrt(4 / (a - d))
             scale: Fr::from_str("17814886934372412843466061268024708274627479829237077604635722030778476050649").unwrap()
         }
diff --git a/src/jubjub/tests.rs b/src/jubjub/tests.rs
index d5943835d..c26bbe7ae 100644
--- a/src/jubjub/tests.rs
+++ b/src/jubjub/tests.rs
@@ -264,6 +264,14 @@ fn test_jubjub_params<E: JubjubEngine>(params: &E::Params) {
     let mut a = E::Fr::one();
     a.negate();
 
+    {
+        // Check that 2A is consistent with A
+        let mut tmp = *params.montgomery_a();
+        tmp.double();
+
+        assert_eq!(&tmp, params.montgomery_2a());
+    }
+
     {
         // The twisted Edwards addition law is complete when d is nonsquare
         // and a is square.