Panic if spending_key is given a seed shorter than 32 bytes
This enforces the MUST requirement in ZIP 32. A panic is used instead of an error because this should be considered an implementation error. Ideally the type system would prevent this from occurring at all. Closes #125.
This commit is contained in:
parent
2b6fbfd2d1
commit
9377b78b35
|
@ -5,6 +5,10 @@ use zcash_primitives::zip32::{ChildIndex, ExtendedSpendingKey};
|
||||||
/// Derives the ZIP 32 [`ExtendedSpendingKey`] for a given coin type and account from the
|
/// Derives the ZIP 32 [`ExtendedSpendingKey`] for a given coin type and account from the
|
||||||
/// given seed.
|
/// given seed.
|
||||||
///
|
///
|
||||||
|
/// # Panics
|
||||||
|
///
|
||||||
|
/// Panics if `seed` is shorter than 32 bytes.
|
||||||
|
///
|
||||||
/// # Examples
|
/// # Examples
|
||||||
///
|
///
|
||||||
/// ```
|
/// ```
|
||||||
|
@ -13,6 +17,10 @@ use zcash_primitives::zip32::{ChildIndex, ExtendedSpendingKey};
|
||||||
/// let extsk = spending_key(&[0; 32][..], COIN_TYPE, 0);
|
/// let extsk = spending_key(&[0; 32][..], COIN_TYPE, 0);
|
||||||
/// ```
|
/// ```
|
||||||
pub fn spending_key(seed: &[u8], coin_type: u32, account: u32) -> ExtendedSpendingKey {
|
pub fn spending_key(seed: &[u8], coin_type: u32, account: u32) -> ExtendedSpendingKey {
|
||||||
|
if seed.len() < 32 {
|
||||||
|
panic!("ZIP 32 seeds MUST be at least 32 bytes");
|
||||||
|
}
|
||||||
|
|
||||||
ExtendedSpendingKey::from_path(
|
ExtendedSpendingKey::from_path(
|
||||||
&ExtendedSpendingKey::master(&seed),
|
&ExtendedSpendingKey::master(&seed),
|
||||||
&[
|
&[
|
||||||
|
|
Loading…
Reference in New Issue