Apply suggestions from code review

Co-authored-by: str4d <thestr4d@gmail.com>
This commit is contained in:
Kris Nuttycombe 2024-01-04 11:56:59 -07:00 committed by GitHub
parent 857e44a11c
commit 967fd36d39
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 7 deletions

View File

@ -189,7 +189,7 @@ and this library adheres to Rust's notion of
- `RecipientAddress` has been renamed to `Address`
- `Address::Shielded` has been renamed to `Address::Sapling`
- `UnifiedAddress::from_receivers` no longer takes an Orchard receiver
argument uless the `orchard` feature is enabled.
argument unless the `orchard` feature is enabled.
- `UnifiedAddress::orchard` is now only available when the `orchard` feature
is enabled.
@ -199,7 +199,7 @@ and this library adheres to Rust's notion of
- `UnifiedSpendingKey::orchard` is now only available when the `orchard`
feature is enabled.
- `UnifiedFullViewingKey::new` no longer takes an Orchard full viewing key
argument uless the `orchard` feature is enabled.
argument unless the `orchard` feature is enabled.
### Removed
- `zcash_client_backend::wallet::ReceivedSaplingNote` has been replaced by

View File

@ -634,8 +634,8 @@ impl<NoteCommitment, NF> ScannedBundles<NoteCommitment, NF> {
///
/// The returned tuple is keyed by both transaction ID and the index of the transaction within
/// the block, so that either the txid or the combination of the block hash available from
/// [`Self::block_hash`] and returned transaction index may be used to uniquely identify the
/// transaction, depending upon the needs of the caller.
/// [`ScannedBlock::block_hash`] and returned transaction index may be used to uniquely
/// identify the transaction, depending upon the needs of the caller.
pub fn nullifier_map(&self) -> &[(TxId, u16, Vec<NF>)] {
&self.nullifier_map
}

View File

@ -26,9 +26,6 @@ use {
zcash_primitives::consensus::BranchId,
};
#[cfg(feature = "orchard")]
use orchard;
pub mod sapling {
pub use sapling::zip32::{
DiversifiableFullViewingKey, ExtendedFullViewingKey, ExtendedSpendingKey,