diff --git a/zcash_client_backend/src/welding_rig.rs b/zcash_client_backend/src/welding_rig.rs index c07001cdc..fcb9c7a09 100644 --- a/zcash_client_backend/src/welding_rig.rs +++ b/zcash_client_backend/src/welding_rig.rs @@ -191,7 +191,7 @@ mod tests { use pairing::bls12_381::{Bls12, Fr}; use rand_core::{OsRng, RngCore}; use zcash_primitives::{ - consensus::{NetworkUpgrade, TestNetwork}, + consensus::{TestNetwork}, jubjub::{fs::Fs, FixedGenerators, JubjubParams, ToUniform}, merkle_tree::CommitmentTree, note_encryption::{Memo, SaplingNoteEncryption}, @@ -255,11 +255,7 @@ mod tests { // Create a fake Note for the account let mut rng = OsRng; - let rseed = generate_random_rseed::( - NetworkUpgrade::Canopy, - height as u32, - &mut rng, - ); + let rseed = generate_random_rseed::(height as u32, &mut rng); let note = Note { g_d: to.diversifier().g_d::(&JUBJUB).unwrap(), pk_d: to.pk_d().clone(), diff --git a/zcash_client_sqlite/src/lib.rs b/zcash_client_sqlite/src/lib.rs index 533a25809..655ae89e9 100644 --- a/zcash_client_sqlite/src/lib.rs +++ b/zcash_client_sqlite/src/lib.rs @@ -106,7 +106,6 @@ mod tests { }; use zcash_primitives::{ block::BlockHash, - consensus::NetworkUpgrade, note_encryption::{Memo, SaplingNoteEncryption}, primitives::{Note, PaymentAddress}, transaction::components::Amount, @@ -127,11 +126,7 @@ mod tests { // Create a fake Note for the account let mut rng = OsRng; - let rseed = generate_random_rseed::( - NetworkUpgrade::Canopy, - height as u32, - &mut rng, - ); + let rseed = generate_random_rseed::(height as u32, &mut rng); let note = Note { g_d: to.diversifier().g_d::(&JUBJUB).unwrap(), pk_d: to.pk_d().clone(), @@ -181,11 +176,7 @@ mod tests { value: Amount, ) -> CompactBlock { let mut rng = OsRng; - let rseed = generate_random_rseed::( - NetworkUpgrade::Canopy, - height as u32, - &mut rng, - ); + let rseed = generate_random_rseed::(height as u32, &mut rng); // Create a fake CompactBlock containing the note let mut cspend = CompactSpend::new(); @@ -222,11 +213,7 @@ mod tests { // Create a fake Note for the change ctx.outputs.push({ let change_addr = extfvk.default_address().unwrap().1; - let rseed = generate_random_rseed::( - NetworkUpgrade::Canopy, - height as u32, - &mut rng, - ); + let rseed = generate_random_rseed::(height as u32, &mut rng); let note = Note { g_d: change_addr.diversifier().g_d::(&JUBJUB).unwrap(), pk_d: change_addr.pk_d().clone(), diff --git a/zcash_primitives/src/note_encryption.rs b/zcash_primitives/src/note_encryption.rs index e85daaede..5d91321ad 100644 --- a/zcash_primitives/src/note_encryption.rs +++ b/zcash_primitives/src/note_encryption.rs @@ -799,8 +799,7 @@ mod tests { }; let cv = value_commitment.cm(&JUBJUB).into(); - let rseed = - generate_random_rseed::(NetworkUpgrade::Canopy, height, &mut rng); + let rseed = generate_random_rseed::(height, &mut rng); let note = pa.create_note(value, rseed, &JUBJUB).unwrap(); let cmu = note.cm(&JUBJUB); diff --git a/zcash_primitives/src/transaction/builder.rs b/zcash_primitives/src/transaction/builder.rs index 8497fea81..9ace40656 100644 --- a/zcash_primitives/src/transaction/builder.rs +++ b/zcash_primitives/src/transaction/builder.rs @@ -14,7 +14,7 @@ use std::marker::PhantomData; use crate::{ consensus, - consensus::{MainNetwork, NetworkUpgrade, TestNetwork}, + consensus::{MainNetwork, TestNetwork}, keys::OutgoingViewingKey, legacy::TransparentAddress, merkle_tree::MerklePath, @@ -105,7 +105,7 @@ impl SaplingOutput { return Err(Error::InvalidAmount); } - let rseed = generate_random_rseed::(NetworkUpgrade::Canopy, height, rng); + let rseed = generate_random_rseed::(height, rng); let note = Note { g_d, @@ -633,11 +633,7 @@ impl Builder { } }; - let rseed = generate_random_rseed::( - NetworkUpgrade::Canopy, - self.height, - &mut self.rng, - ); + let rseed = generate_random_rseed::(self.height, &mut self.rng); ( payment_address, diff --git a/zcash_primitives/src/util.rs b/zcash_primitives/src/util.rs index 65d3418a4..4edfbc759 100644 --- a/zcash_primitives/src/util.rs +++ b/zcash_primitives/src/util.rs @@ -18,11 +18,10 @@ pub fn hash_to_scalar(persona: &[u8], a: &[u8], b: &[u8]) -> E: } pub fn generate_random_rseed( - nu: NetworkUpgrade, height: u32, rng: &mut R, ) -> Rseed { - if P::is_nu_active(nu, height) { + if P::is_nu_active(NetworkUpgrade::Canopy, height) { let mut buffer = [0u8; 32]; &rng.fill_bytes(&mut buffer); Rseed::AfterZip212(buffer)