Apply suggestions from code review

Co-authored-by: str4d <jack@electriccoin.co>
This commit is contained in:
Kris Nuttycombe 2021-09-01 10:25:00 -06:00 committed by Kris Nuttycombe
parent e9c18ebaed
commit c1bad64fbd
4 changed files with 8 additions and 6 deletions

View File

@ -1,8 +1,9 @@
[package]
name = "zcash_encoding"
description = "Binary encodings of types used throughout the Zcash ecosystem."
description = "Binary encodings used throughout the Zcash ecosystem."
version = "0.0.0"
authors = [
"Jack Grigg <jack@electriccoin.co>",
"Kris Nuttycombe <kris@electriccoin.co>",
]
homepage = "https://github.com/zcash/librustzcash"

View File

@ -1,7 +1,7 @@
# zcash_encodings
Zcash-related types that require stable binary encodings for use throughout the
Zcash ecosystem.
This library provides common encoding and decoding operations for stable binary
encodings used throughout the Zcash ecosystem.
## License

View File

@ -49,6 +49,8 @@ and this library adheres to Rust's notion of
type bounded on a newly added `tze::Authorization` trait which
is used to enable static reasoning about the state of TZE witness
data, as described above.
- `zcash_primitives::serialize` has been factored out as a new `zcash_encoding`
crate, which can be found in the `components` directory.
### Changed
- MSRV is now 1.51.0.

View File

@ -2,15 +2,14 @@
#![cfg(feature = "zfuture")]
use byteorder::{LittleEndian, ReadBytesExt, WriteBytesExt};
use std::convert::TryFrom;
use std::fmt::Debug;
use std::io::{self, Read, Write};
use zcash_encoding::{CompactSize, Vector};
use crate::{extensions::transparent as tze, transaction::TxId};
use super::amount::Amount;
use crate::{extensions::transparent as tze, transaction::TxId};
pub mod builder;