Commit Graph

4173 Commits

Author SHA1 Message Date
Kris Nuttycombe de58b5a5b1 zcash_client_sqlite: Add a failing test of cross-pool transfer 2024-03-11 11:36:35 +00:00
Kris Nuttycombe 99b3d3c997 zcash_client_sqlite: Generalize chain tests. 2024-03-11 10:27:54 +00:00
Kris Nuttycombe 02562187af zcash_client_sqlite: Make scan_cached_blocks_detects_spends_out_of_order a common single-pool test 2024-03-11 10:27:54 +00:00
Kris Nuttycombe 1003cd66ea
Merge pull request #1252 from zcash/orchard-test-fixes
Various fixes to Orchard tests
2024-03-10 16:15:02 -06:00
Jack Grigg 993102e803 zcash_client_sqlite: Fix `test_with_nu5_birthday_offset` tree setup 2024-03-10 21:47:40 +00:00
Jack Grigg 799574590e zcash_client_sqlite: Fix more test seeds to use valid lengths 2024-03-10 21:47:40 +00:00
Jack Grigg 2a81156520 zcash_client_sqlite: Fix balance APIs in `TestState` to include Orchard 2024-03-10 21:47:40 +00:00
Jack Grigg c4abcba343 zcash_client_backend: Add Orchard change output support to proposals 2024-03-10 21:47:40 +00:00
Kris Nuttycombe 654f116a0a
Merge pull request #1251 from zcash/ci-rework
CI: Rework the test states
2024-03-10 13:49:12 -06:00
Jack Grigg 6898dbf094 Replace `unstable-nu6` and `zfuture` feature flags with cfg flags
Neither of these should have been feature flags, as they gate breaking
changes to the Zcash consensus rules (and in some ways are incompatible
with each other), while feature flags should be additive.
2024-03-10 18:42:39 +00:00
Jack Grigg 98c82eb6c6 CI: Stop actively testing ZFuture and instead just check it builds 2024-03-10 18:03:50 +00:00
Jack Grigg 93048c6c46 CI: Separate test "state" from the feature flags activated by it 2024-03-10 18:01:33 +00:00
Kris Nuttycombe 0d4a730e9e
Merge pull request #1250 from zcash/zcs-orchard-testing
zcash_client_sqlite: Run single-shielded-pool tests on Orchard
2024-03-10 08:16:32 -06:00
Jack Grigg 10e1bb6001 CI: Continue tests on error if test failures are in an unstable flag 2024-03-10 01:26:06 +00:00
Jack Grigg 75c5f31ab0 zcash_client_sqlite: Use a seeded RNG in `TestState`
This makes individual instances of `TestState` deterministic, which
helps with debugging.
2024-03-10 01:10:50 +00:00
Jack Grigg 390b536950 zcash_client_sqlite: Use `LocalNetwork` for testing
This enables us to activate Sapling and NU5 at the same height, to
simplify reuse of test logic between Sapling and Orchard.

As a side-effect, `zcash_extensions` is removed from the workspace
because it enables the `zfuture` feature flag unconditionally, which
breaks workspace-level builds because this causes the `zfuture` feature
flag on `zcash_protocol` to be enabled without the corresponding feature
flag on `zcash_client_sqlite` being enabled. We will fix this by moving
from feature flags to config flags for unstable features.
2024-03-10 01:10:28 +00:00
Jack Grigg 798d9154b8 zcash_client_sqlite: Use a valid length for test seeds 2024-03-09 21:12:37 +00:00
Jack Grigg a0b517a93a zcash_client_sqlite: Add `OrchardPoolTester`, run tests with Orchard 2024-03-09 20:44:19 +00:00
str4d 58f46e4636
Merge pull request #1248 from zcash/zcs-test-state-orchard-tree
zcash_client_sqlite: Track Orchard commitment tree sizes in `TestState`
2024-03-09 19:40:39 +00:00
Jack Grigg 0891b5fd3a zcash_client_backend: Correctly handle empty frontiers in test birthdays 2024-03-09 18:21:34 +00:00
Jack Grigg f74c2304df zcash_client_sqlite: Track Orchard commitment tree sizes in `TestState` 2024-03-09 18:06:20 +00:00
Jack Grigg dd8808fd83 zcash_client_sqlite: Replace tuple with struct in `TestState` 2024-03-09 17:36:18 +00:00
Kris Nuttycombe 39c750312f
Merge pull request #1247 from zcash/zcs-pool-testing
zcash_client_sqlite: Generalise Sapling tests
2024-03-09 10:11:46 -07:00
Jack Grigg 9d40588a50 zcash_client_sqlite: Generalise `wallet::scanning` tests 2024-03-09 15:28:47 +00:00
Jack Grigg 399ae762b7 zcash_client_sqlite: Generalise `wallet::commitment_tree` tests 2024-03-09 15:20:43 +00:00
Jack Grigg d89b88126d zcash_client_sqlite: Generalise `wallet::sapling` tests
These are all "single shielded pool" tests, and should pass for any
shielded pool implemented in the wallet.
2024-03-09 15:20:40 +00:00
Kris Nuttycombe 19868af84a
Merge pull request #1246 from zcash/zcb-0.11-zcs-0.9-doc-fixes
`zcash_client_backend 0.11.1`, `zcash_client_sqlite 0.9.1` with doc fixes
2024-03-09 08:19:41 -07:00
Jack Grigg c6f1fdb73d zcash_client_sqlite 0.9.1 2024-03-09 11:39:38 +00:00
Jack Grigg 7f38b79c3c zcash_client_backend 0.11.1 2024-03-09 11:38:33 +00:00
Jack Grigg 075a155a29 Remove `orchard` feature flag from docs.rs builds while not public 2024-03-09 11:37:25 +00:00
Oscar Pepper a63cf37c7b zcash_client_backend: Fixed cargo doc build failure when transparent-inputs feature is not specified
(cherry picked from commit ab701118f3)
2024-03-09 11:37:25 +00:00
str4d e834c302ff
Merge pull request #1243 from nuttycom/allow_missing_receiving_key_scope
zcash_client_sqlite: Only consider notes spendable when both seed fingerprint & key scope are available.
2024-03-09 11:16:06 +00:00
Kris Nuttycombe 5511bacf25 zcash_client_sqlite: Make sapling_received_notes.recipient_key_scope optional.
We will only consider notes spendable when both the UFVK & key scope are available.
2024-03-08 18:34:50 -07:00
Kris Nuttycombe df93c1ce78
Merge pull request #1241 from nuttycom/pre_orchard_generalizations
zcash_client_sqlite: Generalize internal operations to simplify Orchard support
2024-03-08 17:02:25 -07:00
str4d c7f7c2eca4
Merge pull request #1242 from zcash/fix-ci-trigger
CI: Trigger on pushes to `main` branch
2024-03-08 23:51:39 +00:00
Kris Nuttycombe e2ac746e9d zcash_client_sqlite: Generalize `ReceivedNoteId` 2024-03-08 16:43:06 -07:00
Kris Nuttycombe d55edd8dd8 zcash_client_sqlite: Deduplicate `WalletDb::get_sapling_nullifiers` 2024-03-08 16:41:51 -07:00
Kris Nuttycombe 7aacfc3bb0 zcash_client_sqlite: Extract general helpers from Sapling tree logic 2024-03-08 16:41:51 -07:00
Jack Grigg b8b19dfe11 CI: Trigger on pushes to `main` branch 2024-03-08 23:41:50 +00:00
Kris Nuttycombe e24d93ccfd
Merge pull request #1228 from Oscar-Pepper/fix_cargo_doc_build_failure
Fixed cargo doc build failure
2024-03-08 15:44:09 -07:00
Kris Nuttycombe 50b4c497ae
Merge pull request #1239 from zcash/fasterer-ci
CI: Add caching
2024-03-08 15:40:42 -07:00
str4d aeb51708ca
Merge pull request #1240 from zcash/migration-errors
zcash_client_sqlite: Use errors instead of panics in down-migrations
2024-03-08 22:39:11 +00:00
Kris Nuttycombe c107f3df11 zcash_client_sqlite: Use errors instead of panics for unimplemented or unsupported down migrations. 2024-03-08 22:19:05 +00:00
Jack Grigg e4a8b3abd4 CI: Remove timeouts from rustfmt and clippy 2024-03-08 22:01:48 +00:00
Jack Grigg f12b2b5a1f CI: Add caching 2024-03-08 21:23:28 +00:00
Kris Nuttycombe 54addb6ca6
Merge pull request #1234 from nuttycom/wallet/spendable_value
zcash_client_backend: Update `DecryptedTransaction` to support Orchard
2024-03-08 14:12:52 -07:00
Kris Nuttycombe 78e4916899 zcash_client_backend: Generalize `DecryptedOutput` to support Orchard 2024-03-08 13:48:30 -07:00
Kris Nuttycombe 4c5ce32dee zcash_client_backend: Use `NonNegativeAmount` for `select_spendable_notes` 2024-03-08 13:48:30 -07:00
Kris Nuttycombe cb4b9f80bc zcash_protocol: Add `TryFrom<&MemoBytes>` for `Memo` 2024-03-08 13:48:30 -07:00
Kris Nuttycombe dbf7c85afe
Merge pull request #1237 from zcash/faster-ci
Faster CI
2024-03-08 13:48:16 -07:00