52abb1f057
Merge pull request #1473 from nuttycom/wallet/enrichment_queue
...
Add queues to track the need for transaction enhancement and/or verification of mined status.
2024-08-10 00:37:23 +01:00
69828bc0d0
zcash_client_sqlite: Add `target_height` column to `transactions` table.
2024-08-06 12:25:44 -06:00
1057ddb516
zcash_client_sqlite: Add a table to track transaction status and enrichment requests.
2024-08-06 12:25:44 -06:00
5a4a3e06dc
Make `nu6` rust feature stable ( #1454 )
2024-08-06 00:01:03 +01:00
b3dad95de0
zcash_primitives: Use `TxId` type inside `transparent::OutPoint`
...
This doesn't affect the public API, but it improves the `Debug` impl for
`OutPoint` because `TxId` renders its `[u8; 32]` as byte-reversed hex.
2024-07-27 00:38:22 +00:00
3cec9ee4a7
zcash_client_sqlite: Store received UTXOs in `store_decrypted_tx`.
...
This fixes an issue wherein transparent outputs of transactions added to
the wallet via `decrypt_and_store_transaction` would not be properly
recorded as UTXOs belonging to the wallet.
Part of #1434
2024-07-26 15:47:16 -06:00
a5e467f335
Merge pull request #1451 from zcash/devtools
...
Import `zcash-inspect` from `zcash/zcash` into a `devtools` crate
2024-07-22 19:31:32 +01:00
eceb8c7ff5
Merge pull request #1442 from hattizai/patch001
...
chore: remove duplicate words
2024-07-22 11:49:24 -06:00
8f26eb9de4
devtools: Integrate `zcash-inspect` into workspace
2024-07-22 13:56:59 +00:00
24b6d50d77
Apply suggestions from code review
...
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
2024-07-17 07:51:58 -06:00
27ca6e44d6
Remove unneeded `impl SealedChangeLevelKey for EphemeralIvk`.
...
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-07-04 20:13:35 +01:00
6bc22f411e
Documentation fixes and improvements.
...
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-07-04 20:13:35 +01:00
01ff201ffb
Minor changes responding to review comments.
...
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-07-04 05:24:32 +01:00
2244e0ff77
remove duplicate words
2024-07-03 11:01:40 +08:00
9c082dca3e
`zcash_primitives::transaction::fees::zip317::FeeRule::non_standard` has
...
been deprecated, because in general it can calculate fees that violate
ZIP 317, which might cause transactions built with it to fail. Maintaining
the generality of the current implementation imposes ongoing maintenance
costs, and so it is likely to be removed in the near future.
Use `transaction::fees::zip317::FeeRule::standard()` instead to comply
with ZIP 317.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-28 19:03:08 +01:00
b77813933a
Refactor ephemeral output-related parameters to balance calculation.
...
This now only supports a single ephemeral input and/or output when
constructing a proposal (multiple ephemeral outputs are still supported
when creating transactions).
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-27 01:45:45 +01:00
eb8846162c
Address review comment: `EphemeralIvk` should not implement `IncomingViewingKey`.
...
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-25 08:40:08 +01:00
2fae4bb244
ZIP 320 implementation.
...
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Co-authored-by: Jack Grigg <str4d@electriccoin.co>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-25 08:40:08 +01:00
41c30ef44d
"child index" -> "address index" where applicable.
...
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-18 21:24:33 +01:00
9881e811ea
Miscellaneous documentation improvements.
...
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-18 21:24:33 +01:00
6f4a3b107e
Address a review comment concerning `Vector::serialized_size`.
...
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-18 21:06:42 +01:00
9881861228
Add `zcash_encoding::{CompactSize, Vector}::serialized_size` and
...
`zcash_primitives::legacy::Script::serialized_size`. Use the latter in
`zcash_primitives::transaction::fees::transparent::OutputView::serialized_size`.
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-18 21:06:39 +01:00
17af8e32e8
Refactor `FeeRule::fee_required` to take the sizes of transparent
...
inputs and outputs.
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-18 21:05:49 +01:00
6d35583a4b
Add `OutPoint::fake()` helper.
...
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-18 21:03:22 +01:00
f54ee4abde
Migrate from `hdwallet` to `bip32`
...
As part of this, we migrate to `secp256k1 0.27`. This version does not
bump `secp256k1-sys`, so remains compatible with the `libsecp256k1`
revision used in `zcashd`.
The `zcash_primitives::legacy::keys::AccountPrivKey` encoding also
changes to preserve the transparent extended key metadata. Previously
the type was documented as such, but only encoded the private key and
chain code; the new encoding now matches the documentation. As a side
effect, the unstable encoding of `zcash_keys::keys::UnifiedSpendingKey`
also changes.
Closes zcash/librustzcash#1407 .
Closes zcash/librustzcash#1408 .
2024-06-15 00:04:37 +00:00
4cd96f30a1
Fix clippy lints exposed by the MSRV bump to 1.70.0.
...
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
2024-06-12 14:51:29 +01:00
bb6c3a6a1a
Revert "ZIP 339 support."
...
This reverts commit d1443e5049
2024-05-14 10:12:50 +01:00
bda72e36eb
Put expensive tests behind an additional `expensive-tests` feature flag.
2024-03-25 13:27:42 -06:00
6898dbf094
Replace `unstable-nu6` and `zfuture` feature flags with cfg flags
...
Neither of these should have been feature flags, as they gate breaking
changes to the Zcash consensus rules (and in some ways are incompatible
with each other), while feature flags should be additive.
2024-03-10 18:42:39 +00:00
51d4464472
Remove `network_type` calls that are obviated by the blanket impl.
2024-03-05 13:36:15 -07:00
04fdac7931
zcash_primitives: Move the `memo` module to the `zcash_protocol` crate.
2024-03-05 13:36:15 -07:00
4b18426fcd
zcash_address: Use `zcash_protocol::consensus::NetworkType`
...
This inverts the dependency relationship between `zcash_protocol` and
`zcash_address`, permitting the network constants (primarily the HRPs)
defined in `zcash_protocol` to be used directly in `zcash_address`
instead of being duplicated.
2024-03-05 13:36:15 -07:00
85d1ca251a
zcash_primitives: Move the `local-consensus` module to the `zcash_protocol` crate.
2024-03-05 09:45:24 -07:00
7188482225
zcash_protocol: Rename value amounts to `Zatoshis` and `ZatBalance`
2024-03-05 09:45:24 -07:00
5e4d9abbce
Move `Amount` and `NonNegativeAmount` types to the `zcash_protocol` crate.
2024-03-05 09:45:24 -07:00
bacfe3cb9d
Move `zcash_primitives::{consensus, constants}` to the `zcash_protocol` crate
2024-03-05 09:45:24 -07:00
7a5852598e
zcash_keys, zcash_client_backend: feature-flag off transparent-input WalletRead methods.
...
This also moves the `TransparentAddressMetadata` type behind the
`transparent-inputs` feature flag and performs associated cleanup.
2024-02-14 17:38:52 -07:00
9f221f869d
Fail instead of swallow on database corruption
2024-02-13 11:39:06 -07:00
8003a39e1b
Add test coverage
2024-02-13 11:39:06 -07:00
918f5cc812
Change `WalletRead::get_transparent_receivers` signature
...
It needn't return the account id that was given as an input, and it shouldn't return an 11-byte diversifier index when a 31-bit child index is more appropriate.
2024-02-13 11:39:06 -07:00
1733af8718
Declare `NonHardenedChildIndex` struct
2024-02-10 12:46:46 -07:00
2360609f1a
zcash_primitives: Rename `TransparentAddress` variants.
...
This resolves an old TODO.
2024-02-02 10:52:17 -07:00
dca890adcd
Merge pull request #1102 from zcash/doc-improvements
...
Various documentation improvements
2024-01-25 21:02:01 +00:00
4873e2586f
zcash_primitives: Adjust doc comment on `BlockHash`
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2024-01-25 19:17:21 +00:00
3a0b634101
Merge pull request #1103 from nerdcash/docFixes
...
Doc improvements
2024-01-23 16:19:50 +00:00
296e770ec8
Update zcash_primitives/src/transaction/fees/zip317.rs
...
Co-authored-by: str4d <thestr4d@gmail.com>
2024-01-18 17:48:56 -07:00
09bbc79669
Fix rustfmt
2024-01-18 14:58:04 -07:00
aabee02247
Doc improvements
2024-01-17 21:33:12 -07:00
17f074d460
PR Suggestion by @nuttycom: remove the `FullNodeParameters` enum
2024-01-17 18:55:21 -03:00
529fd3d562
Add Regtest variant of `Network` and Parameter
...
closes #1051
Also:
Adds encoding tests + cargo fmt
Adds tests on ZIP-321
Adds coverage on new code
Supports nu6 activation
`local-consensus` feature is disabled by default
2024-01-17 18:21:06 -03:00
Jack Grigg
Kris Nuttycombe
Alfredo Garcia
Daira-Emma Hopwood
hattizai
Andrew Arnott
Francisco Gindre