Commit Graph

2678 Commits

Author SHA1 Message Date
Kris Nuttycombe 9b8b9ed189 This reverts a previous incorrect change to the changelog.
The MSRV bump was actually in `zcash_history` 0.3.0, even though the
addition of that to the Cargo.toml file was post-0.3.0 release.
2022-10-19 16:05:04 -06:00
Kris Nuttycombe 4ed64e4820
Merge pull request #682 from nuttycom/fix/zcash_encoding_changelog
Fix changelog for `zcash_encoding`
2022-10-19 15:54:23 -06:00
Kris Nuttycombe 42fd3c1091 Fix changelogs for `zcash_encoding` and `zcash_history` 2022-10-19 15:52:42 -06:00
Kris Nuttycombe ccb0444b6d
Merge pull request #681 from zcash/update-orchard
Update zcash_primitives to orchard 0.3; release zcash_primitives and zcash_proofs 0.8.
2022-10-19 14:50:51 -06:00
Kris Nuttycombe 5bf36989e2 Fix beta clippy complaints. 2022-10-19 13:35:51 -06:00
Sean Bowe 176e21b015
Update zcash_primitives to orchard 0.3; release zcash_primitives and zcash_proofs 0.8. 2022-10-19 13:32:51 -06:00
str4d 49bdd86908
Merge pull request #678 from zcash/dependabot/github_actions/actions/cache-3.0.11
build(deps): bump actions/cache from 3.0.10 to 3.0.11
2022-10-15 01:06:52 +01:00
Kris Nuttycombe 022964056f
Merge pull request #679 from zcash/daa-fix-missing-bound
zcash_client_backend: Fix missing bound
2022-10-14 15:29:54 -06:00
Jack Grigg b3dc323876 zcash_client_backend: Fix missing bound
In 47a0d0d2b7 `WalletWriteTransparent` was
merged into `WalletWrite`, including its associated type `UtxoRef`.
However, `shield_transparent_funds` placed a bound on this associated
type that was not moved to `WalletWrite`. This left the generic
parameter `U` unconstrained, which didn't cause a local failure because
the method has no local tests, but was immediately apparent when trying
to use the method in the mobile SDKs.
2022-10-14 20:45:35 +00:00
str4d 5301b9c9d3
Merge pull request #677 from nuttycom/wallet/decrypt_marks_utxos_spent
Mark our utxos spent when we detect them as inputs to a transaction.
2022-10-14 21:12:21 +01:00
Kris Nuttycombe c773ea3b3e Make the internals of `WalletTransparentOutput` private. 2022-10-14 12:38:55 -06:00
Kris Nuttycombe 69791af92c Mark our utxos spent when we detect them as inputs to a transaction.
This modifies `decrypt_and_store_transaction` to check for inputs
to a transaction being decrypted that correspond to utxos known
to our wallet. For each such UTXO found, it is marked spent.
2022-10-14 10:40:43 -06:00
Kris Nuttycombe 85f69fa787
Merge pull request #676 from nuttycom/wallet/remove_feature_extensions
Remove the `WalletReadTransparent` and `WalletWriteTransparent` extension traits.
2022-10-14 07:47:48 -06:00
dependabot[bot] fb299e2988
build(deps): bump actions/cache from 3.0.10 to 3.0.11
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.10 to 3.0.11.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3.0.10...v3.0.11)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-14 05:14:02 +00:00
Kris Nuttycombe 47a0d0d2b7 Remove the `WalletReadTransparent` and `WalletWriteTransparent` extension traits.
These traits introduce a problem, in that constraints on a method cannot
be conditionally required based upon the presence or absence of a
feature flag. Instead, we make the methods previously introduced by
the removed traits present in all cases on the `WalletRead` and
`WalletWrite` traits, but ensure that their implementations return
an error if the caller attempts to use them in a wallet that has not
been configured with support for transparent inputs functionality.
2022-10-13 21:05:49 -06:00
str4d 1a20fc1578
Merge pull request #675 from zcash/zcash_note_encryption-0.2.0
zcash_note_encryption 0.2.0
2022-10-13 23:23:12 +01:00
Jack Grigg cf5af3edbc Point to `orchard` commit with `zcash_note_encryption 0.2` 2022-10-13 21:42:46 +00:00
Jack Grigg 8f068b3b71 zcash_note_encryption 0.2.0 2022-10-13 21:35:39 +00:00
Jack Grigg 9a010d42ff zcash_note_encryption: Clean up changelog and readme
We no longer depend on the previously-mentioned dependencies.
2022-10-13 21:23:09 +00:00
Kris Nuttycombe d9dac00ac7
Merge pull request #674 from zcash/remove-unused-deps
Remove unused dependencies
2022-10-13 14:41:40 -06:00
Jack Grigg 8842de18cc Remove unused dependencies
These were mostly detected with `cargo-udeps`, for which I've also added
exclusions for the dependencies it can't detect are used in doc-tests.
2022-10-13 20:06:52 +00:00
Kris Nuttycombe 2a00d65226
Merge pull request #672 from nuttycom/wallet/autodetect_utxo_account
Remove `received_by_account` field from WalletTransparentOutput
2022-10-13 13:08:01 -06:00
Kris Nuttycombe 5864e71eec
Add comment to call out the storage details of diversifier indices.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-10-13 10:38:59 -06:00
Kris Nuttycombe 306d37e706 Add a test verifying that update fails on missing associated address. 2022-10-13 09:13:14 -06:00
Kris Nuttycombe 90f67ee23d
Merge pull request #673 from zcash/group-0.12.1
zcash_primitives: Require `group 0.12.1` for `wnaf-memuse` feature flag
2022-10-13 07:48:37 -06:00
Jack Grigg 24f7d1c9bc zcash_primitives: Require `group 0.12.1` for `wnaf-memuse` feature flag 2022-10-13 06:19:34 +00:00
Kris Nuttycombe f1f9465f37 Remove `received_by_account` field from WalletTransparentOutput
Due to how the wallets retrieved unspent transparent outputs from the
light wallet server, the account associated with a particular UTXO may
not be known by the light wallet. Instead of requiring the caller to
perform a separate lookup and match the address of the received UTXO
with a known account, it's simpler to perform this lookup internally at
the time of insertion or update.

In order to make this operation more efficient, the `addresses_table`
migration is modified to add a column to cache the transparent receiver
so that it may be used in the joins in the UTXO insert and update
operations.
2022-10-12 23:11:39 -06:00
str4d 59a4dd6efc
Merge pull request #665 from nuttycom/wallet/transaction_views_add_account
Add more information to v_transactions, v_sent_tx, and v_received_tx
2022-10-13 00:38:37 +01:00
Kris Nuttycombe 5a2f659594 Ensure that only purely wallet-internal tx are returned as internal.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2022-10-12 16:53:00 -06:00
Kris Nuttycombe e6f039d0f9 Allow multiple migrations to be specified for custom wallet init.
Since our migrations form a DAG, it doesn't make sense to only allow a
single migration to be specified for wallet initialization; instead,
allow multiple migrations so that one can hit all the desired leaves.
2022-10-12 12:35:27 -06:00
Kris Nuttycombe f7a3b9bda3
Merge pull request #661 from nuttycom/wallet/spend_with_usk
Use unified spending keys for spends & shielding.
2022-10-12 12:15:34 -06:00
Kris Nuttycombe c3b6ef28c9
Merge pull request #647 from nuttycom/update_ua_test_vectors
Update unified address test vectors
2022-10-12 10:56:26 -06:00
Kris Nuttycombe 6893da3054
Update zcash_client_backend/src/keys.rs
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-10-12 09:19:44 -06:00
Kris Nuttycombe 85390cb8ce Add more information to v_transactions, v_sent_tx, and v_received_tx
This adds sent and received note count information, transaction fees,
account information, and makes the information returned about sent
notes and received notes consistent with one another.
2022-10-12 08:52:37 -06:00
Kris Nuttycombe f689018fcd
Merge pull request #659 from nuttycom/wallet/decrypt_with_internal_key
Track inputs sent to wallet-internal recipients
2022-10-11 16:57:54 -06:00
str4d e1d4229a68
Merge pull request #671 from zcash/fix-git-deps
Fix git dependencies
2022-10-11 23:26:59 +01:00
Kris Nuttycombe e666e69230 Address comments from code review. 2022-10-11 16:21:17 -06:00
Kris Nuttycombe fdf5aa7b8e Fix exclusive or in sent_notes recipient check. 2022-10-11 15:49:52 -06:00
Jack Grigg f27d3bca7f CI: Switch back to published cargo-tarpaulin releases
The llvm-profparser branch has been merged and deleted.
2022-10-11 20:42:52 +00:00
Kris Nuttycombe 62e1f99eb0 Improve TransferType documentation. 2022-10-11 14:42:06 -06:00
Jack Grigg 1d8fca848e Point to upstream schemer repository
We can do this now that https://github.com/aschampion/schemer/pull/15
has been merged.
2022-10-11 20:40:41 +00:00
Kris Nuttycombe fd1640c242 Update CHANGELOGs 2022-10-11 13:08:15 -06:00
Kris Nuttycombe 3c837381db Disallow invalid pool/address combinations with `Recipient`. 2022-10-11 12:52:44 -06:00
Kris Nuttycombe 56b2edd498 Simplify sqlite backend storage for sent notes & utxos.
The currently deprecated implementations of `insert_sent_utxo`,
`insert_sent_note`, `put_sent_utxo` and `put_sent_note` all store to the
same `sent_notes` table internally. Since there's no immediate plan to
change this arrangement, it's better to have a single pair of internal
`insert_sent_output` and `put_sent_output` methods instead.
2022-10-11 08:57:44 -06:00
Kris Nuttycombe ee9869bbeb Use declarative style for `decrypt_transaction` 2022-10-11 08:56:26 -06:00
Kris Nuttycombe 06e43a572a Track inputs sent to wallet-internal recipients.
Ensure that we're attempting trial-decryption with the internal IVK
and correctly track internal vs. external recipients in the wallet
database.
2022-10-11 08:56:22 -06:00
str4d 1dc3cfe724
Merge pull request #657 from nuttycom/wallet/upsert_utxos
Use upsert functionality for transparent UTXOs, rather than delete/repopulate.
2022-10-11 04:17:49 +01:00
Daira Hopwood 709577cec7
Merge pull request #666 from upbqdn/temporarily-fix-params-download
zcash_proofs: Temporarily fix params download
2022-10-09 00:36:58 +01:00
Kris Nuttycombe bd8472535c Add a test for unified address derivation. 2022-10-07 20:37:39 -06:00
Kris Nuttycombe 34a7abd653 Update unified address test vectors
This updates unified address test vectors after
https://github.com/zcash-hackworks/zcash-test-vectors/pull/89
to check addresses across multiple diversifier indices, and also
removes the superfluous binary encoding of UA strings.
2022-10-07 19:50:32 -06:00