b88adb4e82
Release 0.8.1
2023-10-18 14:58:03 -06:00
914c0ed5c9
Add regression test for incorrect note deduplication in `v_transactions`.
...
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-18 14:54:46 -06:00
2873dd4b60
zcash_client_sqlite: Fix incorrect note deduplication in `v_transactions`
...
The `v_transactions` view is built upon the set of received notes,
received note values being added to the balance for the transaction and
spent notes being deducted from this balance. This fixes an error
wherein if multiple identically-valued notes were spent in a
transaction, only one of those notes' values was being counted as having
been spent.
2023-10-18 14:54:31 -06:00
f70a4fe29e
Merge pull request #1020 from nuttycom/wallet/v_transactions_note_uniqueness
...
zcash_client_sqlite: Fix incorrect note deduplication in `v_transactions`
2023-10-18 09:36:42 -06:00
11e909a2d1
Add regression test for incorrect note deduplication in `v_transactions`.
...
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-18 00:41:34 +01:00
0de652c687
zcash_client_sqlite: Fix incorrect note deduplication in `v_transactions`
...
The `v_transactions` view is built upon the set of received notes,
received note values being added to the balance for the transaction and
spent notes being deducted from this balance. This fixes an error
wherein if multiple identically-valued notes were spent in a
transaction, only one of those notes' values was being counted as having
been spent.
2023-10-13 15:28:50 -06:00
29c676ff12
Merge pull request #1009 from tw0po1nt/fix_txn_builder_panic
...
Gracefully handle when given an Orchard-only UA
2023-10-12 18:15:36 -06:00
c4c2c59211
Merge pull request #1012 from nuttycom/wallet/proposal_change_memos
...
zcash_client_backend: Move change memos into the `ChangeValue` components of `Proposal`s
2023-10-12 11:51:08 -06:00
a788cc4c4d
Fix merge conflicts
2023-10-12 06:16:22 -05:00
bcea060c86
Apply suggestions from code review
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-11 14:15:19 -06:00
1447d8ea01
zcash_client_backend: Move change memos into the `ChangeValue` components of `Proposal`s.
...
The existing API limited change outputs to having only a single memo
repeated across each change output. This change makes it so that each
proposed change output can have its own associated memo, and leaves it
up to the input selector to determine how requested change memos are
associated with change outputs.
2023-10-11 14:15:19 -06:00
0ad81a09c0
Merge pull request #1013 from nuttycom/wallet/nonnegative_fees
...
zcash_client_backend: Use `NonNegativeAmount` for fee and change amounts.
2023-10-11 13:58:41 -06:00
a2b5c2c784
zcash_client_backend: Use `NonNegativeAmount` for fee and change amounts.
...
In order to use `uint64` for amounts that must be nonnegative in the
`proposal.proto` file, it is useful to update fee and change computation
to use `NonNegativeAmount` where possible.
2023-10-10 16:12:47 -06:00
030c1825a8
Merge pull request #1011 from nuttycom/wallet/note_identifiers
...
Make `ReceivedSaplingNote` internals private, and use (TxId, output_index) for note identifiers.
2023-10-10 07:30:33 -06:00
73f263682e
Remove unnecessary local
2023-10-10 07:50:07 -05:00
2a4d9e06da
Run fmt
2023-10-10 07:47:08 -05:00
b548e00c10
Update zcash_client_sqlite/src/wallet.rs
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-10 06:36:40 -05:00
0e5a58b0b0
Update zcash_client_sqlite/src/wallet.rs
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-10 06:36:20 -05:00
5de3fbb36b
Fix logic error
2023-10-10 06:35:38 -05:00
17013076ae
Merge pull request #1005 from zingolabs/add_marginal_fee
2023-10-09 16:55:07 -06:00
4bd3259ad0
Add a MARGINAL_FEE constant for the ZIP 317 marginal fee
2023-10-09 15:23:55 -06:00
5b40ddf072
zcash_client_backend: Use globally unique identifiers for notes.
...
Update zcash_client_backend error types to use (TxId, output_index)
as the identifier for notes instead of the internal database identifier.
2023-10-09 12:44:27 -06:00
74840829c8
zcash_client_backend: Make `ReceivedSaplingNote` internals private.
...
This also adds the txid and index to `ReceivedSaplingNote` for use as a
globally identifier for the note.
2023-10-09 12:22:12 -06:00
13a2d5d7d4
Update wallet.rs
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-09 10:07:31 -05:00
4bbe658f74
Update CHANGELOG.md
...
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-09 10:06:37 -05:00
a910fb86b6
Revert unnecessary change
2023-10-09 06:57:40 -05:00
c4175342ac
Cleanup
2023-10-09 06:46:12 -05:00
9d7ac07b1a
Fix test build failures
2023-10-08 19:37:02 -05:00
029b7f0d69
Document fallback behavior for Orchard-only UAs
2023-10-08 19:27:20 -05:00
46ed4964c3
Display for PoolType
2023-10-08 19:19:51 -05:00
94f2240e08
Provide PoolType to UnsupportedPoolType case; stylistic changes
2023-10-08 19:05:50 -05:00
a9d18ec2ce
Gracefully handle attempted spend to a UA with neither transparent nor sapling recipients
2023-10-07 15:37:35 -05:00
a47b512f59
Merge pull request #1007 from zcash/sapling-trymapauth-etc
...
Changes to Sapling bundle mapping
2023-10-07 13:25:24 -06:00
e1a4238a71
zcash_primitives: Add helper impls of `{Try}MapAuth` for closures
2023-10-06 23:48:27 +00:00
65efee1a16
zcash_primitives: Add `sapling::Bundle::try_map_authorization`
2023-10-06 23:46:02 +00:00
b09b435135
zcash_primitives: Change `sapling::MapAuth` to take `&mut self`
2023-10-06 23:43:43 +00:00
241a1a3660
zcash_primitives: Add some more `Clone` and `Debug` impls
2023-10-06 22:05:49 +00:00
4737839662
Merge pull request #1006 from zcash/spend-output-prover-updates
...
Updates to `SpendProver` and `OutputProver` traits and impls
2023-10-06 23:01:07 +01:00
04aa5a044b
zcash_primitives: Add `MockSpendProver` and `MockOutputProver`
...
These are analogues of `MockTxProver` in that they implement the
corresponding Sapling prover traits.
2023-10-06 20:31:31 +00:00
46903fabf5
zcash_proofs: `impl {SpendProver, OutputProver} for LocalTxProver`
2023-10-06 20:28:16 +00:00
296f75954b
Add `SpendProver::encode_proof` and `OutputProver::encode_proof`
2023-10-06 20:19:41 +00:00
e6fa567332
Merge pull request #1000 from zingolabs/add_debugs_to_inputs
...
add Debug to transaction builder-reported types
2023-10-04 09:15:29 -06:00
b73c51f974
Merge pull request #1004 from zingolabs/add_fee_getter
...
Add fee getter
2023-10-03 12:04:29 -06:00
b9f8ec8ed2
add pub getter to transaction builder
...
use getter in original context to DRY
add doc-comment
Minor cleanup & documentation fixes.
Co-Authored-By: Daira Emma Hopwood <daira@jacaranda.org>
2023-10-03 11:13:06 -06:00
ad01585d34
Merge pull request #1001 from zcash/752-separate-sapling-provers
...
Separate Sapling provers
2023-10-02 18:47:47 +01:00
0d46fe72cc
zcash_primitives: Introduce an `OutputProver` trait
2023-10-02 16:59:01 +00:00
290bfa8b31
zcash_primitives: Introduce a `SpendProver` trait
2023-10-02 16:59:01 +00:00
ea0fed39eb
zcash_proofs: Introduce newtype wrappers for Sapling parameters
2023-10-02 16:59:01 +00:00
2bfeef9430
zcash_proofs: Remove immediate verification of created Spend proofs
...
It can be useful to verify proofs after they have been created, but we
were only doing this for spend proofs, not output proofs. It also
duplicated code from the verifier logic. Once the prover and verifier
have been refactored, it will be easier to just call the verifier
immediately after the prover.
2023-10-02 16:59:01 +00:00
eca7112963
Merge pull request #999 from zcash/737-move-sapling-circuits
...
Move Sapling circuits from `zcash_proofs` to `zcash_primitives::sapling`
2023-10-02 17:32:19 +01:00
Sean Bowe
Daira Emma Hopwood
Kris Nuttycombe
Matthew Watt
Kris Nuttycombe
Matthew Watt
zancas
sasha
Jack Grigg