60785a1d7a
Fix Sapling key organization.
...
This change moves Sapling-specific key generation into a
submodule of `zip32`. Public reexports are used to keep the
existing API consistent.
2022-10-03 20:28:04 -06:00
f7aa7b2c84
Upgrade rusqlite to version 0.25
2022-10-03 08:12:37 -06:00
e54e3f21e8
zcash_client_sqlite: Remove direct ff dependency
2022-10-02 23:16:44 +01:00
f8fd27653c
Add a BlockSource implementation that reads blocks from files in the filesystem.
...
Also, this adds functionality to create and insert records into the
block metadata db that is used as the source for which blocks to read.
2022-09-15 08:27:26 -06:00
d086c57f2f
Make init_accounts_table only permit sequential account identifiers.
...
Also, check to ensure that account creation does not exceed the
maximum account identifier value.
2022-09-14 13:55:31 -06:00
75eb082203
Apply suggestions from code review
...
Co-authored-by: str4d <thestr4d@gmail.com>
2022-09-14 12:20:39 -06:00
d0062a87d4
Add WalletWrite::create_account function
2022-09-13 18:58:28 -06:00
b5908dc964
Merge pull request #632 from nuttycom/data_api/get_next_address
...
Replace `get_address` with `get_current_address` and `get_next_available_address`
2022-09-12 18:43:38 -06:00
03b0ff7e0a
Replace `get_address` with `get_current_address` and `get_next_available_address`
...
This updates the data access API to provide diversified address
functionality. In order to support this change, the addresses table
is updated to store diversifier index information in big-endian order
to allow sorting by diversifier index, and account initialization
is updated to store the diversifier index accordingly. The currently
unreleased `addresses_table` migration is updated to reflect this
change.
2022-09-12 17:58:22 -06:00
95610f7b4f
Add fee to the transactions table & compute correct net_value in v_transactions.
2022-09-09 16:12:29 -06:00
7112ed9da5
zcash_client_backend: Add `WalletReadTransparent::get_transparent_receivers`
...
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
2022-09-08 20:24:42 +00:00
a32714043b
zcash_client_backend: Change `WalletRead::get_address` to return UA
2022-09-08 18:49:13 +00:00
4f5d757883
zcash_client_backend: Change to `WalletWrite::remove_unmined_tx`
...
This fixes a bug in the logic ported from the Android SDK: it was
possible to remove a transaction in the middle of a chain, which would
cause a long-spent note to become unspent and cause the wallet balance
to be over-counted. We now restrict transaction removal to unmined
transactions, which is sufficient for the Android SDK use cases.
2022-08-30 22:54:58 +00:00
586b7e5bb0
zcash_client_backend: Add `WalletWrite::remove_tx` method
...
This is to replace the database mutations in the Android SDK. It is
placed behind an `unstable` feature flag until we are satisfied that it
is suitable as a general-purpose API (or replace it).
2022-08-29 21:32:18 +00:00
04b1d505b2
zcash_client_sqlite: Move `DataConnStmtCache` into submodule
...
This removes direct access to the prepared statements, instead forcing
callers to use the type-safe methods added in the previous commit.
2022-08-29 19:25:36 +00:00
12e8c53310
zcash_client_sqlite: Add statement helper methods to `DataConnStmtCache`
...
These methods provide type-safe ways to interact with the prepared
statements.
2022-08-29 19:25:36 +00:00
439e8f2599
zcash_client_sqlite: Add `DataConnStmtCache::new` constructor
...
This is a move-only commit (other than the necessary variable renames).
2022-08-29 15:26:08 +00:00
199c49760b
Use the new name rustdoc::broken_intra_doc_links
2022-07-29 15:56:44 -06:00
f1c2da7b1d
Add sapling::NullifierDerivingKey newtype.
...
Nullifier computation only requires the nullifier deriving key,
not the entire Sapling viewing key. This separation of concerns
will be needed for batch decryption when wallet-internal keys
will need to be considered.
2022-07-28 15:23:21 -06:00
115d4b975e
Don't rely on alignment between account IDs and keys when initializing the accounts table.
2022-06-29 10:13:13 -06:00
b52e949bd6
zcash_client_backend: Migrate to correct ZIP 316 UFVK encoding
...
We also add support for parsing Orchard full viewing keys from encoded
UFVKs (rather than treating them as unknown). `UnifiedSpendingKey` still
does not have Orchard support, so `UnifiedFullViewingKey`s will be
generated without Orchard components.
2022-06-17 10:03:17 +00:00
76d015ed11
zcash_client_backend: Fix `UnifiedFullViewingKey` Sapling item type
...
Per ZIP 316, the Sapling FVK Encoding only includes `(ak, nk, ovk, dk)`
which is a subset of the Sapling `ExtendedFullViewingKey`. We therefore
need to use `DiversifiableFullViewingKey` inside `UnifiedFullViewingKey`
in order to make it parseable from the UFVK string encoding.
`zcash_client_sqlite::wallet::get_extended_full_viewing_keys` has been
removed as a consequence of this change: we can no longer reconstruct
the correct `ExtendedFullViewingKey` from the `UnifiedFullViewingKey`.
2022-06-17 10:03:17 +00:00
d8b860207d
zcash_client_backend: Remove account from `UnifiedFullViewingKey`
...
The account number is not stored in the ZIP 316 UFVK encoding, and in
general won't necessarily be known (e.g. if a UFVK is being imported
into a wallet).
`zcash_client_sqlite::wallet::init::init_accounts_table` reverts to its
previous behaviour of requiring the provided `&[UnifiedFullViewingKey]`
to be indexed by account number.
2022-06-17 10:03:17 +00:00
c0e8ee0fa0
zcash_client_backend: Return UFVKs from `WalletRead` instead of ExtFVKs
2022-06-17 10:03:17 +00:00
0d0527dbf3
zcash_client_sqlite: Store UFVK/UA instead of Sapling ExtFVK/address
...
This is a breaking change to the database format. We don't have support
for migrations yet, so existing wallets won't work after this commit
until zcash/librustzcash#489 is done.
2022-06-14 02:18:25 +00:00
ed6016857e
zcash_client_backend: Add `RecipientAddress::Unified`
2022-06-10 17:16:59 +00:00
cceae3ac34
zcash_client_backend: Address compact_formats.proto comments
2022-02-17 23:58:20 +00:00
18562c71dc
zcash_client_backend: Bring in latest `compact_formats.proto`
...
Source: 83bb19918f/walletrpc/compact_formats.proto
2022-02-17 02:44:20 +00:00
e20de50b84
Make AccountId internal representation private.
2022-02-10 11:30:02 -07:00
a304c3953b
Fix Clippy beta linting complaints.
2022-02-02 16:02:45 -07:00
488d13fde3
Do not delete sent note data in rewind.
2022-02-02 12:48:22 -07:00
9c2d485c80
Address comments from code review.
...
Co-authored-by: str4d <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-02-02 10:33:41 -07:00
2dd0348792
Remove the `nullifiers` argument from `store_decrypted_tx`
...
This value can be obtained internally within the implementation
of `store_decrypted_tx` and does not need to be part of the
public API.
2022-02-02 10:32:35 -07:00
3d51c53d68
Address comments from code review.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-02-02 10:32:33 -07:00
d0e1f98429
Use extension traits for transparent-related data api functionality.
2022-02-02 10:30:43 -07:00
e8e5d94ea6
Mark functions that will be made crate-private as deprecated
2022-02-02 10:29:19 -07:00
6fcdfda69e
Derive OVKs from transparent account-level key, not child keys.
...
This also renames a number of legacy key types to better reflect
their intended use.
2022-01-26 13:36:27 -07:00
f58d191439
Move transparent account keys to zcash_primitives.
2022-01-25 08:53:51 -07:00
15eb5aab50
Fix a minor naming error in AccountPubKey
2022-01-21 19:08:26 -07:00
7d873e9d79
Fix test compilation errors related to UFVK construction.
2022-01-21 19:01:32 -07:00
79bd2f7733
Add missing documentation & rustfmt.
2022-01-20 20:14:44 -07:00
ffc4d0cefb
Add newtypes for transparent keys at the account & external levels.
...
This updates UnifiedFullViewingKey to conform to ZIP 316, and
adds types that facilitate this support. These types should likely
be factored out from `zcash_client_backend` into `zcash_primitives`
along with the remainder of the existing unified address support.
2022-01-20 20:03:20 -07:00
37e6d3a2bc
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: ying tong <yingtong@z.cash>
2022-01-20 16:43:57 -07:00
fc0dd8e3eb
Merge remote-tracking branch 'upstream/master' into autoshield-poc-daa
2021-10-25 13:24:03 -06:00
120cc70a6d
Fix type of default_address
2021-10-11 16:34:37 -06:00
cc58a21ad7
Feature-flag transparent functionality in zcash_client_sqlite
...
This fixes the wasm32-wasi build issues by excluding the
hdwallet dependencies which are not wasm32-wasi compatible.
2021-10-04 16:53:55 -06:00
d43a893c72
Apply suggestions from code review & update changelog
...
Co-authored-by: str4d <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-10-01 12:03:06 -06:00
db89569b90
Address documentation & naming requests from code review.
2021-10-01 11:03:09 -06:00
b783c4d0e7
Merge remote-tracking branch 'upstream/master' into autoshield-poc-daa
2021-08-12 11:21:30 -06:00
1a5aad723b
Use generalized signature_hash for transaction builder.
2021-06-04 15:45:39 -06:00
55d1090f70
Add v5 txid & signature hashing.
2021-06-04 15:45:39 -06:00
84e8952ec3
Move Sapling components to a bundle within TransactionData
2021-06-03 18:46:38 -06:00
4efb21d1c7
Make amount addition and subtraction traits use checked operations.
2021-06-01 07:03:31 -06:00
8e3e7de50c
Minor code cleanup.
2021-05-14 14:17:42 -06:00
7fc2d9725c
Placeholder commit: just get things working.
...
Clean up later but for now don't allow nullable accountIds and also delete more data, during a rewind.
2021-04-20 10:13:47 -04:00
c1bc06964f
Add get_all_nullifiers.
2021-04-16 14:27:18 -06:00
bb68744df1
Ensure that rewinds go far enough to properly restore incremental witness state.
2021-04-16 14:27:18 -06:00
9b3025de4d
Add ZIP-321 request based sends to zcash_client_backend.
2021-04-16 14:26:53 -06:00
8e16d93f94
Update accounts table create statement.
...
This PR makes the opinionated change that T-addrs are required
to be supported when using the zcash_client_sqlite backend.
2021-04-16 14:26:53 -06:00
665c4c7aff
Figure out the account ID for z->t spends.
2021-04-16 14:26:53 -06:00
13cd7498b7
Store vout as part of store_decrypted_tx
2021-04-16 14:26:53 -06:00
8828276361
Query for unspent utxos checks to ensure that spending tx is mined.
...
Also make it an error to try to send a memo to a transparent address.
2021-04-16 14:26:51 -06:00
a3bc1e3e63
Rename get_spendable -> get_unspent
2021-04-16 14:23:28 -06:00
862e221a9b
Put transparent dependencies behind a feature flag.
2021-04-16 14:23:26 -06:00
cff457ff15
PoC Auto-Shielding
...
Add retrieval of transparent UTXOs to WalletRead
Co-authored-by: Kris Nuttycombe <kris@electriccoin.co>
Co-authored-by: Kevin Gorham <anothergmale@gmail.com>
2021-04-16 14:22:16 -06:00
e77839232d
Generalize note encryption and decryption.
...
This commit introduces a `Domain` trait which defines the types
and operations that are shared between Sapling and Orchard note
encryption and decryption processes.
2021-04-08 08:19:10 -06:00
5baccdf052
Move note_encryption into the sapling module.
2021-04-08 08:19:10 -06:00
636845d0f9
Renames to use lower-case abbreviations (matching Rust convention)
...
As of our MSRV bump to 1.51.0, we get lints for this.
2021-03-27 19:01:03 +13:00
4086df772c
Move sapling-specific primitives into the sapling module.
2021-03-27 16:18:21 +13:00
88d58aac0a
Move relevant utils into sapling module.
2021-03-27 16:18:21 +13:00
9d9c0579f8
Use new name for broken_intra_doc_links lint
...
We also add the lint to crates in the workspace that didn't have it.
Closes zcash/librustzcash#279 .
2021-03-27 08:27:17 +13:00
78f6432be6
zcash_client_sqlite: Minor tweaks to documentation
2021-03-26 18:47:59 +13:00
88fbd9f423
Add docstrings for zcash_client_sqlite.
2021-03-25 22:22:45 -06:00
334442c505
Address comments from review.
2021-03-17 09:21:10 -06:00
8a84203685
Remove Default impl from MemoBytes
...
Memo fields have two ways to encode an empty memo:
- 0xF6 followed by all-zeroes, encoding "there is no memo".
- All-zeroes, encoding the empty UTF-8 string.
In almost all cases you want the former, but users thinking about byte
slices may expect MemoBytes::default() to result in the latter. To
ensure clarity, we now require calling either MemoBytes::default() or
MemoBytes::from_bytes(&[]) to be explicit.
No such confusion exists for the Memo enum, because the two types are
visibly separated as different enum cases, and Memo::Empty makes sense
as the default.
2021-03-17 21:16:01 +13:00
c7a3ef0e88
Split memo-handling into MemoBytes struct and Memo enum
...
The MemoBytes struct is a minimal wrapper around the memo bytes, and only
imposes the existence of null-padding for shorter memos. The only error
case is attempting to construct a memo that is too long. MemoBytes is
guaranteed to be round-trip encodable (modulo null padding).
The Memo enum implements the additional memo rules defined in ZIP 302,
interpreting the contents of a memo (for example, parsing it as text).
2021-03-17 21:05:50 +13:00
48f7ef84a4
Move Memo into zcash_primitives::memo
2021-03-17 19:58:40 +13:00
5a9b29a75a
Address comments from code review.
2021-03-11 13:01:22 -07:00
0e022f2283
Allow block scanning using either IVKs or FVKs.
2021-03-09 21:00:40 -07:00
16289750e8
Remove WalletWrite::transactionally
2021-03-09 20:59:57 -07:00
a74cc8b231
Remove sqlite-specific data organization from data access api.
2021-03-09 20:59:57 -07:00
b5bbbb6f5a
Factor out nullifier update from database actions in scan_cached_blocks
2021-03-09 20:59:57 -07:00
463e252af4
Fix more intra-doc links
2021-03-04 23:01:42 +00:00
98530184c0
Fix clippy complaints.
2021-02-03 14:27:31 -07:00
df09877b11
Use an enum to distinguish between sent and received notes in sqlite backend.
2021-01-20 10:51:27 -07:00
779a5670e0
Improve data access api method documentation.
2021-01-19 12:45:55 -07:00
8fe6f0fdfd
Remove default get_balance method.
...
Recommended by @str4d
2021-01-19 08:25:10 -07:00
8e8ed2bb4f
Rename get_verified_balance -> get_balance_at
2021-01-15 12:00:14 -07:00
f59124ce19
Pass account ID with IVK.
2021-01-15 10:18:43 -07:00
8a7d051138
Rustfmt
2021-01-13 18:06:42 -07:00
5a21580f13
Correct the hierarchy of errors.
2021-01-13 15:20:11 -07:00
ce06db197a
Rustfmt.
2021-01-12 21:10:34 -07:00
011eda364f
Add get_spendable_notes method to WalletRead
2021-01-12 20:42:04 -07:00
48f226f8b5
Move decoding errors to sqlite crate.
...
Also move dependency on params out of wallet read/write methods.
The result is cleaner because these parameters are only required
for backend-specific encoding and decoding operations.
2021-01-12 20:07:02 -07:00
ca4567b275
More data api documentation.
2021-01-12 13:55:22 -07:00
7d92150965
Fix test compilation with WalletWrite changes.
2021-01-11 18:13:40 -07:00
aad2e174c1
Consistently use nullifier and AccountId newtypes.
2021-01-08 21:49:38 -07:00
56adbbb545
Make `WalletWrite` depend upon `WalletRead`.
2021-01-08 12:49:10 -07:00
e96578195a
Not sure how this happened.
2020-12-03 10:10:37 -07:00
d77784eba8
Do not update `is_change` in received_notes with null values.
...
Fixes #322
2020-12-02 13:16:02 -07:00
1fd74d0a71
Improve naming for wallet/block database connections.
2020-12-02 09:46:17 -07:00
897a70dd9e
Simplify block source & clean up chain validation.
2020-12-02 09:46:17 -07:00
8a215d67fe
Improve wallet "database" trait names.
2020-12-02 09:46:17 -07:00
f742895118
Fix test/doctest errors.
2020-12-02 09:46:17 -07:00
c60b9d3ece
Remove database initialization calls from common API.
2020-12-02 09:46:17 -07:00
4c2cda48e6
Clean up transactional API.
...
This API is still somewhat unsafe in that it doesn't inhibit nested
transactions, but it's better than it was.
2020-12-02 09:46:17 -07:00
cd2729bbd0
Move 'create_spend_to_address' to wallet backend.
...
This required changing a bit about the relationship between
database errors and wallet errors, and opens up the possibility
of now simplifying the error situation a bit.
2020-12-02 09:46:17 -07:00
e144015558
Reuse sent note insertion for wallet/transact.
2020-12-02 09:46:17 -07:00
68737dd1dd
Remove duplicate method.
2020-12-02 09:46:17 -07:00
8de05f3429
Move transact.rs to wallet module.
2020-12-02 09:46:17 -07:00
22ef05239c
Split init module into chain and wallet-related parts.
2020-12-02 09:46:17 -07:00
a181203179
Move related functions into the same modules.
2020-12-02 09:46:17 -07:00
eab2951c99
Move decrypt_and_store_transaction to zcash_client_backend
2020-12-02 09:46:17 -07:00
0165ae7003
Minor renamings.
2020-12-02 09:46:17 -07:00
d16c124ffe
Abstract over data access in scan_cached_blocks.
2020-12-02 09:46:17 -07:00
06c1772692
Move traversal of cached blocks to CacheOps
2020-12-02 09:46:17 -07:00
604294dd9f
Factor out nullifier retrieval into data api.
2020-12-02 09:46:17 -07:00
ffd503134d
Factor out witness retrieval from scan.
2020-12-02 09:46:17 -07:00
499dcd2e6c
Add the remainder of sqlite/query.rs functions to the data API.
2020-12-02 09:46:17 -07:00
56e6091876
Factor out `get_commitment_tree` from scan.
2020-12-02 09:46:17 -07:00
d16c74725e
Extract get_extended_full_viewing_keys function.
...
This required a bit of generalization of the data_api error types.
2020-12-02 09:46:17 -07:00
3eec6f8faa
Add get_balance, get_verified_balance to data api.
2020-12-02 09:46:17 -07:00
70de11dd32
Add address retrieval.
2020-12-02 09:46:17 -07:00
b72251ee28
Add accounts table initialization.
2020-12-02 09:46:17 -07:00
724fbac33a
Add database initialization implementation.
2020-12-02 09:46:17 -07:00
f3f3512068
Move get_target_and_anchor_heights to data_api.
2020-12-02 09:46:17 -07:00
9874abfd6c
Implement chain validation & fix doctests.
2020-12-02 09:46:17 -07:00
b1c3f9d3f0
ZIP 321 Reference Implementation ( #294 )
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2020-10-15 14:03:40 +01:00
80e1d35ea6
Apply additional suggestions from code review.
2020-09-18 10:40:30 -06:00
1ad9294933
Remove static determination of network state.
...
In the interest of making the library usable for both
testnet and mainnet without recompilation, static resolution
of network parameters has been replaced with a parameter passed
to the relevant functions. This also moves addres prefix constants
into the network parameters.
2020-09-17 10:34:42 -06:00
efaba87681
Add newtype for block height.
2020-09-17 10:26:41 -06:00
40e135783c
zcash_primitives: Support ovk = ⊥ in note encryption
...
Closes zcash/librustzcash#259 .
2020-08-28 21:17:16 +01:00
d15acf8acc
zcash_primitives: Rename Note::cm to Note::cmu
2020-08-21 18:35:04 +01:00
fdf06032e3
s/{pairing::bls12_381, zcash_primitives::jubjub}/{bls12_381, jubjub}
...
FINALLY.
2020-08-19 23:08:19 +01:00
c3d89644e2
Revert SaplingNoteEncryption::new() API to take rng instead of esk
2020-08-06 12:47:35 +08:00
9970a8aefd
Hard-code NetworkUpgrade::Canopy in generate_random_rseed
2020-08-06 12:27:20 +08:00
2ed9b6f881
Refactor contextual random rseed generation into util method in zcash_primitives
2020-08-05 15:21:42 +08:00
a25348dfba
Revert passing Parameters to methods
2020-08-05 12:47:29 +08:00
895e251793
Fix tests
2020-07-31 22:40:48 +08:00
4cfdacedec
zcash_client_sqlite: Support sending to t-addrs
2020-06-25 18:54:41 +12:00
380c2f726f
Chain validity and reorg handling
2020-06-25 18:54:41 +12:00
f0ce0c5530
Add mainnet support to zcash_client_sqlite via a feature flag
2020-06-25 18:54:41 +12:00
34725df086
zcash_client_sqlite::transact::create_to_address()
2020-06-25 18:54:41 +12:00
3ef03f2f1d
zcash_client_sqlite::scan::scan_cached_blocks()
2020-06-25 18:54:41 +12:00
72dd76e4db
zcash_client_sqlite::query::{get_balance, get_verified_balance}
2020-06-25 18:54:41 +12:00
c8b70e569c
zcash_client_sqlite::query::get_address()
2020-06-25 18:54:41 +12:00
c0cf55c127
SQLite database structure and initialisation
2020-06-25 18:54:34 +12:00
Kris Nuttycombe
Jack Grigg
Kris Nuttycombe
Kris Nuttycombe
Kevin Gorham
Francisco Gindre
Jack Grigg
therealyingtong