Commit Graph

3631 Commits

Author SHA1 Message Date
Kris Nuttycombe 8c78d7f2a0 Fix incorrect documentation link. 2024-02-19 10:34:07 -07:00
Kris Nuttycombe 27defb8711 Address comments from code review. 2024-02-16 10:59:29 -07:00
Kris Nuttycombe 4e3d99f1d0 zcash_client_backend: Allow proposer to specify fallback change pool.
In the event that the pool to which change should be sent cannot
automatically be determined based upon the inputs and outputs of a
transaction, it is up to the caller to specify where change should
be sent.
2024-02-15 21:44:59 -07:00
Kris Nuttycombe daf88a12e5 zcash_client_backend: Add support for creation of Orchard outputs. 2024-02-15 21:30:07 -07:00
Kris Nuttycombe f27f601b7d zcash_client_backend: Add Orchard spends to `create_proposed_transaction` 2024-02-15 21:29:15 -07:00
Kris Nuttycombe c6656c108b
Merge pull request #1187 from nuttycom/proposal_resolved_receivers
`zcash_client_backend`: Updates to the `Proposal` data structure
2024-02-15 21:28:20 -07:00
Kris Nuttycombe 74b487e4c9 Apply suggestions from code review
Co-authored-by: str4d <thestr4d@gmail.com>
2024-02-15 20:51:24 -07:00
Kris Nuttycombe 6aabe60d21 zcash_client_backend: Add validation to the `Proposal::multi_step` constructor. 2024-02-15 13:09:52 -07:00
Kris Nuttycombe dd6711aec1 zcash_client_backend: Address comments from code review & fix incorrect `data_api::wallet` documentation. 2024-02-14 20:24:12 -07:00
Kris Nuttycombe 4f206e415a zcash_client_backend: Implement multi-step transparent transaction support 2024-02-14 19:33:18 -07:00
Kris Nuttycombe beeea7b44e zcash_client_backend: Modify `Proposal` to make multi-step transactions representable. 2024-02-14 19:30:52 -07:00
Kris Nuttycombe 1db3109cb4 zcash_client_backend: Move the `Proposal` types to a `proposal` module.
This separation is in preparation for modifying the `Proposal` type
to wrap a vector of proposal steps.
2024-02-14 19:04:47 -07:00
Kris Nuttycombe 6e0d9a9420 zcash_client_backend: Add selected output pools to transaction proposals.
Fixes #1174
2024-02-14 18:58:48 -07:00
Kris Nuttycombe 0ef5cad2ff zcash_client_backend: Ensure we use the correct scope for transparent secret key derivation. 2024-02-14 17:38:55 -07:00
Kris Nuttycombe 7a5852598e zcash_keys, zcash_client_backend: feature-flag off transparent-input WalletRead methods.
This also moves the `TransparentAddressMetadata` type behind the
`transparent-inputs` feature flag and performs associated cleanup.
2024-02-14 17:38:52 -07:00
Kris Nuttycombe 0477ec0dc5
Merge pull request #1185 from nerdcash/nonhardenedchildindex
Declare and use NonHardenedChildIndex for transparent
2024-02-14 12:22:37 -07:00
Andrew Arnott f1b6dd0636
Switch out `AddressMetadata` for new struct 2024-02-13 18:34:33 -07:00
Andrew Arnott 8f6afb2182
Update changelogs 2024-02-13 18:02:24 -07:00
Andrew Arnott 9f221f869d
Fail instead of swallow on database corruption 2024-02-13 11:39:06 -07:00
Andrew Arnott 8003a39e1b
Add test coverage 2024-02-13 11:39:06 -07:00
Andrew Arnott 918f5cc812
Change `WalletRead::get_transparent_receivers` signature
It needn't return the account id that was given as an input, and it shouldn't return an 11-byte diversifier index when a 31-bit child index is more appropriate.
2024-02-13 11:39:06 -07:00
Andrew Arnott 1733af8718
Declare `NonHardenedChildIndex` struct 2024-02-10 12:46:46 -07:00
str4d 3cbc4815b6
Merge pull request #1183 from nuttycom/fix_backend_test_deps
zcash_client_backend: Fix missing `test-dependencies` feature dependency.
2024-02-09 17:29:51 +00:00
Kris Nuttycombe cd12efd123 zcash_client_backend: Fix missing `test-dependencies` feature dependency. 2024-02-08 16:50:47 -07:00
str4d 121438eaef
Merge pull request #1173 from zcash/1171-generalise-batch-runner
zcash_client_backend: Extend `BatchRunner` to support full outputs
2024-02-08 23:14:02 +00:00
Jack Grigg f6224e7e80 zcash_client_backend: Fix documentation for `BatchRunner::add_outputs` 2024-02-08 19:19:05 +00:00
Jack Grigg d56536c1d1 zcash_client_backend: Introduce `Decryptor` trait
This generalizes over batch decryption of either compact or full
outputs.

Closes zcash/librustzcash#1171.
2024-02-08 19:19:05 +00:00
Jack Grigg 11db94bf42 zcash_client_backend: Add `memo` field to `DecryptedOutput` 2024-02-07 22:28:34 +00:00
Jack Grigg 820e048898 zcash_client_backend: Renamed `DecryptedNote` to `DecryptedOutput` 2024-02-07 22:28:34 +00:00
str4d 74c036e870
Merge pull request #1172 from nuttycom/fix_ua_default_requests
zcash_client_sqlite: Do not request transparent UA components if "transparent-inputs" feature is disabled.
2024-02-07 22:27:40 +00:00
Kris Nuttycombe 7c0b9da9b7 zcash_client_sqlite: Do not request transparent UA components if "transparent-inputs" feature is disabled. 2024-02-07 14:49:48 -07:00
str4d 45df8b7853
Merge pull request #1149 from nuttycom/rename_taddr_variants
zcash_primitives: Rename `TransparentAddress` variants.
2024-02-06 22:04:20 +00:00
Kris Nuttycombe 9b7f13c8a9
Merge pull request #1159 from rex4539/typos
Fix typo
2024-02-06 11:47:05 -07:00
Kris Nuttycombe 5241c6fd29
Merge pull request #1164 from nuttycom/fix_broken_zip321_tests
zcash_client_backend: Fix broken `zip321` tests.
2024-02-06 11:30:51 -07:00
Kris Nuttycombe 3acd6348aa zcash_client_backend: Fix broken `zip321` tests.
These tests appear to have been broken by #1139; it's not clear
why CI passed on that at the time.
2024-02-06 10:36:31 -07:00
Dimitris Apostolou ced84cab36
Fix typo 2024-02-06 14:30:53 +02:00
Kris Nuttycombe 2360609f1a zcash_primitives: Rename `TransparentAddress` variants.
This resolves an old TODO.
2024-02-02 10:52:17 -07:00
Kris Nuttycombe 9b5abe1a38
Merge pull request #1145 from nuttycom/fix/serialize_empty_transaction_requests
zcash_client_backend: Allow serialization of empty transaction requests.
2024-01-30 18:06:21 -07:00
Kris Nuttycombe 11f5589595 zcash_client_backend: Allow serialization of empty transaction requests. 2024-01-30 16:42:31 -08:00
Daira Emma Hopwood e387c6ce3f
Merge pull request #1139 from nuttycom/keys/no_default_address_request
zcash_keys: Remove `UnifiedAddressRequest::DEFAULT`
2024-01-29 18:49:25 +00:00
Kris Nuttycombe 3f3efd2445 zcash_keys: Move proptest generators from `zcash_client_backend` 2024-01-27 07:59:55 -07:00
Kris Nuttycombe ea1d3a35db zcash_keys: Remove `UnifiedAddressRequest::DEFAULT`
This default only made sense in the context of what was supported by
`zcash_client_sqlite`, and not in any other context. Unified address
requests no longer have their parts conditioned by what feature flags
are available; instead, if a request is constructed for which the
required key parts are not supported under a particular selection of
feature flags, address generation will raise a runtime error.
2024-01-27 07:59:55 -07:00
Kris Nuttycombe 0fa76ff726
Merge pull request #1141 from zcash/ci-fix-flags
CI: Fix passing feature flags into preparation action step
2024-01-27 07:58:08 -07:00
Jack Grigg 85095af96e CI: Also set `RUSTDOCFLAGS`
`rustdoc` doesn't support all the same flags as `rustc`, so it doesn't
listen to `RUSTFLAGS` and has its own env variable. We are only setting
flags that both understand.
2024-01-27 00:31:00 +00:00
Jack Grigg b1d9689b8a Use `AccountId` in `orchard::keys::SpendingKey::from_zip32_seed`
This was necessary as of `orchard 0.7`, but due to CI not checking with
the `orchard` feature flag at the time the crate was updated, CI did not
catch this.
2024-01-27 00:08:38 +00:00
Jack Grigg c5af1e0dd2 CI: Fix passing feature flags into preparation action step 2024-01-27 00:03:03 +00:00
str4d 885223adc6
Merge pull request #1138 from zcash/sapling-and-orchard-crates
Migrate to `sapling-crypto 0.1` and `orchard 0.7`
2024-01-26 21:22:25 +00:00
Jack Grigg 8ca1fcee92 Migrate to `sapling-crypto 0.1` and `orchard 0.7` 2024-01-26 20:43:58 +00:00
str4d c583c80cd6
Merge pull request #1137 from zcash/vscode-rustflags
Add `zcash_unstable` to `RUSTFLAGS` for VS Code
2024-01-26 20:16:03 +00:00
Jack Grigg 17ce9302a2 Add `zcash_unstable` to `RUSTFLAGS` for VS Code
Necessary for the `--all-features` to work, allowing all code to be
compiled by `rust-analyzer`.
2024-01-26 19:52:58 +00:00