zec
/
librustzcash
mirror of https://github.com/zcash/librustzcash.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,196 Commits 12 Branches 89 Tags 45 MiB
Commit Graph

3196 Commits

Author SHA1 Message Date
Matthew Watt a788cc4c4d Fix merge conflicts 2023-10-12 06:16:22 -05:00
Kris Nuttycombe bcea060c86 Apply suggestions from code review 
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
 2023-10-11 14:15:19 -06:00
Kris Nuttycombe 1447d8ea01 zcash_client_backend: Move change memos into the `ChangeValue` components of `Proposal`s. 
The existing API limited change outputs to having only a single memo
repeated across each change output. This change makes it so that each
proposed change output can have its own associated memo, and leaves it
up to the input selector to determine how requested change memos are
associated with change outputs.
 2023-10-11 14:15:19 -06:00
Kris Nuttycombe 0ad81a09c0
Merge pull request #1013 from nuttycom/wallet/nonnegative_fees 
zcash_client_backend: Use `NonNegativeAmount` for fee and change amounts.
 2023-10-11 13:58:41 -06:00
Kris Nuttycombe a2b5c2c784 zcash_client_backend: Use `NonNegativeAmount` for fee and change amounts. 
In order to use `uint64` for amounts that must be nonnegative in the
`proposal.proto` file, it is useful to update fee and change computation
to use `NonNegativeAmount` where possible.
 2023-10-10 16:12:47 -06:00
Kris Nuttycombe 030c1825a8
Merge pull request #1011 from nuttycom/wallet/note_identifiers 
Make `ReceivedSaplingNote` internals private, and use (TxId, output_index) for note identifiers.
 2023-10-10 07:30:33 -06:00
Matthew Watt 73f263682e Remove unnecessary local 2023-10-10 07:50:07 -05:00
Matthew Watt 2a4d9e06da Run fmt 2023-10-10 07:47:08 -05:00
Matthew Watt b548e00c10
Update zcash_client_sqlite/src/wallet.rs 
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
 2023-10-10 06:36:40 -05:00
Matthew Watt 0e5a58b0b0
Update zcash_client_sqlite/src/wallet.rs 
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
 2023-10-10 06:36:20 -05:00
Matthew Watt 5de3fbb36b Fix logic error 2023-10-10 06:35:38 -05:00
Kris Nuttycombe 17013076ae
Merge pull request #1005 from zingolabs/add_marginal_fee 2023-10-09 16:55:07 -06:00
zancas 4bd3259ad0
Add a MARGINAL_FEE constant for the ZIP 317 marginal fee 2023-10-09 15:23:55 -06:00
Kris Nuttycombe 5b40ddf072 zcash_client_backend: Use globally unique identifiers for notes. 
Update zcash_client_backend error types to use (TxId, output_index)
as the identifier for notes instead of the internal database identifier.
 2023-10-09 12:44:27 -06:00
sasha 74840829c8 zcash_client_backend: Make `ReceivedSaplingNote` internals private. 
This also adds the txid and index to `ReceivedSaplingNote` for use as a
globally identifier for the note.
 2023-10-09 12:22:12 -06:00
Matthew Watt 13a2d5d7d4
Update wallet.rs 
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
 2023-10-09 10:07:31 -05:00
Matthew Watt 4bbe658f74
Update CHANGELOG.md 
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
 2023-10-09 10:06:37 -05:00
Matthew Watt a910fb86b6 Revert unnecessary change 2023-10-09 06:57:40 -05:00
Matthew Watt c4175342ac Cleanup 2023-10-09 06:46:12 -05:00
Matthew Watt 9d7ac07b1a Fix test build failures 2023-10-08 19:37:02 -05:00
Matthew Watt 029b7f0d69 Document fallback behavior for Orchard-only UAs 2023-10-08 19:27:20 -05:00
Matthew Watt 46ed4964c3 Display for PoolType 2023-10-08 19:19:51 -05:00
Matthew Watt 94f2240e08 Provide PoolType to UnsupportedPoolType case; stylistic changes 2023-10-08 19:05:50 -05:00
Matthew Watt a9d18ec2ce Gracefully handle attempted spend to a UA with neither transparent nor sapling recipients 2023-10-07 15:37:35 -05:00
Kris Nuttycombe a47b512f59
Merge pull request #1007 from zcash/sapling-trymapauth-etc 
Changes to Sapling bundle mapping
 2023-10-07 13:25:24 -06:00
Jack Grigg e1a4238a71 zcash_primitives: Add helper impls of `{Try}MapAuth` for closures 2023-10-06 23:48:27 +00:00
Jack Grigg 65efee1a16 zcash_primitives: Add `sapling::Bundle::try_map_authorization` 2023-10-06 23:46:02 +00:00
Jack Grigg b09b435135 zcash_primitives: Change `sapling::MapAuth` to take `&mut self` 2023-10-06 23:43:43 +00:00
Jack Grigg 241a1a3660 zcash_primitives: Add some more `Clone` and `Debug` impls 2023-10-06 22:05:49 +00:00
str4d 4737839662
Merge pull request #1006 from zcash/spend-output-prover-updates 
Updates to `SpendProver` and `OutputProver` traits and impls
 2023-10-06 23:01:07 +01:00
Jack Grigg 04aa5a044b zcash_primitives: Add `MockSpendProver` and `MockOutputProver` 
These are analogues of `MockTxProver` in that they implement the
corresponding Sapling prover traits.
 2023-10-06 20:31:31 +00:00
Jack Grigg 46903fabf5 zcash_proofs: `impl {SpendProver, OutputProver} for LocalTxProver` 2023-10-06 20:28:16 +00:00
Jack Grigg 296f75954b Add `SpendProver::encode_proof` and `OutputProver::encode_proof` 2023-10-06 20:19:41 +00:00
Kris Nuttycombe e6fa567332
Merge pull request #1000 from zingolabs/add_debugs_to_inputs 
add Debug to transaction builder-reported types
 2023-10-04 09:15:29 -06:00
Kris Nuttycombe b73c51f974
Merge pull request #1004 from zingolabs/add_fee_getter 
Add fee getter
 2023-10-03 12:04:29 -06:00
zancas b9f8ec8ed2
add pub getter to transaction builder 
use getter in original context to DRY

add doc-comment

Minor cleanup & documentation fixes.

Co-Authored-By: Daira Emma Hopwood <daira@jacaranda.org>
 2023-10-03 11:13:06 -06:00
str4d ad01585d34
Merge pull request #1001 from zcash/752-separate-sapling-provers 
Separate Sapling provers
 2023-10-02 18:47:47 +01:00
Jack Grigg 0d46fe72cc zcash_primitives: Introduce an `OutputProver` trait 2023-10-02 16:59:01 +00:00
Jack Grigg 290bfa8b31 zcash_primitives: Introduce a `SpendProver` trait 2023-10-02 16:59:01 +00:00
Jack Grigg ea0fed39eb zcash_proofs: Introduce newtype wrappers for Sapling parameters 2023-10-02 16:59:01 +00:00
Jack Grigg 2bfeef9430 zcash_proofs: Remove immediate verification of created Spend proofs 
It can be useful to verify proofs after they have been created, but we
were only doing this for spend proofs, not output proofs. It also
duplicated code from the verifier logic. Once the prover and verifier
have been refactored, it will be easier to just call the verifier
immediately after the prover.
 2023-10-02 16:59:01 +00:00
str4d eca7112963
Merge pull request #999 from zcash/737-move-sapling-circuits 
Move Sapling circuits from `zcash_proofs` to `zcash_primitives::sapling`
 2023-10-02 17:32:19 +01:00
Kris Nuttycombe 868d72030e
Merge pull request #989 from zcash/ci-fix-codecov 
CI: Fix Codecov check
 2023-10-02 09:23:59 -06:00
zancas b5e24751d6
add Debug to transaction builder-reported types 2023-09-29 12:55:06 -06:00
Jack Grigg db31105067 Move Sapling circuits from `zcash_proofs` to `zcash_primitives::sapling` 
Closes zcash/librustzcash#737.
 2023-09-29 18:36:54 +00:00
Jack Grigg 0ddcccdbac zcash_primitives: Move Sapling constants into `sapling` module 2023-09-29 17:39:43 +00:00
str4d 430e98b67f
Merge pull request #996 from nuttycom/wallet/scan_summaries 
zcash_client_backend: Return summary information from `scan_cached_blocks`
 2023-09-29 01:09:02 +01:00
Kris Nuttycombe c16e777222 zcash_client_sqlite: Fix zcash_proofs dev-dependency 2023-09-28 17:39:59 -06:00
Kris Nuttycombe a2e772c93a zcash_client_backend: Return summary information from `scan_cached_blocks` 
When scanning, a wallet only needs to update balance and transaction
information shown to users when the scan has resulted in a change to
wallet state. This modifies `scan_cached_blocks` to return the range of
block heights actually scanned, along with the counts of notes spent and
received by the wallet in that range.

Fixes #918
 2023-09-28 17:39:59 -06:00
Kris Nuttycombe 70c9d5a889
Merge pull request #997 from zcash/daa-internal-type-safety 
zcash_client_sqlite: Replace internal height tuples with `RangeInclusive`
 2023-09-28 16:12:30 -06:00