Francisco Gindre
e9eb5f8c0f
Remove unstable function `WalletWrite::remove_unmined_tx`
...
Closes #622
Used PR https://github.com/zcash/librustzcash/pull/621 as reference to
know what had been added and remove it.
2023-01-31 15:21:46 -03:00
Jack Grigg
7f970bb82f
Use `EphemeralSecretKey, EphemeralPublicKey, SharedSecret` types in APIs
2023-01-24 15:02:49 +00:00
Jack Grigg
ded14adbb3
Add `sapling::keys::DiversifiedTransmissionKey`
2023-01-24 15:02:38 +00:00
Jack Grigg
06ba399d80
Clean up the `sapling::Note` API
2023-01-24 15:02:32 +00:00
Jack Grigg
87d0bd7db1
Refactor `sapling::Note`
...
Its internals are now private, and it stores a `PaymentAddress` (and by
extension the diversifier) instead of `g_d`.
2023-01-24 15:02:27 +00:00
Jack Grigg
dff21222fb
Require `PaymentAddress` to contain a valid diversifier
2023-01-24 14:51:13 +00:00
Jack Grigg
42c332a7a8
Use `sapling::note::ExtractedNoteCommitment` type in APIs
2023-01-24 14:37:11 +00:00
Jack Grigg
49b1cb3e69
Bump MSRV for `zcash_primitives` and dependents to 1.60
...
The MSRVs of the component crates are left as-is, partly because our
dependencies don't require us to bump them, and partly because those
crates have no pending changes and are relatively stable. We also plan
to split the component crates out into a separate repository, where it
will be easier to have a separate MSRV.
Closes zcash/librustzcash#759 .
2023-01-19 23:48:24 +00:00
Kris Nuttycombe
95cbc7abaf
Merge pull request #734 from zcash/sapling-type-safety
...
Improve Sapling type safety
2023-01-05 13:12:45 -07:00
Kris Nuttycombe
125d2bc3d5
Merge pull request #727 from nuttycom/test/shield_transparent_funds
...
Add `shielding_threshold` argument to `shield_transparent_funds`.
2022-12-15 13:11:55 -07:00
Kris Nuttycombe
76f0f0510e
Update zcash_client_backend/CHANGELOG.md
...
Co-authored-by: str4d <thestr4d@gmail.com>
2022-12-15 11:10:32 -07:00
Jack Grigg
fee0b6a18d
Make Sapling transaction structs non-transparent
...
We instead provide getters for the struct fields.
2022-12-13 04:03:06 +00:00
Jack Grigg
38e3280545
Update generated protobuf bindings
2022-12-11 13:28:52 +00:00
Kris Nuttycombe
0f56f095c2
Add `shielding_threshold` argument to `shield_transparent_funds`.
...
Previously, the shielding threshold was fixed to 100000 zatoshis.
Fixes #726
2022-12-08 17:15:48 -07:00
Jack Grigg
1ea585fee9
zcash_client_backend 0.6.1
2022-12-06 08:18:34 +00:00
Jack Grigg
7e71cc5353
Add `tracing` spans to light client chain scanning
...
This enables downstream users to profile how much time is spent in each
of the main subcomponents of the current chain scanner.
2022-12-06 08:17:49 +00:00
Kris Nuttycombe
580f87dc3e
Merge pull request #701 from zcash/update-generated-protobufs
...
Update generated protobufs
2022-11-18 17:25:15 -07:00
Greg Pfeil
4b5086d51d
Parse ZIP 321 URIs without query parameters
...
Fixes #707 .
2022-11-17 18:44:36 -07:00
Greg Pfeil
29af0bcb29
Add a failing test for ZIP 321 URI without params
2022-11-17 17:10:21 -07:00
Jack Grigg
81f8f6a5a4
Update generated protobufs
...
`prost 0.11.2` added code formatting support, so the generated files now
better match what rustfmt produces.
2022-11-12 05:26:07 +00:00
Jack Grigg
a583255d45
Document that `decrypt_and_store_transaction` always stores the tx
...
Closes zcash/librustzcash#497 .
2022-11-11 22:11:59 +00:00
Jack Grigg
98dd130f3a
zcash_client_backend 0.6.0
2022-11-11 20:47:21 +00:00
Jack Grigg
c03ef4926a
zcash_proofs 0.9.0
2022-11-11 20:39:36 +00:00
Jack Grigg
c3b6e5a72a
zcash_primitives 0.9.0
2022-11-11 20:37:55 +00:00
Jack Grigg
318d1b7522
Clean up changelogs
2022-11-11 20:29:26 +00:00
str4d
53d56362cd
Fix typos in error type `Display` messages
2022-11-11 05:33:48 +00:00
Kris Nuttycombe
ed96131c4f
Add missing `std::fmt::Display` implementations for error types.
2022-11-10 21:17:57 -07:00
str4d
796b5a4fed
ZIP 317: Improve code comments
2022-11-11 00:58:31 +00:00
Kris Nuttycombe
73ab884073
Implement ZIP 317 fee estimation, calculation, & change selection
2022-11-10 15:30:13 -07:00
Kris Nuttycombe
847ba49761
Add dust note detection to change selection.
...
The change selection algorithm has the most useful information for
determining whether or not a note is dust, so this adds a new error case
to `ChangeError` that allows the change selection to report the presence
of input notes without economic value back to its caller.
2022-11-10 12:18:30 -07:00
Kris Nuttycombe
9a7dc0db84
Add traits for fee estimation and input selection
...
This adds a set of abstractions that allow wallets to provide
independent strategies for fee estimation and note selection, and
implementations of these strategies that perform these operations in the
same fashion as the existing `spend` and `shield_transparent_funds`
functions.
This required a somewhat hefty rework of the error handling in
zcash_client_backend. It fixes an issue with the error types whereby
callees needed to have a bit too much information about the error
types produced by their callers.
Reflect the updated note selection and error handling in zcash_client_sqlite.
2022-11-10 12:17:59 -07:00
str4d
6f4a6aa00c
Merge pull request #695 from nuttycom/fix_clippy_lints
...
Fix clippy complaints about generated protobuf code.
2022-11-05 00:15:47 +00:00
Kris Nuttycombe
fb8681adbb
Ignore clippy lints in generated protobuf modules.
2022-11-04 14:14:56 -06:00
Kris Nuttycombe
18e61346cc
Spend internal Sapling notes with the internal Sapling spending key.
2022-11-04 13:27:23 -06:00
Kris Nuttycombe
cdfca848ea
Improve type safety of note commitment tree node construction.
2022-11-03 18:44:48 -06:00
Kris Nuttycombe
1be86b7a54
Derive the correct note when spending from a change address.
2022-11-03 18:44:48 -06:00
Kris Nuttycombe
b68d37a0b1
Use DiversifiableFullViewingKey instead of ExtFVK where possible.
2022-11-03 18:44:45 -06:00
str4d
d4f4f5ad91
Merge pull request #658 from nuttycom/wallet/builder_explicit_change
...
Update the transaction builder to make change outputs explicit
2022-11-04 00:42:31 +00:00
Kris Nuttycombe
9c894ebf3e
Create per-protocol fees modules.
2022-11-03 15:07:14 -06:00
Kris Nuttycombe
37e78e1fe3
Expose less information about Sapling outputs to change calculation.
2022-11-03 09:56:50 -06:00
Kris Nuttycombe
1be97e9cef
Address comments from code review.
2022-11-03 09:56:08 -06:00
Jack Grigg
4d6e2bcf59
Merge pull request #642 from zcash/lightwalletd-grpc-bindings
...
zcash_client_backend: Add gRPC bindings behind feature flag
2022-11-03 05:32:29 +00:00
Jack Grigg
587e1fa60b
Fix clippy lints related to `prost` API usage
2022-11-03 05:02:39 +00:00
Kris Nuttycombe
9496fc6118
Add fee calculator to the transaction builder.
...
This adds a fee calculation strategy abstraction that can be used to
dynamically compute fees so that the total fees required may be taken
taken into account during note selection, and also removes automatic
change creation from the transaction builder.
Change outputs must now be directly created by the caller by the caller.
This is a necessary prerequisite for permitting fees to adjust based
upon the contents of the transaction being constructed.
The initial implementation of the fee strategy simply uses the current
default fee.
2022-11-02 08:28:16 -06:00
Jack Grigg
17a4830c70
zcash_client_backend: Add gRPC bindings behind feature flag
...
The lightwalletd service file is sourced from:
Git: https://github.com/zcash/lightwalletd
Rev: ad5ecda5fbb5e12799f926b8cd785d54fdd250c8
Closes zcash/librustzcash#585 .
2022-11-02 06:22:02 +00:00
Jack Grigg
379b703e6b
zcash_client_backend: Switch from `protobuf 2` to `prost 0.11`
...
The latter is maintained by the Tokio developers, and has easy
integration with the `tonic` gRPC library which is actively maintained.
2022-11-02 06:21:38 +00:00
Jack Grigg
3720b45feb
Categorise dependencies in `Cargo.toml` files
...
This should make it easier to upgrade dependencies in future.
2022-11-01 09:02:54 +00:00
Jack Grigg
a0016588ac
Remove unused dependencies
...
Some were only used by tests, others weren't used at all.
2022-11-01 09:02:27 +00:00
Kris Nuttycombe
334383f363
Allow shielding from multiple taddrs within a single transaction.
2022-10-25 13:17:21 -06:00
Kris Nuttycombe
efa95fcb39
Add `get_transparent_balances` to data api.
2022-10-25 12:53:54 -06:00