Kris Nuttycombe
59eef51b9e
Merge pull request #851 from zcash/simplify_parse_note_plaintext_ovk_args
...
Remove esk and ephemeral_key arguments from `parse_note_plaintext_ovk`
2023-05-31 12:54:04 -06:00
Kris Nuttycombe
36d7222685
Merge pull request #844 from zcash/temporary-zcashd-parse-sapling
...
zcash_primitives: Changes needed for `zcashd` Sapling oxidation
2023-05-30 17:30:47 -06:00
Kris Nuttycombe
fe3d0269d1
Add comments detailing the checks required prior to calling `check_note_validity`
2023-05-26 10:12:21 -06:00
Kris Nuttycombe
696a9be0a0
Update `zcash_primitives` to reflect argument changes to `parse_note_plaintext_without_memo_ovk`
2023-05-26 09:43:26 -06:00
Kris Nuttycombe
be89e81534
Remove `esk` and `ephemeral_key` arguments from `parse_note_plaintext_without_memo_ovk`
...
Fixes #850
2023-05-26 09:24:22 -06:00
Kris Nuttycombe
3ae90020c3
Merge pull request #848 from zcash/note-encryption-avoid-redundant-checks
...
Avoid redundant checks during note decryption
2023-05-26 09:10:52 -06:00
Kris Nuttycombe
d56c6624a6
Merge pull request #849 from nuttycom/upgrade_incrementalmerkletree
...
Upgrade `incrementalmerkletree` & `orchard` patch versions.
2023-05-25 14:47:15 -06:00
Kris Nuttycombe
980736806f
Upgrade `incrementalmerkletree` & `orchard` patch versions.
2023-05-25 12:33:25 -06:00
Kris Nuttycombe
4b3ea857df
Merge pull request #818 from nathan-at-least/resolve-RUSTSEC-2023-0018
...
Bump `tempfile` to 3.5.0 to mitigate RUSTSEC-2023-0018…
2023-05-22 20:19:43 -06:00
Jack Grigg
2ae4d87cbf
zcash_primitives: Remove redundant checks from Sapling note decryption
...
- The consistency check between `esk` and `ephemeral_key` is checked
inside `zcash_note_encryption::try_output_recovery_with_ock`.
- The `diversifier` validity check is necessarily performed when
deriving `pk_d` for the `ivk` pathway, so we keep it there for the
`ovk` pathway as well, and drop the check from the `PaymentAddress`
internal constructor.
2023-05-19 16:36:55 +00:00
Jack Grigg
a115a8f00f
zcash_note_encryption: Remove `esk` check requirement from `Domain::parse_note_plaintext_without_memo_ovk`
...
This method is only called from `try_output_recovery_with_ock`, and we
can instead rely on the check performed in `check_note_validity`,
reducing the number of checks that `Domain` implementations need to
perform.
The `esk` and `ephemeral_key` parameters become unused, and will be
removed in a subsequent commit (as this change needs to be synchronized
with the `orchard` crate).
2023-05-19 16:30:47 +00:00
Kris Nuttycombe
b341903ae2
Merge pull request #842 from zcash/msrv-1.65
...
Bump MSRV for `zcash_primitives` and dependents to 1.65
2023-05-19 09:28:43 -06:00
str4d
1bc8f9a1de
Merge pull request #847 from zcash/hotfix/zcash_client_sqlite-0.7.1
...
Back-merge hotfix/zcash_client_sqlite-0.7.1
2023-05-18 22:32:40 +01:00
Kris Nuttycombe
d4073cb2ec
Merge remote-tracking branch 'upstream/main' into hotfix/zcash_client_sqlite-0.7.1
2023-05-18 14:56:14 -06:00
str4d
a9733245e2
Merge pull request #846 from nuttycom/hotfix/zcash_client_sqlite/null_memo_crash
...
Return the empty memo when memo is not present.
2023-05-18 21:47:05 +01:00
Kris Nuttycombe
0780744443
Return the empty memo when memo is not present.
...
Memos may be absent for both sent and received notes in cases where only
compact block information has been used to populate the wallet database.
This fixes a potential crash in the case that we attempt to decode a
SQLite `NULL` as a byte array.
Fixes #384
(cherry picked from commit d99b4d4d6e
)
2023-05-18 14:34:27 -06:00
Kris Nuttycombe
fb8bf20a04
Merge pull request #843 from nuttycom/wallet/not_yet_fetched_memo
...
Update memo retrieval API to reflect that memos may not be present.
2023-05-17 11:07:54 -06:00
Kris Nuttycombe
ea84243e0f
Add `get_memo` change to the zcash_client_backend CHANGELOG
2023-05-17 08:56:24 -06:00
Jack Grigg
8db7a071a0
zcash_primitives: `impl DynamicUsage for sapling::Bundle<Authorized>`
2023-05-17 03:44:24 +00:00
Jack Grigg
26d95b4a0e
zcash_primitives: Temporarily expose v5 Sapling bundle parsing
...
This is currently exposed via `Transaction` for usage in `zcashd`, but
may be removed in future (if `zcashd` moves transaction parsing entirely
into Rust), or renamed and stabilised.
2023-05-17 03:44:24 +00:00
Kris Nuttycombe
d99b4d4d6e
Update memo retrieval API to reflect that memos may not be present.
...
Memos may be absent for both sent and received notes in cases where only
compact block information has been used to populate the wallet database.
This fixes a potential crash in the case that we attempt to decode a
SQLite `NULL` as a byte array. It does, however, introduce a slight
semantic confusion that will need to be considered in the case of future
updates where a note may not have an associated memo; at present, the
only reason we might not have the memo is that we might not have
retrieved the full transaction information from the chain, but in the
future there might be other possible reasons for this absence.
Fixes #384
2023-05-16 10:27:40 -06:00
Jack Grigg
a092da8d5d
Fix clippy lints for 1.65
2023-05-16 15:59:58 +00:00
Jack Grigg
6419e1e363
Remove `inferno` pin now that its MSRV is compatible with ours
2023-05-16 15:39:06 +00:00
Jack Grigg
8681b56d52
Bump MSRV for `zcash_primitives` and dependents to 1.65
2023-05-16 15:37:07 +00:00
dependabot[bot]
f1a2b95018
Bump codecov/codecov-action from 3.1.3 to 3.1.4
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.3 to 3.1.4.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/v3.1.3...v3.1.4 )
---
updated-dependencies:
- dependency-name: codecov/codecov-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-05-16 05:57:59 +00:00
Kris Nuttycombe
87212b6137
Merge branch 'main' into resolve-RUSTSEC-2023-0018
2023-05-12 09:08:59 -06:00
Kris Nuttycombe
bc55893267
Merge pull request #838 from daira/update-fee-constants
...
Revert #830 and instead modify `zcash_primitives::transaction::fees::fixed::FeeRule::standard()`
2023-05-09 13:17:27 -06:00
Kris Nuttycombe
a718810fa8
Update zcash_client_backend/src/data_api/wallet.rs
2023-05-09 12:32:56 -06:00
Kris Nuttycombe
6ceed86e9a
Merge pull request #839 from daira/fix-default-tx-expiry-delta
...
Update `DEFAULT_TX_EXPIRY_DELTA` to 40 blocks
2023-05-09 12:32:22 -06:00
Daira Emma Hopwood
32296e7327
Update `DEFAULT_TX_EXPIRY_DELTA` to 40 blocks, as specified in
...
<https://zips.z.cash/zip-0203#changes-for-blossom >. fixes #837 .
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 18:38:39 +01:00
Daira Emma Hopwood
9cc6319f26
Fix clippy lints.
...
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 17:59:03 +01:00
Daira Emma Hopwood
3903935234
Deprecate `transaction::components::amount::DEFAULT_FEE` and
...
`zcash_primitives::transaction::fees::fixed::FeeRule::standard()`.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 17:18:34 +01:00
Daira Emma Hopwood
736d11b45b
Change `transaction::fees::fixed::FeeRule::standard()` to use the ZIP 317
...
minimum fee (10000 zatoshis rather than 1000 zatoshis) as the fixed fee.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 16:42:41 +01:00
Daira Emma Hopwood
043cc59c76
Add `transaction::fees::zip317::MINIMUM_FEE` constant and
...
`transaction::components::amount::Amount::const_from_i64`.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 16:42:19 +01:00
Daira Emma Hopwood
4cf27126e5
Revert "Update DEFAULT_FEE to 10_000 from 1000"
...
This reverts commit 2a6dc59c5d
.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-05-09 13:15:52 +01:00
Kris Nuttycombe
d37e6adee5
Merge pull request #783 from nuttycom/upgrade_bridgetree
...
Upgrade `zcash_primitives` to use updated `incrementalmerkletree` types.
2023-05-08 12:00:00 -06:00
str4d
62bc15ccf0
Merge pull request #824 from zcash/823-secp256k1-0.26
...
Migrate to `secp256k1 0.26`, `hdwallet 0.4`
2023-05-08 18:55:14 +01:00
str4d
579ab92b93
Merge branch 'main' into 823-secp256k1-0.26
2023-05-08 18:53:33 +01:00
Kris Nuttycombe
ec29836df9
Remove `bridgetree` dependency from `zcash_primitives`.
...
This also now makes `zcash_extensions` use `incrementalmerkletree`
transitively via type aliases in `zcash_primitives`.
2023-05-04 15:42:39 -06:00
Kris Nuttycombe
c9f53ddde5
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2023-05-04 14:46:34 -06:00
Kris Nuttycombe
882d60a915
Merge pull request #830 from zingolabs/update_fixed_fee_to_zip317_minimum
...
Update DEFAULT_FEE to 10_000 from 1000
2023-05-04 14:39:06 -06:00
Kris Nuttycombe
4d32a8ac20
Remove serialization version constants.
2023-05-04 12:46:15 -06:00
Kris Nuttycombe
71f74d4ac1
Remove the `merkle_tree::incremental` module.
...
This consolidates all the seralization code for frontiers and
incremental witnesses in the `merkle_tree` module.
2023-05-04 12:46:15 -06:00
Kris Nuttycombe
6aaa96d377
Remove zcashd-specific `bridgetree` serialization.
2023-05-04 12:46:15 -06:00
Kris Nuttycombe
1f9747e15f
Move merkle tree types to the `incrementalmerkletree` crate.
...
This removes the `CommitmentTree`, `IncrementalWitness`, and
`MerklePath` types in favor of equivalent versions available
from the `incrementalmerkletree` crate.
2023-05-04 12:30:56 -06:00
Kris Nuttycombe
667a7b841e
Move-only: restructure merkle tree source for extraction.
2023-05-04 12:21:50 -06:00
Kris Nuttycombe
6f2cbfc7de
Factor serialization out from merkle tree data structures.
2023-05-04 12:21:47 -06:00
Kris Nuttycombe
831a6cd396
Remove superfluous inner functions now that tree depth is a constant.
2023-05-04 12:16:09 -06:00
Kris Nuttycombe
ec57d23115
Use const generics to set commitment tree & incremental witness depths.
...
This is in preparation for extraction into the `incrementalmerkletree`
crate, which is not Sapling-specific and therefore cannot hard-code
the depths of these data structures.
2023-05-04 12:16:09 -06:00
Kris Nuttycombe
69430c3da2
Upgrade incrementalmerkletree and use bridgetree crate for `Bridgetree`.
2023-05-04 12:08:38 -06:00